Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To:     "RaghuramChary.Jallipalli@microchip.com" 
        <RaghuramChary.Jallipalli@microchip.com>,
        Marc Zyngier <marc.zyngier@arm.com>
CC:     "Woojung.Huh@microchip.com" <Woojung.Huh@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: lan78xx: fix "enabled interrupts" warninig
Thread-Topic: [PATCH] net: lan78xx: fix "enabled interrupts" warninig
Thread-Index: AQHU7dHNU1pmmx19ukWi008Ht4Z+BqYx4peAgAAD1oA=
Date:   Mon, 8 Apr 2019 08:07:43 +0000
Message-ID: <20190408155947.3efcb1eb@xhacker.debian>
References: <20190408140301.3dcbccdd@xhacker.debian>
        <BL0PR11MB33292EC33542F7D4FE5208469F2C0@BL0PR11MB3329.namprd11.prod.outlook.com>
In-Reply-To: <BL0PR11MB33292EC33542F7D4FE5208469F2C0@BL0PR11MB3329.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 42dcfc6b-2225-498d-37fb-08d6bbf946a0
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020);SRVR:BYAPR03MB4021;
x-ms-traffictypediagnostic: BYAPR03MB4021:
x-microsoft-antispam-prvs: <BYAPR03MB40218E75A1CC4662C5C5A5D8ED2C0@BYAPR03MB4021.namprd03.prod.outlook.com>
x-forefront-prvs: 0001227049
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(39860400002)(346002)(396003)(376002)(366004)(189003)(199004)(51914003)(81156014)(99286004)(81166006)(486006)(110136005)(6486002)(54906003)(2501003)(316002)(14454004)(50226002)(446003)(11346002)(102836004)(25786009)(6436002)(5660300002)(8936002)(52116002)(26005)(6116002)(3846002)(72206003)(66066001)(6246003)(68736007)(2906002)(478600001)(476003)(9686003)(97736004)(4326008)(6512007)(105586002)(305945005)(8676002)(86362001)(186003)(71190400001)(53936002)(106356001)(6506007)(229853002)(386003)(1076003)(76176011)(14444005)(256004)(7736002)(71200400001)(39210200001);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR03MB4021;H:BYAPR03MB4773.namprd03.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:0;
received-spf: None (protection.outlook.com: synaptics.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: twQLTMYr/4F5HzcJPlNSRlqbd8nLlatNyaf+rnFEbRMaRtlda/LMKHOM5iLss4mTEJj0tREMyx/xgKEFd2BAbMhRtSMg8jbsVtgH1dAh+O026IEWN9z0pkoS9r/flbpyu7cv8tVsxz9eyvuhUopN62sQwDckb9RNCKj1sr3X+rbHD+hQMtrlReIX+/cUGp3RC4/c8+67ddS2ZBGYq4ibs5z0mVrQOlgnDo6NtpGiTQp4nU5trkdYhoWQUtVsD/y0gg/BsII6xXWzGUFxlX+DSjoSEYUUpCMdxwv6CvwdHFybI61CShTE4IO0c7hamssFFXkoul0PooqbdkqNSUgpUFC9jYr5wZhCQbzgHLdSN6vptdw1atv2GYi/MwPizSHoxnOlwQYLRAXc+yWlzhiJI2HKKXrQkPwkOStZ63hM0kw=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D712D61574FC944DBD3FEC1F684D77D2@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: synaptics.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42dcfc6b-2225-498d-37fb-08d6bbf946a0
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2019 08:07:43.0503
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335d1fbc-2124-4173-9863-17e7051a2a0e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4021
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 8 Apr 2019 07:46:03 +0000 wrote:

>=20
>=20
> >
> > Per my understanding, the proper handling of PHY irq is to make use of
> > PHY_IGNORE_INTERRUPT then call phy_mac_interrupt when
> > INT_ENP_PHY_INT is triggered.
> > =20
>=20
> Hi Jisheng,

Hi

> Thanks for the changes.
> Is this warning specific to any linux version?=20

In theory, no. I only tested 5.0, 4.20, both can reproduce this warning.

> Why do you think PHY irq domain handling is not proper?

+ Marc

The warning comes from calling generic_handle_irq() in usb tasklet context.
This is not correct.

Per my understanding, if there's chained irq, we could introduce extra
irqdomain. E.g

GIC <--> another irqchip controller <--> HW device

But in lan78xx, this is not the case. There's no chained irq at all.
In fact, there's a bit INT_ENP_PHY_INT in MAC's Interrupt Endpoint status
word to indicate this is PHY interrupt. So this is the case
PHY_IGNORE_INTERRUPT/phy_mac_interrupt intend for.

irq experts knows irqdomain etc better, maybe they can provide more inputs

> Maybe we can fix that rather removing complete IRQ domain code changes.
> Also, Can you pls let us know how this changes fixed your warning.

The patch removes the generic_handle_irq() calling from invalid context.

Thanks