Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] block: remove CONFIG_LBDAF
To:     Christoph Hellwig <hch@lst.de>, axboe@kernel.dk
Cc:     torvalds@linuxfoundation.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20190405160859.5288-1-hch@lst.de>
From:   Hannes Reinecke <hare@suse.de>
Message-ID: <5cd01b3f-84c3-0159-1036-49fca809d171@suse.de>
Date:   Mon, 8 Apr 2019 10:30:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190405160859.5288-1-hch@lst.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/5/19 6:08 PM, Christoph Hellwig wrote:
> Currently support for 64-bit sector_t and blkcnt_t is optional on 32-bit
> architectures.  These types are required to support block device and/or
> file sizes larger than 2 TiB, and have generally defaulted to on for
> a long time.  Enabling the option only increases the i386 tinyconfig
> size by 145 bytes, and many data structures already always use
> 64-bit values for their in-core and on-disk data structures anyway,
> so there should not be a large change in dynamic memory usage either.
> 
> Dropping this option removes a somewhat weird non-default config that
> has cause various bugs or compiler warnings when actually used.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)