Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2760416yba; Mon, 8 Apr 2019 04:14:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqz8yLtPj38dohF8e39RqWhL8bXmPXDrkkFyR3mEbjLfbPnKzuNWGmhyzrJdC8Qd0WSxz7vo X-Received: by 2002:a62:209c:: with SMTP id m28mr28507865pfj.233.1554722081717; Mon, 08 Apr 2019 04:14:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554722081; cv=none; d=google.com; s=arc-20160816; b=lXnbxxjlRYlTgQrwyRubrTp3dZJ7tsEQJXEY/MvUjdK9vTMB66D9tRNnmBnCA/rz2w 2u9z7JPcw8+WTt8WU0cxk1uVvVHjcyCJN/V2LJ8apEkZxP9T9wnQwJXp3peD6kTA1yqp 3Rg2ep3DvsG3ig2YCj4cBXqherQYe90EglhHDgK75TMINs1ye7NYTpvrj2D7eaah3TOs ACwdTbJupobYfZeDtbLtQidCrAqdv+q3hdGXGGt8t8wOe0RdCfuUWspA85f7q01en9F3 Fw5yL8bLE2wklUzeF/I6R6DGsA3U+0qlm4bDbVIf2qxBGA8R7Qe5cSgilpA+BTx97hdS l9Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=qwkXqgt6Z39ImxEQrigZsTIEDNj9H3RCV97gTs9dBS8=; b=fVinUMrJpGRqujOvcPVATXevmgnrz4KShclCiBnVXOYzsXnVzAwNTAYqdzO1ZN06Or Fup+CWTIt7EaDOVCogbG0o/EJEz+ppnDli/g1v0Nim3sOvUsngxYBO9X3PBJuEOetRKm Yc/1HzJbwGm5NBC5y3kzMIgBAojnP/9M0luF+IXAQufvQmmlNOpbAnSmAVdsRTDa5TYU X4M/ApIk55LF32T5gg/wk3+I0e3/ckqkut0uZ/vnjVuKh37EPMlT6JA27G9LNz9nOkG5 TbaY+h33piWp8vKs2TwFt5w26ujbTALuq9QuYyg2pfw9O/zgz09dE1NGFNOL0GEhDY4t y8QQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y6si26229388plp.201.2019.04.08.04.14.26; Mon, 08 Apr 2019 04:14:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726466AbfDHLNq (ORCPT + 99 others); Mon, 8 Apr 2019 07:13:46 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:2104 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725881AbfDHLNq (ORCPT ); Mon, 8 Apr 2019 07:13:46 -0400 Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.53]) by Forcepoint Email with ESMTP id ED0A2D5609EF16DF3179; Mon, 8 Apr 2019 19:13:43 +0800 (CST) Received: from dggeme763-chm.china.huawei.com (10.3.19.109) by DGGEMM403-HUB.china.huawei.com (10.3.20.211) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 8 Apr 2019 19:13:43 +0800 Received: from [10.134.22.195] (10.134.22.195) by dggeme763-chm.china.huawei.com (10.3.19.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 8 Apr 2019 19:13:43 +0800 Subject: Re: [PATCH 1/5] f2fs: clean up codes with op_is_write() To: Jaegeuk Kim CC: , , References: <20190402105222.28374-1-yuchao0@huawei.com> <20190405163137.GC51212@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: Date: Mon, 8 Apr 2019 19:13:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190405163137.GC51212@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-ClientProxiedBy: dggeme708-chm.china.huawei.com (10.1.199.104) To dggeme763-chm.china.huawei.com (10.3.19.109) X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/4/6 0:31, Jaegeuk Kim wrote: > On 04/02, Chao Yu wrote: >> This patch uses generic function op_is_write() to instead private defined >> macro is_read_io() for cleanup. > > I don't see huge reason to clean up this, but do expect huge backporting issue. Got it. Thanks,