Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2912857yba; Mon, 8 Apr 2019 07:19:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqzeDGpbQxzT/XHgpUpuXHpqGJJktwUVrwe1BuD4sqTFur5bwB0T4R8ngGQ2fyhq9bO272Jh X-Received: by 2002:a63:fa54:: with SMTP id g20mr27406052pgk.242.1554733186093; Mon, 08 Apr 2019 07:19:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554733186; cv=none; d=google.com; s=arc-20160816; b=oVpwarP8ZtieZmRM94ecgq6vM+qVvt7fmaPBc2+i9CzKxPvx+hf9WNBY5k3OCEXoqI c+zmFdCp1QCKYJO0/63BckMr/kHcFesJwm7dT2xDy6vYfzmc4jYJ+lD8UFI0FtoLJXGv A62USM2ghRvCL/OnU8m7hDyknz409i0PP/TOn5oWce+8i8g/H1nnOz3Uj2Y3f4BP6QvX f4SnuNGTpf4+sAhtJjYUdyyzXou37mt2lc2XNa1oeif2kAALnytkp6lErSs9xpjjgiMd VpSVX7GIxZLih/aGFfjXiXa22UpI539N/wS5S6Y9ky9TEDK+KQZeYEUFg7m8Rj/DxUcT 2Fxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=gS9xFxhXXJcMvgmyqpRqdW7KqTWN4kKN70ZYXQN4FaA=; b=tMZNeFcCMODmBPMjZF2yItqErl9/4S59eXCduVzCzBCCeVDBzJEYzrzTk5WXdaVirZ 5pi/Um9DaQ65nX/n62Mg7KSotOyPgK/ZKW62QZApoTE8wzVcuCG2CJhHG9SCCjBuaLRd rJ4ReVuWjw1X3gUfZR5LBxbdohO1Px2A31CKJDBMPLaIUUVkCvf6MduyeJLyCzZZEzt6 wgVpg8hm5Ion/Sk7auRGdHCs1u6OQ0alVyTl1l5+mnBjIDx4T72w2iSA3gwsaRfZMcnP rfDLGBlpKBi9v0DnjxsQTIs06lrhm0WFusXE3GXS0A5jwZlaelDzspbkyvvnCqk3LHKp cUaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GrJEHx3+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a1si18452319plp.120.2019.04.08.07.19.30; Mon, 08 Apr 2019 07:19:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GrJEHx3+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726997AbfDHOSa (ORCPT + 99 others); Mon, 8 Apr 2019 10:18:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:41938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726349AbfDHOSa (ORCPT ); Mon, 8 Apr 2019 10:18:30 -0400 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 46AC521874; Mon, 8 Apr 2019 14:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554733109; bh=b/U5fiYDzwfWwfq+SqFsOxNxS6nF6VO46Y5PxuCqocY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GrJEHx3+l2xpzxoaIGJ6GNOWnemrI6VYURV/ZUx8qYYNmAlzxzIjhq1F5LxxqXGwu /0PDquF197x0sfDBnfGLQ7mgqzPwL4Tu/6ZudBPuWnnu6VCyHt9imKgQWDnDWqE/Lb DGZAGuHWHEK4AhqcZOWv+wZri3G7yjBd10NuzCPk= Received: by mail-ed1-f43.google.com with SMTP id d11so11827917edp.11; Mon, 08 Apr 2019 07:18:29 -0700 (PDT) X-Gm-Message-State: APjAAAVLkGDYD7b7yp/FcP1usDBdXvROHme86/FVJW/fv2UKJTs/wObm 3ggEV6AkvNONreSOwj4XhwJg3KcJUe0WEFlTYe8= X-Received: by 2002:a17:906:8281:: with SMTP id h1mr17171859ejx.124.1554733107804; Mon, 08 Apr 2019 07:18:27 -0700 (PDT) MIME-Version: 1.0 References: <20190402123123.915-1-nava.manne@xilinx.com> <20190402123123.915-4-nava.manne@xilinx.com> In-Reply-To: From: Alan Tull Date: Mon, 8 Apr 2019 09:17:51 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp To: Nava kishore Manne Cc: Moritz Fischer , Rob Herring , Mark Rutland , Michal Simek , Rajan Vaja , Jolly Shah , "linux-fpga@vger.kernel.org" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel , kishore m Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 8, 2019 at 7:39 AM Nava kishore Manne wrote: > > Hi Alan, > > Thanks for look into it and providing the ACK. > I got one minor comments from Moritz Fischer do you want me fix that issu= e now or I can fix it later as it=E2=80=99s a minor comment? Please fix for Moritz comment. > In which kernel version i can expect this driver changes?? Patch 2/3 and 3/3 are dependent on 1/3 which isn't a drivers/fpga thing, it's drivers/firmware. Alan > > > Regards, > Navakishore. > > > -----Original Message----- > > From: Alan Tull [mailto:atull@kernel.org] > > Sent: Tuesday, April 2, 2019 11:57 PM > > To: Nava kishore Manne > > Cc: Moritz Fischer ; Rob Herring ; = Mark > > Rutland ; Michal Simek ; Raja= n > > Vaja ; Jolly Shah ; linux- > > fpga@vger.kernel.org; open list:OPEN FIRMWARE AND FLATTENED DEVICE > > TREE BINDINGS ; moderated list:ARM/FREESCAL= E > > IMX / MXC ARM ARCHITECTURE ; linu= x- > > kernel ; kishore m > > > > Subject: Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support f= or > > Xilinx zynqmp > > > > On Tue, Apr 2, 2019 at 7:32 AM Nava kishore Manne > > wrote: > > > > Hi Nava, > > > > Looks good. > > > > > > > > This patch adds FPGA Manager support for the Xilinx ZynqMP chip. > > > > > > Signed-off-by: Nava kishore Manne > > Acked-by: Alan Tull > > > > > --- > > > Changes for v4: > > > -Updated the Fpga Mgr registrations call's > > > to 5.0 > > > -Removed dma_set_mask_and_coherent() As the FW > > > supports only 32-bit address operations. > > > > > > Changes for v3: > > > -Created patches on top of 5.0-rc5. > > > No functional changes. > > > > > > Changes for v2: > > > -Fixed some minor coding issues as suggested by > > > Moritz > > > > > > Changes for v1: > > > -None. > > > > > > Changes for RFC-V2: > > > -Updated the Fpga Mgr registrations call's > > > to 4.18 > > > > Thanks, > > Alan