Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: CBL issue #431: lld: x86_64: sysfs: cannot create duplicate
 filename $module/.rodata.cst{16,32}
From:   Denys Vlasenko <dvlasenk@redhat.com>
To:     sedat.dilek@gmail.com
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org
References: <CA+icZUVW2X6G=qukJTrZuUevcnrOiuShJGxnxVaqyONNxv+RYg@mail.gmail.com>
 <e5d3d2fc-874c-a8e3-1320-f9396a3621b5@redhat.com>
Message-ID: <99dde862-6aee-65a0-8b39-33b8ac10df45@redhat.com>
Date:   Mon, 8 Apr 2019 15:58:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <e5d3d2fc-874c-a8e3-1320-f9396a3621b5@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/8/19 3:56 PM, Denys Vlasenko wrote:
> I propose to change section name, append _module_ name and optionally
> a comment why this is done:
> 
>   /* NB: section is mergeable, all elements must be aligned 16-byte blocks */
> +/* There is more than one object in this section, let's use module name
> +   as unique suffix */

Probably not clear enough... maybe this is better:

+/* There is more than one object in this section, let's use module name
+   instead of object name as unique suffix */
-.section        .rodata.cst16, "aM", @progbits, 16

and do not use '-' in the name, replace with '_':

+.section        .rodata.cst16.cast6_avx_x86_64_asm_64, "aM", @progbits, 16