Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 8 Apr 2019 09:55:51 -0700
From:   Sean Christopherson <sean.j.christopherson@intel.com>
To:     Hariprasad Kelam <hariprasad.kelam@gmail.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: fix warning Using plain integer as NULL pointer
Message-ID: <20190408165551.GD25880@linux.intel.com>
References: <20190406093658.GA7438@hari-Inspiron-1545>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190406093658.GA7438@hari-Inspiron-1545>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Nit: For future reference, wrapping the warning text with quotes in the
     shortlog would be helpful.  I initially read it as "fix a warning by
     using a plain integer as a NULL pointer".  E.g.:

     KVM: x86: fix warning "Using plain integer as NULL pointer"

On Sat, Apr 06, 2019 at 03:06:58PM +0530, Hariprasad Kelam wrote:
> Changed passing argument as "0 to NULL" which resolves below sparse warning

Nit: Use imperative mood to state what the patch does, as opposed to
     talking about the change in the past tense.  That allows using past
     tense to describe things that actually did happen in the past.  E.g.:

     Pass "NULL" instead of "0" for a pointer argument when querying
     KVM_CAP_NESTED_STATE to resolve the below sparse warning:

> 
> arch/x86/kvm/x86.c:3096:61: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>

Thanks for the fix!

Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>

> ---
>  arch/x86/kvm/x86.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 099b851..39034ec 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -3093,7 +3093,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
>  		break;
>  	case KVM_CAP_NESTED_STATE:
>  		r = kvm_x86_ops->get_nested_state ?
> -			kvm_x86_ops->get_nested_state(NULL, 0, 0) : 0;
> +			kvm_x86_ops->get_nested_state(NULL, NULL, 0) : 0;
>  		break;
>  	default:
>  		break;
> -- 
> 2.7.4
>