Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3069371yba; Mon, 8 Apr 2019 10:24:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqzHap5OrhYf6DCQPDNUbVKzl4K3BsB4pDjAwqYQMChLU9pWJjn3zwBtzwGJB0UpCgVuE0aB X-Received: by 2002:a65:6389:: with SMTP id h9mr29861250pgv.398.1554744271708; Mon, 08 Apr 2019 10:24:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554744271; cv=none; d=google.com; s=arc-20160816; b=CAIPMkOodCBLOv9ip7rQ0M964+mw+yU5ELLExKtq/GIhP5w1y0gJ8VVAgyFTAiJoLF 7gLoBG7v/qavbpbbSzHxSkPBthS6DzRexOUoSJDDqaZtMIdg1d7dFRcw0bC77V2l1srj JjbeHnX8vsru6i821sgkBkno5w0idCwpb83ooAM2EU0cozfmGw6nwuVavraKO3ne9qFM m2oQgnUuRjcCGQ8km/5L3T8hCmNlF2uifjG8elj0hF4HtghjHtb4oFttXoOGVibKtKVF yV33l+iMC5nH1bKr/ytNvEecGZKb9P7erfEOD3Gp8mmGGE90w2Bl4+VbRVQ+pX2osk4c Rygw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Byy5kOClraa0aVDJor2uBGEK9eh4qRTjGxN6KzyCkbA=; b=Tpi+QWOYZJmYXdb5CHAiBy/wiAVC2G99XMd8U1TRFBbNtHKxcshZA6lmYkJ5nqPBwn ysYcrxtoOKnLSwnMq9tmVzWk2X1vgty7OYJA4PsB0jVQa0eivroHF8w/1aHIBoazH7JE 8NFCcEwxbokmKR0l9g027TQPq7prg2C0IIFPEYJGVrKeVwpY8vaIvlgdv0h09hgq43Gv NXBcok7FjvU1yD5AHCkyHTTn680qswIP+mpgoU54+OGJNRlHOh1rIJ+VtU7vJ+W2BajU GejI6XxWwa7uRkL2YTeoSCr1XTIFdqhYVo1HYH9fMjmhFri8PFMhD82UepFhNDlK07uz zjIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j62si12033666pgd.87.2019.04.08.10.24.16; Mon, 08 Apr 2019 10:24:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727460AbfDHO5s (ORCPT + 99 others); Mon, 8 Apr 2019 10:57:48 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:34664 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726532AbfDHO5s (ORCPT ); Mon, 8 Apr 2019 10:57:48 -0400 Received: by mail-qt1-f196.google.com with SMTP id k2so15803777qtm.1 for ; Mon, 08 Apr 2019 07:57:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Byy5kOClraa0aVDJor2uBGEK9eh4qRTjGxN6KzyCkbA=; b=OBEhu8vmu72INrKPgDRr6QOfoMtH5B1KvG4NBiAGU6pgDkYS1MyAuhUwdhckzAjpcV RbUMQ6sRRY5zsglTj1pXbQ/B6XeNUTs6jHG9UxLqnOLXf8MiU4gpgKLP6QHspwMqwcIG u2b25BzH7KdZeulEmChI3qNojI2jBKd6ViI6+sUKi6hf5uRYJBn9P+wMkdJx0VULdWUP SCm3JWGQwKkFe4OKnRCqJM/PSgNghlyac6VjqWVNvpsMMtkQ314t9VgS54GTKf1zC63b 2bQvU9qj/NRnOM3PzesMMDjTlhydX/YeEOXMJsIu4o2tKDmtxpzu+feBCp9J1KXe8rDj IRgw== X-Gm-Message-State: APjAAAXEb69RFm6aycu7TMOcBXnKEAUVc4OJw9qYhcCqItKi6po2o60U 7TgZi/XNTst8u9EgQn3j30QJwQ== X-Received: by 2002:a0c:d2fa:: with SMTP id x55mr23378285qvh.161.1554735467361; Mon, 08 Apr 2019 07:57:47 -0700 (PDT) Received: from redhat.com (pool-173-76-246-42.bstnma.fios.verizon.net. [173.76.246.42]) by smtp.gmail.com with ESMTPSA id n184sm15313931qke.29.2019.04.08.07.57.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Apr 2019 07:57:46 -0700 (PDT) Date: Mon, 8 Apr 2019 10:57:44 -0400 From: "Michael S. Tsirkin" To: Stefano Garzarella Cc: Stefan Hajnoczi , Stefan Hajnoczi , netdev@vger.kernel.org, Jason Wang , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed Message-ID: <20190408105619-mutt-send-email-mst@kernel.org> References: <20190404105838.101559-1-sgarzare@redhat.com> <20190404105838.101559-4-sgarzare@redhat.com> <20190405082447.GD25152@stefanha-x1.localdomain> <20190405100747.dbwi3sjaudp3d2wa@steredhat> <20190408093723.GP15001@stefanha-x1.localdomain> <20190408145531.yreyawkn5vjqj7sl@steredhat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190408145531.yreyawkn5vjqj7sl@steredhat> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 08, 2019 at 04:55:31PM +0200, Stefano Garzarella wrote: > > Anyway, any change to this behavior requires compatibility so new guest > > drivers work with old vhost_vsock.ko. Therefore we should probably just > > leave the limit for now. > > I understood your point of view and I completely agree with you. > But, until we don't have a way to expose features/versions between guest > and host, Why not use the standard virtio feature negotiation mechanism for this? > maybe is better to leave the limit in order to be compatible > with old vhost_vsock. -- MST