Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/1] block, bfq: delete "bfq" prefix from cgroup filenames
To:     Paolo Valente <paolo.valente@linaro.org>,
        Johannes Thumshirn <jthumshirn@suse.de>
Cc:     linux-block <linux-block@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        'Paolo Valente' via bfq-iosched 
        <bfq-iosched@googlegroups.com>,
        Oleksandr Natalenko <oleksandr@natalenko.name>,
        Angelo Ruocco <angeloruocco90@gmail.com>,
        lennart@poettering.net
References: <20190408143935.9062-1-paolo.valente@linaro.org>
 <20190408143935.9062-2-paolo.valente@linaro.org>
 <20190408144925.GA23021@linux-x5ow.site>
 <7B68DAA9-61D9-4AE0-9FA9-05C07C7FE408@linaro.org>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <51290bbe-21e0-1f12-d163-78dfe0d09bac@kernel.dk>
Date:   Mon, 8 Apr 2019 09:01:18 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <7B68DAA9-61D9-4AE0-9FA9-05C07C7FE408@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/8/19 8:54 AM, Paolo Valente wrote:
> 
> 
>> Il giorno 8 apr 2019, alle ore 16:49, Johannes Thumshirn <jthumshirn@suse.de> ha scritto:
>>
>> On Mon, Apr 08, 2019 at 04:39:35PM +0200, Paolo Valente wrote:
>>> From: Angelo Ruocco <angeloruocco90@gmail.com>
>>>
>>> When bfq was merged into mainline, there were two I/O schedulers that
>>> implemented the proportional-share policy: bfq for blk-mq and cfq for
>>> legacy blk. bfq's interface files in the blkio/io controller have the
>>> same names as cfq. But the cgroups interface doesn't allow two
>>> entities to use the same name for their files, so for bfq we had to
>>> prepend the "bfq" prefix to each of its files. However no legacy code
>>> uses these modified file names. This naming also causes confusion, as,
>>> e.g., in [1].
>>>
>>> Now cfq has gone with legacy blk, so there is no need any longer for
>>> these prefixes in (the never used) bfq names. In view of this fact, this
>>> commit removes these prefixes, thereby enabling legacy code to truly
>>> use the proportional share policy in blk-mq.
>>>
>>> [1] https://github.com/systemd/systemd/issues/7057
>>
>> Hmm, but isn't this a user-space facing interface and thus some sort of ABI?
>> Do you know what's using it and what breaks due to this conversion?
>>
> 
> Yep, but AFAIK, the problem is exactly the opposite: nobody uses these
> names for the proportional-share policy, or wants to use these names.  I'm
> CCing Lennart too, in case he has some improbable news on this.
> 
> So the idea is to align names to what people expect, possibly before
> more confusion arises.

We can't just rename them since they've already been in a shipped kernel.
The window for doing this passed long ago.

-- 
Jens Axboe