Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in
 test_memcg_subtree_control()
To:     Roman Gushchin <guroan@gmail.com>, linux-kselftest@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, Roman Gushchin <guro@fb.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        shuah <shuah@kernel.org>
References: <20190328025659.25684-1-guro@fb.com>
From:   shuah <shuah@kernel.org>
Message-ID: <32b7ae48-99dd-1261-4086-37d416ffcfd5@kernel.org>
Date:   Mon, 8 Apr 2019 12:53:39 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190328025659.25684-1-guro@fb.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/27/19 8:56 PM, Roman Gushchin wrote:
> Dan reported, that cleanup path in test_memcg_subtree_control()
> triggers a static checker warning:
>    ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \
>    test_memcg_subtree_control()
>    error: uninitialized symbol 'child2'.
> 
> Fix this by initializing child2 and parent2 variables and
> split the cleanup path into few stages.
> 
> Signed-off-by: Roman Gushchin <guro@fb.com>
> Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Shuah Khan (Samsung OSG) <shuah@kernel.org>
> Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>


 From and Signed-off don't match. Please fix it and resend the patch.

thanks,
-- Shuah