Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3197575yba; Mon, 8 Apr 2019 13:16:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqyYDyUDMsAHBUI2HN5xal1AI6z0nOY99gjRpEpU4/7ETinxOn0bAiIrCYaFyjmwOUPZczN+ X-Received: by 2002:a17:902:2b88:: with SMTP id l8mr30814970plb.262.1554754593310; Mon, 08 Apr 2019 13:16:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554754593; cv=none; d=google.com; s=arc-20160816; b=soK9ac6a7zSEwjQ2VUQ7kbB+M2jwPA2tlQSa3BHDKldNc77ZR9w0IO2Em2iAzo02iD 0lC09DxuE2mxXMMqEqX0Al0vUJMk9HGytYzHzLqPJ5M/Z/yZvYkY/FF7c63vYN6wPm2U vwkFeIEcnhRh82V0qnfAtyeUWtAj0xdMg6ZtHLsM70c2P1BLkLlxWO82XlqKlz30E9eu cBHpxowQv7qy0ipzx3XOgJTpDQWbu5mlvpCucazhSVuL9nPXpoOzarkmA60lJn+FNXAE s6DkqY7seJiCjX58vHPHfw7OEFosTWj3IYPuSCd9vGTpyv85qV7eFebGzfDeRyp/VQyk cg8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=RZrxqXiL1wX+MGVxXvmkyTNDR0wQtsF4s7GzXsQ+qMA=; b=qLcP5F1+Ob/R6Uldla42ltxAeiJhAT0ycYe6bL2scaLNEv9esKeBHjDRBVvlffNvT8 n8FWLKy1SUzdy6/GXI9xXYCANHwXrWWLBlBdvS+dIiyCWDL8MuYVELBZEeR+WUzVBZ// nJCy3OdliLSmFppRn0lMEA9Pey7x9DNJ17NXUmson+gkaXqwjdfAMNQ5VwJ5SdW+yrbx p+IFGQFp2Upla7vtnezZnc3RiLmOTPvwlCLjrSiMICE6wB1GjQkZZSGO7pVosw+V1RMt 9gcBkSon0vcPNQfIMgAS+br42ukZWqo4/fB9EtGSTSYV9+UYGjWyXkMXafLQR6HnpkqB UBuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n10si20972335plp.130.2019.04.08.13.16.15; Mon, 08 Apr 2019 13:16:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727022AbfDHRXl (ORCPT + 99 others); Mon, 8 Apr 2019 13:23:41 -0400 Received: from mga02.intel.com ([134.134.136.20]:15103 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726105AbfDHRXl (ORCPT ); Mon, 8 Apr 2019 13:23:41 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 10:23:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,326,1549958400"; d="scan'208";a="141056435" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga007.fm.intel.com with ESMTP; 08 Apr 2019 10:23:38 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hDXzd-0001sX-9T; Mon, 08 Apr 2019 20:23:37 +0300 Date: Mon, 8 Apr 2019 20:23:37 +0300 From: Andy Shevchenko To: Chris Chiu Cc: mika.westerberg@linux.intel.com, heikki.krogerus@linux.intel.com, drake@endlessm.com, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux@endlessm.com Subject: Re: [PATCH v2] pinctrl:intel: Retain HOSTSW_OWN for requested gpio pin Message-ID: <20190408172337.GY9224@smile.fi.intel.com> References: <20190408095127.6197-1-chiu@endlessm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190408095127.6197-1-chiu@endlessm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 08, 2019 at 05:51:27PM +0800, Chris Chiu wrote: > The touchpad of the ASUS laptops E403NA, X540NA, X541NA are not > responsive after suspend/resume. The following error message > shows after resume. > i2c_hid i2c-ELAN1200:00: failed to reset device. > > On these laptops, the touchpad interrupt is connected via a GPIO > pin which is controlled by Intel pinctrl. After system resumes, > the GPIO is in ACPI mode and no longer works as an IRQ. > > This commit saves the HOSTSW_OWN value during suspend, make sure > the HOSTSW_OWN mode remains the same after resume. Some comments as per v1 are still applicable to this version. -- With Best Regards, Andy Shevchenko