Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 8 Apr 2019 11:19:39 -0700
From:   Benson Leung <bleung@google.com>
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     lee.jones@linaro.org, gwendal@chromium.org, bleung@chromium.org,
        linux-kernel@vger.kernel.org, groeck@chromium.org,
        kernel@collabora.com, dtor@chromium.org,
        rushikesh.s.kadam@intel.com, Wei-Ning Huang <wnhuang@google.com>
Subject: Re: [PATCH v3 4/4] mfd: cros_ec: instantiate properly CrOS Touchpad
 MCU device
Message-ID: <20190408181939.GB18975@google.com>
References: <20190408094141.27858-1-enric.balletbo@collabora.com>
 <20190408094141.27858-5-enric.balletbo@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="oC1+HKm2/end4ao3"
Content-Disposition: inline
In-Reply-To: <20190408094141.27858-5-enric.balletbo@collabora.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--oC1+HKm2/end4ao3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Enric,

On Mon, Apr 08, 2019 at 11:41:41AM +0200, Enric Balletbo i Serra wrote:
> Support Touchpad MCU as a special of CrOS EC devices. The current
> Touchpad MCU is used on Eve Chromebook and used the same protocol as
> other CrOS EC devices.
>=20
> When a MCU has touchpad support (aka EC_FEATURE_TOUCHPAD), it is
> instantiated as a special CrOS EC device with device name 'cros_tp'. So
> regardless of the probing order between the actual cros_ec and cros_tp,
> the userspace and other kernel drivers should not confuse them.
>=20
> Signed-off-by: Wei-Ning Huang <wnhuang@google.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Reviewed-by: Benson Leung <bleung@chromium.org>

> ---
>=20
> Changes in v3: None
> Changes in v2: None
>=20
>  drivers/mfd/cros_ec_dev.c   | 10 ++++++++++
>  include/linux/mfd/cros_ec.h |  1 +
>  2 files changed, 11 insertions(+)
>=20
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index 79746e817cdb..be827910e9d0 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -659,6 +659,16 @@ static int ec_device_probe(struct platform_device *p=
dev)
>  		ec_platform->ec_name =3D CROS_EC_DEV_ISH_NAME;
>  	}
> =20
> +	/* Check whether this is actually a Touchpad MCU rather than an EC */
> +	if (cros_ec_check_features(ec, EC_FEATURE_TOUCHPAD)) {
> +		dev_info(dev, "CrOS Touchpad MCU detected.\n");
> +		/*
> +		 * Help userspace differentiating ECs from TP MCU,
> +		 * regardless of the probing order.
> +		 */
> +		ec_platform->ec_name =3D CROS_EC_DEV_TP_NAME;
> +	}
> +
>  	/*
>  	 * Add the class device
>  	 * Link to the character device for creating the /dev entry
> diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h
> index b393bd4e4b73..981381fbb3fd 100644
> --- a/include/linux/mfd/cros_ec.h
> +++ b/include/linux/mfd/cros_ec.h
> @@ -26,6 +26,7 @@
>  #define CROS_EC_DEV_FP_NAME	"cros_fp"
>  #define CROS_EC_DEV_ISH_NAME	"cros_ish"
>  #define CROS_EC_DEV_PD_NAME	"cros_pd"
> +#define CROS_EC_DEV_TP_NAME	"cros_tp"
> =20
>  /*
>   * The EC is unresponsive for a time after a reboot command.  Add a
> --=20
> 2.20.1
>=20

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--oC1+HKm2/end4ao3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE6gYDF28Li+nEiKLaHwn1ewov5lgFAlyrkLsACgkQHwn1ewov
5ljdvhAAlj5zGvWQQ9/pM5i/g4G+3auz6or5wmQIlVQMen3My7Fzfi8lCvJ1WSkI
33sfQnz5JZFVxYjJzQsggy8PwP1pgA4HLvrX4fw3DVmaNN0Hy5y5LnOGGZkhHEgT
FtUe+dOND4NPYnAti4Di6LlCU+ibDgKEy+1jO9vsobGIGrZkLqv8xDI9tVuG0xSs
5EmWYWDm5XGdZFg1OKwYA0DxtmMMsnkO5IAmYVxLHfr92uLN4epHRaooJCfG3Qu+
koyOQToKBz2R7SdbdE3CXcwWMuVyLbIXiw09dtslH1Qhc6BILjOBWtWexXwsm1pc
Vq0JhNR5C9/cg5qFGFh2nT6YJBZ96aLJJrpwayD+GMiazQPCPngb4JN9zMzGPvII
yrnJLU1tePXlvv6AU5YbDEzjY8OA47+L9jpZJbo3RX1naxq8XNYb7J1w/iQb1w1F
NLUN+4mMA8Wl4lsG+yCOvBmO8f7qTp1ZQy56uXHQREGgTHveDRz4rRKDbRp9TD4m
YceJxje3SLmtRpF82pKbfJ0MvFLkT8M5OW+sBYs5rIE3RG3g3w2QEBnPuYYmLDR/
zIiZFcNiYTcVM44ySOpBoqFTeD+ZOSXMh8KtW0aXb5zmp6qrL0V285mE02DBYFr3
hf4MnOJ+f94Yg3iobxHMd5WNnnU6S0Lo9OvSsLL/ZLhGDxGJ/WA=
=uevW
-----END PGP SIGNATURE-----

--oC1+HKm2/end4ao3--