Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 8 Apr 2019 21:19:41 +0200 (CEST)
From:   Julia Lawall <julia.lawall@lip6.fr>
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>
cc:     yamada.masahiro@socionext.com, Julia Lawall <Julia.Lawall@lip6.fr>,
        Gilles Muller <Gilles.Muller@lip6.fr>, nicolas.palix@imag.fr,
        michal.lkml@markovi.net, cocci@systeme.lip6.fr,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Coccinelle: kstrdup: Fix typo in warning messages
In-Reply-To: <20190408191432.1269-1-rikard.falkeborn@gmail.com>
Message-ID: <alpine.DEB.2.21.1904082119190.2612@hadrien>
References: <20190408191432.1269-1-rikard.falkeborn@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Mon, 8 Apr 2019, Rikard Falkeborn wrote:

> Replace 'kstrdep' with 'kstrdup' in warning messages.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Acked-by: Julia.Lawall@lip6.fr

Thanks for the patch!

julia

> ---
>  scripts/coccinelle/api/kstrdup.cocci | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/coccinelle/api/kstrdup.cocci b/scripts/coccinelle/api/kstrdup.cocci
> index 09cba54ed0cf..6d13d54a6ee6 100644
> --- a/scripts/coccinelle/api/kstrdup.cocci
> +++ b/scripts/coccinelle/api/kstrdup.cocci
> @@ -76,7 +76,7 @@ p1 << r1.p1;
>  p2 << r1.p2;
>  @@
>
> -cocci.print_main("WARNING opportunity for kstrdep",p1)
> +cocci.print_main("WARNING opportunity for kstrdup",p1)
>  cocci.print_secs("strcpy",p2)
>
>  @script:python depends on org@
> @@ -84,7 +84,7 @@ p1 << r2.p1;
>  p2 << r2.p2;
>  @@
>
> -cocci.print_main("WARNING opportunity for kstrdep",p1)
> +cocci.print_main("WARNING opportunity for kstrdup",p1)
>  cocci.print_secs("memcpy",p2)
>
>  @script:python depends on report@
> @@ -92,7 +92,7 @@ p1 << r1.p1;
>  p2 << r1.p2;
>  @@
>
> -msg = "WARNING opportunity for kstrdep (strcpy on line %s)" % (p2[0].line)
> +msg = "WARNING opportunity for kstrdup (strcpy on line %s)" % (p2[0].line)
>  coccilib.report.print_report(p1[0], msg)
>
>  @script:python depends on report@
> @@ -100,5 +100,5 @@ p1 << r2.p1;
>  p2 << r2.p2;
>  @@
>
> -msg = "WARNING opportunity for kstrdep (memcpy on line %s)" % (p2[0].line)
> +msg = "WARNING opportunity for kstrdup (memcpy on line %s)" % (p2[0].line)
>  coccilib.report.print_report(p1[0], msg)
> --
> 2.21.0
>
>