Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3246438yba; Mon, 8 Apr 2019 14:28:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqz0wysA7Mbh/gegZb8gaTlrxbVTDdFvaGy0XmlKxrgEl0Ck0kXTP5NvBTit+Yqv0QX4OK6D X-Received: by 2002:a62:ed10:: with SMTP id u16mr32727097pfh.187.1554758909305; Mon, 08 Apr 2019 14:28:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554758909; cv=none; d=google.com; s=arc-20160816; b=Gpd/lSbaWYd+0c+1avHgchKiaZ2XA3Q3+y+pdrIqiE1wkshuFUMUU43UTyE+n0HQ6q BwFYkPb4CeM3eOe55aI/RbKSiVlAYBasvORvrHxHWdfruy6Mr/HqgVB/nalzay3Ia+J6 L9fY2QxKzgd4NfElNQREVarrR0Rbnd2RhjpB7/QdYWQ2FSeb09OfAlWyBc0byIxYf1Mm 5m5M90LilNNZVewQj5xR0w6+9T3HXSqKWEQmhbM8/26+u3MImP+0NhR6PtGm50JHQefv w6IvT/5kcVcJtYTzaAi2tb5A+2ku3ivJ/vhZkaYcP+CHv8oqmjbwQEORn0Sqac+B5Awk w2sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ycIQITlSumPWyCFM1zn1jGQmyBfIItmWvD+dLc/wBek=; b=suQm9XSV/XC7YiVIi1wnuLGTk9BoH/EblgjYvS0eOYi0y0pX5iuqTB0SpDGvndoINb tbnzlgLf558VGCha7+1t8PDGbSC0gY4fbrOIpk/HFVRGAP0UVjKtqIJ1hlA0q99pLOXm rindVxXAm7/KhN7dZ2P/9+/XAIIQiJVx6cjui4ZHjSWj3j5SzIqtqgcRXmtAasNqiEjS sa5vHriTZtIANgPsuHc8f/BSqMAb7g42+7+6579vj8pkKC4p1No2qKoLakyt//qPJdah Gyqcc6njVxjWIsOeBRNM8L8uj7K2Kof8zoS/INolGIpLP4fp+AOAmv6U5xhy1uiES2BL UvIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j62si12480501pgd.87.2019.04.08.14.28.13; Mon, 08 Apr 2019 14:28:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728554AbfDHU1A (ORCPT + 99 others); Mon, 8 Apr 2019 16:27:00 -0400 Received: from mga11.intel.com ([192.55.52.93]:18868 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726509AbfDHU1A (ORCPT ); Mon, 8 Apr 2019 16:27:00 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 13:26:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,326,1549958400"; d="scan'208";a="162516490" Received: from agluck-desk.sc.intel.com (HELO agluck-desk) ([10.3.52.160]) by fmsmga001.fm.intel.com with ESMTP; 08 Apr 2019 13:27:00 -0700 Date: Mon, 8 Apr 2019 13:26:59 -0700 From: "Luck, Tony" To: "Ghannam, Yazen" Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bp@suse.de" , "x86@kernel.org" Subject: Re: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu Message-ID: <20190408202659.GA5232@agluck-desk> References: <20190408141205.12376-1-Yazen.Ghannam@amd.com> <20190408141205.12376-5-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190408141205.12376-5-Yazen.Ghannam@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 08, 2019 at 02:12:17PM +0000, Ghannam, Yazen wrote: > +DEFINE_PER_CPU_READ_MOSTLY(u8, num_banks); > +EXPORT_PER_CPU_SYMBOL_GPL(num_banks); The name "num_banks" is a bit generic for an exported symbol. I think it should have a "mce_" prefix. -Tony