Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     shuah <shuah@kernel.org>
CC:     Roman Gushchin <guroan@gmail.com>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>
Subject: Re: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in
 test_memcg_subtree_control()
Thread-Topic: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in
 test_memcg_subtree_control()
Thread-Index: AQHU5RH8Mm7Zp+AxqUmB3GSIVhQzuaYyrp2AgAAwSwA=
Date:   Mon, 8 Apr 2019 21:46:33 +0000
Message-ID: <20190408214628.GA14748@castle>
References: <20190328025659.25684-1-guro@fb.com>
 <32b7ae48-99dd-1261-4086-37d416ffcfd5@kernel.org>
In-Reply-To: <32b7ae48-99dd-1261-4086-37d416ffcfd5@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::3:27ff]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 649355b7-6e40-4481-bcc5-08d6bc6bab02
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:BYAPR15MB2598;
x-ms-traffictypediagnostic: BYAPR15MB2598:
x-microsoft-antispam-prvs: <BYAPR15MB2598D6725F60C27981616770BE2C0@BYAPR15MB2598.namprd15.prod.outlook.com>
x-forefront-prvs: 0001227049
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(136003)(39860400002)(376002)(366004)(396003)(346002)(199004)(189003)(2906002)(446003)(99286004)(76176011)(316002)(54906003)(52116002)(486006)(11346002)(86362001)(6116002)(476003)(1076003)(97736004)(71190400001)(68736007)(229853002)(6916009)(71200400001)(6486002)(4326008)(33656002)(5660300002)(14454004)(6246003)(106356001)(305945005)(478600001)(25786009)(105586002)(6436002)(14444005)(9686003)(186003)(6512007)(6506007)(102836004)(53546011)(386003)(4744005)(46003)(53936002)(81166006)(81156014)(8936002)(7736002)(8676002)(256004)(33716001);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR15MB2598;H:BYAPR15MB2631.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: zFDZ8UOLcQOigL21A7lWex4V5M93PZXcbq2O6ajQauJEiiwW6AfOEzPFzSWtNxQfDl4o/2eal1WnA3nC2dlpwta+T9WYJtzNvHcM94xLg/RNSvtEPHoGwo9Y4uIQ6xj0aKhDMnCJjUxd7eMzTxy1b4xheVmBpVlPL4HQr6luvKOAwgCNKY3MdeO4juLld1ewrInjwEfsncxHlo4+0eA062gaNIxgyscAF9MyvP42lY707OHm0t2dDg8XEZvw1Sc3SgUmsTTAGc44GymwH7Kn558ggJj7W0xpbI/UA0+MkR0s5fsQ/aWJ1afivxfbnKhg+6Lthzafviqg6N6n6Kp7uxJ5qn5LKxOPdDnbX7T7vpnQRfTSgdmquUqxOW0OtXlbYgLfZsYomltr6RZ7w1/tq3OZpQKv2o6mDq1Ag21nyh8=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3F957FB9A8FD034AA545765FF2DCF63D@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 649355b7-6e40-4481-bcc5-08d6bc6bab02
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2019 21:46:33.9012
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2598
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-08_09:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 08, 2019 at 12:53:39PM -0600, shuah wrote:
> On 3/27/19 8:56 PM, Roman Gushchin wrote:
> > Dan reported, that cleanup path in test_memcg_subtree_control()
> > triggers a static checker warning:
> >    ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \
> >    test_memcg_subtree_control()
> >    error: uninitialized symbol 'child2'.
> >=20
> > Fix this by initializing child2 and parent2 variables and
> > split the cleanup path into few stages.
> >=20
> > Signed-off-by: Roman Gushchin <guro@fb.com>
> > Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tes=
ts")
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Cc: Dan Carpenter <dan.carpenter@oracle.com>
> > Cc: Shuah Khan (Samsung OSG) <shuah@kernel.org>
> > Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
>=20
>=20
> From and Signed-off don't match. Please fix it and resend the patch.

Done.

Thank you!

Roman