Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261252AbUDABvV (ORCPT ); Wed, 31 Mar 2004 20:51:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261787AbUDABvV (ORCPT ); Wed, 31 Mar 2004 20:51:21 -0500 Received: from fw.osdl.org ([65.172.181.6]:2966 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261252AbUDABvU (ORCPT ); Wed, 31 Mar 2004 20:51:20 -0500 Date: Wed, 31 Mar 2004 17:51:13 -0800 From: Andrew Morton To: Andrea Arcangeli Cc: hugh@veritas.com, vrajesh@umich.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix Message-Id: <20040331175113.27fd1d0e.akpm@osdl.org> In-Reply-To: <20040401012625.GV2143@dualathlon.random> References: <20040331150718.GC2143@dualathlon.random> <20040331172851.GJ2143@dualathlon.random> <20040401004528.GU2143@dualathlon.random> <20040331172216.4df40fb3.akpm@osdl.org> <20040401012625.GV2143@dualathlon.random> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 21 Andrea Arcangeli wrote: > > > Doing a __GFP_FS allocation while holding lock_page() is worrisome. It's > > OK if that page is private, but how do we know that the caller didn't pass > > us some page which is on the LRU? > > it _has_ to be private if it's using rw_swap_page_sync. How can a page > be in a lru if we're going to execute add_to_page_cache on it? That > would be pretty broken in the first place. An anonymous user page meets these requirements. A did say "anal", but rw_swap_page_sync() is a general-purpose library function and we shouldn't be making assumptions about the type of page which the caller happens to be feeding us. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/