Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3583260yba; Mon, 8 Apr 2019 23:55:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqz1BaLRiNc47HnCehZ+OiBCzJJX+SRF6fnq4AhQmVqKcqzBfhLTQNc/ZKA2AxrupKK3Wr2y X-Received: by 2002:a17:902:5ac4:: with SMTP id g4mr33553133plm.261.1554792956822; Mon, 08 Apr 2019 23:55:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554792956; cv=none; d=google.com; s=arc-20160816; b=yeY1nGnMHOP7KWl1jBtIu6ashix/DPFUmQIBowl341ZDeONGGMXyWnCqAvWqQuyoiT uErguW4PiEqYynSxyMes1kXCwkgGAOOS9Xlkps/wwoqxVzCazoV2OTRXNOE+DiDnpuX7 SO9o6l5ZOs1Xot30UAoiKiRsFKHDIuytfyxW0ic4+808RNBsW8tUMrY9+Axl9bXux69/ 3mKqMDnsM3qjfgskiG7C2uXqu/D8N1uYfs3Y+xCqe6OPyHKvsMHvXwO+XUQZild6+7dp rtjjJP6bhani5IHDsMKIaRJSUiGqeaeF5Eq7Drk25jGhRjYW1IlEic9N+nkARVORFjU4 H6JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=Aumc4dh3DYHBhbKUwDy00SELwXO9w0iYWCe4gsxdwVI=; b=IuyjPoIVLMUd8Lt/efnq9SnvNf2KY86cqJtTD7EeSBe7ZM2o7ylEAKZY0+0mIaSADM KyOXnVcGIlwQCmeDmW9DyzesxrhwEA4MjKEoZtxvCT5IScHjT5RsoChesBDBM3Sysh+z EEurT4SyMnKVS5taRGlGt0cgZKufLpzXTQoeaA25YYtbPZwH4DE6Qteoxs5gB7dD7dAY TRhr7sXULLOuFRv0LSL5VJff0/9aYSJ3kRaWv4OuvcxlVCU1iPx6XjeXfC0U3RAzvO3t dvhSUollffrQVVxX1SDAR57kt5I+55X36zCrTYEyWViYUxip+Ujaj6z3Tb98sVey8RZr YG/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4si15698251pgc.304.2019.04.08.23.55.41; Mon, 08 Apr 2019 23:55:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbfDIGxq (ORCPT + 99 others); Tue, 9 Apr 2019 02:53:46 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:8999 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726205AbfDIGxo (ORCPT ); Tue, 9 Apr 2019 02:53:44 -0400 X-UUID: 7b988eebbf0943bc9aa864fc316494e8-20190409 X-UUID: 7b988eebbf0943bc9aa864fc316494e8-20190409 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1791833000; Tue, 09 Apr 2019 14:53:29 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS33N2.mediatek.inc (172.27.4.76) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 9 Apr 2019 14:53:27 +0800 Received: from mszsdclx1067.gcn.mediatek.inc (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 9 Apr 2019 14:53:26 +0800 From: wangyan wang To: Michael Turquette , Stephen Boyd , CK Hu CC: wangyan wang , Matthias Brugger , Philipp Zabel , David Airlie , Daniel Vetter , chunhui dai , Colin Ian King , Sean Wang , Ryder Lee , , , , , , Subject: [PATCH V10 5/5] drm/mediatek: no change parent rate in round_rate() for mt2701 hdmi phy Date: Tue, 9 Apr 2019 14:53:07 +0800 Message-ID: <20190409065307.82280-6-wangyan.wang@mediatek.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20190409065307.82280-1-wangyan.wang@mediatek.com> References: <20190409065307.82280-1-wangyan.wang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wangyan Wang This is the third step to make MT2701 HDMI stable. We should not change the rate of parent for hdmi phy when doing round_rate for this clock. The parent clock of hdmi phy must be the same as it. We change it when doing set_rate only. Signed-off-by: Wangyan Wang --- drivers/gpu/drm/mediatek/mtk_hdmi_phy.c | 14 -------------- drivers/gpu/drm/mediatek/mtk_hdmi_phy.h | 2 -- drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c | 6 ++++++ drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c | 14 ++++++++++++++ 4 files changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c index 9e153e080739..e3a6b50e0cf2 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c @@ -15,20 +15,6 @@ static const struct phy_ops mtk_hdmi_phy_dev_ops = { .owner = THIS_MODULE, }; -long mtk_hdmi_pll_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) -{ - struct mtk_hdmi_phy *hdmi_phy = to_mtk_hdmi_phy(hw); - - hdmi_phy->pll_rate = rate; - if (rate <= 74250000) - *parent_rate = rate; - else - *parent_rate = rate / 2; - - return rate; -} - void mtk_hdmi_phy_clear_bits(struct mtk_hdmi_phy *hdmi_phy, u32 offset, u32 bits) { diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h index d28b8d5ed2b4..2d8b3182470d 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h @@ -49,8 +49,6 @@ void mtk_hdmi_phy_set_bits(struct mtk_hdmi_phy *hdmi_phy, u32 offset, void mtk_hdmi_phy_mask(struct mtk_hdmi_phy *hdmi_phy, u32 offset, u32 val, u32 mask); struct mtk_hdmi_phy *to_mtk_hdmi_phy(struct clk_hw *hw); -long mtk_hdmi_pll_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate); extern struct platform_driver mtk_hdmi_phy_driver; extern struct mtk_hdmi_phy_conf mtk_hdmi_phy_8173_conf; diff --git a/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c index b24ea6651db4..e3f05ad89b1e 100644 --- a/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c +++ b/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c @@ -106,6 +106,12 @@ static void mtk_hdmi_pll_unprepare(struct clk_hw *hw) usleep_range(80, 100); } +static long mtk_hdmi_pll_round_rate(struct clk_hw *hw, unsigned long rate, + unsigned long *parent_rate) +{ + return rate; +} + static int mtk_hdmi_pll_set_rate(struct clk_hw *hw, unsigned long rate, unsigned long parent_rate) { diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c index 625739b4e938..78c638c29102 100644 --- a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c +++ b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c @@ -199,6 +199,20 @@ static void mtk_hdmi_pll_unprepare(struct clk_hw *hw) usleep_range(100, 150); } +long mtk_hdmi_pll_round_rate(struct clk_hw *hw, unsigned long rate, + unsigned long *parent_rate) +{ + struct mtk_hdmi_phy *hdmi_phy = to_mtk_hdmi_phy(hw); + + hdmi_phy->pll_rate = rate; + if (rate <= 74250000) + *parent_rate = rate; + else + *parent_rate = rate / 2; + + return rate; +} + static int mtk_hdmi_pll_set_rate(struct clk_hw *hw, unsigned long rate, unsigned long parent_rate) { -- 2.14.1