Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3605894yba; Tue, 9 Apr 2019 00:30:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTXqS+Sc0tVRH0zkkbYwy7orqYlP5HyHLx9uiKoaSSIqk1R3QpoxCd04YB1s8YRtkQDhCb X-Received: by 2002:a63:84c7:: with SMTP id k190mr32479837pgd.255.1554795049439; Tue, 09 Apr 2019 00:30:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554795049; cv=none; d=google.com; s=arc-20160816; b=gQEsanVzKScXRXv/pW90oXpwxy/aA6aUWdob6iJCi7zXNK39kIep5yz8z4MAhvpCah 2Vb1UzyA6XA//3UuyX/Y48hjYWkrVc11wum9r2gBLKrtm0eOivj6YedtdrxABMIAr2Nl w3j1mnxWY3YbuRnD10TaofSc3/mo3Iy1fgPP4NLu3VKz0aHBhrYH2XzuyHgVSZu+V6VU wOwQWyTfz1ZgNS9MGd2qGMeffQZrR5QHcdcK+Ct6SzU4XcoBj8YCBvZSEt/Pp2cMSRs0 uub3iHB+59HPIQ3RWVXmiTjvrCSREIu7y1EqF1PKMLc2XkorjMHc4OJQA2YJGAzLDnFK C8tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=gzF7Kwpjo/odsGXsRLycHu1OlgxEHuewJ7vQDHZrmXM=; b=DvFQp0My+FRujRcMmt0YIEupvmKnZiwyogE/vAYAQw+D58zJ/UilTdQQ1sb+P+sagF 6pUJlhPn2orIYorJd9gFGRbO62kcMS9uOxUGGb/Xv5SwIsLFCcml8C9PLQG45GFNnkca O8iuBLLzkkZIfXwBUymIilQxbRuQrHF4ZuXBl3U4wNzZYUNwzG5WK7Fblu96CeKPNfYf 3d1RghAwcKkH+YNsNy0CHKhTWKC3dRiJleqWj5ctrdtDOF6A9i6T+G+raV1FxvY86y+l TTmCfQuyTz5MWFaPqKQJxIeK4yVsDC2wvXRwWVSIw26dLa1MT1NP+O983eWnTkmxY67c eNnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j35si29439046plb.61.2019.04.09.00.30.33; Tue, 09 Apr 2019 00:30:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726720AbfDIH2m (ORCPT + 99 others); Tue, 9 Apr 2019 03:28:42 -0400 Received: from mga17.intel.com ([192.55.52.151]:4987 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726205AbfDIH2m (ORCPT ); Tue, 9 Apr 2019 03:28:42 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 00:28:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,328,1549958400"; d="scan'208";a="289953460" Received: from lyang61-mobl3.ccr.corp.intel.com ([10.255.30.213]) by orsmga004.jf.intel.com with ESMTP; 09 Apr 2019 00:28:32 -0700 Message-ID: <1554794910.2178.6.camel@intel.com> Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding From: Zhang Rui To: Anson Huang , Rob Herring , "edubezval@gmail.com" Cc: "mark.rutland@arm.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "daniel.lezcano@linaro.org" , Aisheng Dong , "ulf.hansson@linaro.org" , "sboyd@kernel.org" , Daniel Baluta , Andy Gross , "horms+renesas@verge.net.au" , "heiko@sntech.de" , "arnd@arndb.de" , "maxime.ripard@bootlin.com" , "bjorn.andersson@linaro.org" , "jagan@amarulasolutions.com" , "enric.balletbo@collabora.com" , "marc.w.gonzalez@free.fr" , "olof@lixom.net" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-pm@vger.kernel.org" , dl-linux-imx Date: Tue, 09 Apr 2019 15:28:30 +0800 In-Reply-To: References: <1551256894-21954-1-git-send-email-Anson.Huang@nxp.com> <20190227235455.GA15211@bogus> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 二, 2019-04-09 at 05:28 +0000, Anson Huang wrote: > Ping... > Can anyone provide some suggestion about how to proceed next? > Hi, Eduardo, I guess you will comment on this patch, right? Or else I will take the patch following Rob' suggestion. thanks, rui > Best Regards! > Anson Huang > > > > > -----Original Message----- > > From: Anson Huang > > Sent: 2019年3月26日 10:45 > > To: 'Rob Herring' ; 'edubezval@gmail.com' > > > > Cc: 'mark.rutland@arm.com' ; > > 'shawnguo@kernel.org' ; 's.hauer@pengutronix.d > > e' > > ; 'kernel@pengutronix.de' > > ; 'festevam@gmail.com' ; > > 'catalin.marinas@arm.com' ; > > 'will.deacon@arm.com' ; 'rui.zhang@intel.com' > > ; 'edubezval@gmail.com' ; > > 'daniel.lezcano@linaro.org' ; Aisheng > > Dong > > ; 'ulf.hansson@linaro.org' > > ; 'sboyd@kernel.org' ; > > Daniel > > Baluta ; Andy Gross ; > > 'horms+renesas@verge.net.au' ; > > 'heiko@sntech.de' ; 'arnd@arndb.de' > >; > > 'maxime.ripard@bootlin.com' ; > > 'bjorn.andersson@linaro.org' ; > > 'jagan@amarulasolutions.com' ; > > 'enric.balletbo@collabora.com' ; > > 'marc.w.gonzalez@free.fr' ; 'olof@lixom.ne > > t' > > ; 'devicetree@vger.kernel.org' > > ; 'linux-kernel@vger.kernel.org' > > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > > kernel@lists.infradead.org>; 'linux-pm@vger.kernel.org' > pm@vger.kernel.org>; dl-linux-imx > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > binding > > > > Ping... > > > > Hi, Eduardo > > What is your opinion about where to put the HW resource ID in > > DT? > > > > Best Regards! > > Anson Huang > > > > > > > > -----Original Message----- > > > From: Anson Huang > > > Sent: 2019年3月13日 16:12 > > > To: 'Rob Herring' ; 'edubezval@gmail.com' > > > > > > Cc: 'mark.rutland@arm.com' ; > > > 'shawnguo@kernel.org' ; > > 's.hauer@pengutronix.de' > > > > > > ; 'kernel@pengutronix.de' > > > ; 'festevam@gmail.com' > > >; > > > 'catalin.marinas@arm.com' ; > > > 'will.deacon@arm.com' ; 'rui.zhang@intel.com > > > ' > > > ; 'edubezval@gmail.com' > > >; > > > 'daniel.lezcano@linaro.org' ; Aisheng > > > Dong > > > ; 'ulf.hansson@linaro.org' > > > ; 'sboyd@kernel.org' ; > > > Daniel Baluta ; Andy Gross > > > ; 'horms+renesas@verge.net.au' > > > ; 'heiko@sntech.de' > > > ; > > > 'arnd@arndb.de' ; 'maxime.ripard@bootlin.com' > > > ; 'bjorn.andersson@linaro.org' > > > ; 'jagan@amarulasolutions.com' > > > ; 'enric.balletbo@collabora.com' > > > ; 'marc.w.gonzalez@free.fr' > > ; 'olof@lixom.net' > > > > > > ; 'devicetree@vger.kernel.org' > > > ; 'linux-kernel@vger.kernel.org' > > > > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > > ; 'linux-pm@vger.kernel.or > > > g' > > > ; dl-linux-imx > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > binding > > > > > > Ping... > > > Hi, Eduardo > > > Can you take a look at this thread? Thanks. > > > > > > > > > Best Regards! > > > Anson Huang > > > > > > > > > > > -----Original Message----- > > > > From: Anson Huang > > > > Sent: 2019年3月6日 13:27 > > > > To: 'Rob Herring' ; 'edubezval@gmail.com' > > > > > > > > Cc: 'mark.rutland@arm.com' ; > > > > 'shawnguo@kernel.org' ; > > > 's.hauer@pengutronix.de' > > > > > > > > ; 'kernel@pengutronix.de' > > > > ; 'festevam@gmail.com' > > ; > > > > > > > > > > > 'catalin.marinas@arm.com' ; > > > > 'will.deacon@arm.com' ; 'rui.zhang@intel.c > > > > om' > > > > ; 'edubezval@gmail.com' > > ; > > > > > > > > > > > 'daniel.lezcano@linaro.org' ; > > > > Aisheng > > > > Dong ; 'ulf.hansson@linaro.org' > > > > ; 'sboyd@kernel.org' > > > > ; > > > > Daniel Baluta ; Andy Gross > > > > ; 'horms+renesas@verge.net.au' > > > > ; 'heiko@sntech.de' > > > e>; > > > > 'arnd@arndb.de' ; 'maxime.ripard@bootlin.com' > > > > ; 'bjorn.andersson@linaro.org' > > > > ; 'jagan@amarulasolutions.com' > > > > ; 'enric.balletbo@collabora.com' > > > > ; 'marc.w.gonzalez@free.fr' > > > ; 'olof@lixom.net' > > > > > > > > ; 'devicetree@vger.kernel.org' > > > > ; 'linux-kernel@vger.kernel.org' > > > > > > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > > > ; 'linux-pm@vger.kernel. > > > > org' > > > > ; dl-linux-imx > > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > > binding > > > > > > > > Ping... > > > > > > > > Hi, Eduardo > > > > Looks like we are going around in circle, can we make > > > > decision of > > > > which direction to go? > > > > > > > > Best Regards! > > > > Anson Huang > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Anson Huang > > > > > Sent: 2019年3月1日 9:41 > > > > > To: 'Rob Herring' ; edubezval@gmail.com > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > s.hauer@pengutronix.de; > > > > > > > > > > kernel@pengutronix.de; festevam@gmail.com; > > > catalin.marinas@arm.com; > > > > > > > > > > > > > > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.com > > > > > ; > > > > > daniel.lezcano@linaro.org; Aisheng Dong > > > > >; > > > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > > > > ; Andy Gross ; > > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > > linux-arm-kernel@lists.infradead.org; > > > > > linux- pm@vger.kernel.org; dl-linux-imx > > > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > thermal > > > > > binding > > > > > > > > > > Hi, Rob/Eduardo > > > > > > > > > > Best Regards! > > > > > Anson Huang > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > > > Sent: 2019年2月28日 22:49 > > > > > > To: Anson Huang > > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > > s.hauer@pengutronix.de; > > > > > > > > > > > > kernel@pengutronix.de; festevam@gmail.com; > > > > catalin.marinas@arm.com; > > > > > > > > > > > > > > > > > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.c > > > > > > om; > > > > > > daniel.lezcano@linaro.org; Aisheng Dong > > > > > om>; > > > > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > > > > > ; Andy Gross > > > > > > ; > > > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > > > linux-arm-kernel@lists.infradead.org; > > > > > > linux- pm@vger.kernel.org; dl-linux-imx > > > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > > thermal > > > > > > binding > > > > > > > > > > > > On Wed, Feb 27, 2019 at 6:48 PM Anson Huang > > > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Hi, Rob > > > > > > > > > > > > > > Best Regards! > > > > > > > Anson Huang > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > > > > > Sent: 2019年2月28日 7:55 > > > > > > > > To: Anson Huang > > > > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > > > > > s.hauer@pengutronix.de; kernel@pengutronix.de; > > > > > festevam@gmail.com; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > catalin.marinas@arm.com; will.deacon@arm.com; > > > > > rui.zhang@intel.com; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > edubezval@gmail.com; daniel.lezcano@linaro.org; Aisheng > > > > > > > > Dong > > > > > > > > ; ulf.hansson@linaro.org; > > > > > > > > sboyd@kernel.org; Daniel Baluta > > > > > > > > ; > > > > > > > > Andy Gross ; > > > > > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb > > > > > > > > .de; > > > > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.co > > > > > > > > m; > > > > > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.or > > > > > > > > g; > > > > > > > > linux-arm-kernel@lists.infradead.org; > > > > > > > > linux- pm@vger.kernel.org; dl-linux-imx > > > > > > > com> > > > > > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > > > > thermal binding > > > > > > > > > > > > > > > > On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core > > > > > > > > > inside > > > > > > > > > as system controller, the system controller is in > > > > > > > > > charge > > > > > > > > > of system power, clock and thermal sensors etc. > > > > > > > > > management, Linux kernel has to communicate with > > > > > > > > > system > > > > > > > > > controller via MU (message unit) IPC to get > > > > > > > > > temperature > > > > > > > > > from thermal sensors, this patch adds binding doc for > > > > > > > > > i.MX > > > > > > > > > system controller thermal > > > > driver. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Anson Huang > > > > > > > > > --- > > > > > > > > > Changes since V9: > > > > > > > > >     - change #thermal-sensor-cells value in example > > > > > > > > > to 1, > > > > > > > > > since there are > > > > > > > > other > > > > > > > > > > > > > > > > > >       thermal sensors inside system controller, it is > > > > > > > > > just > > > > > > > > > because there are > > > > > > > > still > > > > > > > > > > > > > > > > > >       some issue, so system controller does NOT > > > > > > > > > expose > > > > > > > > > them for now, > > > > > > > > they could > > > > > > > > > > > > > > > > > >       be exposed later, so it should be 1 from HW > > > > > > > > > perspective. > > > > > > > > > --- > > > > > > > > >  .../devicetree/bindings/arm/freescale/fsl,scu.txt    > > > > > > > > > | 21 > > > > > > > > +++++++++++++++++++++ > > > > > > > > > > > > > > > > > >  1 file changed, 21 insertions(+) > > > > > > > > > > > > > > > > > > diff --git > > > > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl > > > > > > > > > ,scu. > > > > > > > > > tx > > > > > > > > > t > > > > > > > > > b/Documentation/devicetree/bindings/arm/freescale/fsl > > > > > > > > > ,scu. > > > > > > > > > tx t index 72d481c..855270b 100644 > > > > > > > > > --- > > > > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl > > > > > > > > > ,scu. > > > > > > > > > tx > > > > > > > > > t > > > > > > > > > +++ > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > +++ tx > > > > > > > > > +++ t > > > > > > > > > @@ -122,6 +122,21 @@ RTC bindings based on SCU > > > > > > > > > Message > > > > > Protocol > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Required properties: > > > > > > > > >  - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > > > > > > > > > > > > > > > +Thermal bindings based on SCU Message Protocol > > > > > > > > > +-------------------------------------------------- > > > > > > > > > ------- > > > > > > > > > +-- > > > > > > > > > +- > > > > > > > > > + > > > > > > > > > +Required properties: > > > > > > > > > +- compatible:                      Should be : > > > > > > > > > +                             "fsl,imx8qxp-sc- > > > > > > > > > thermal" > > > > > > > > > +                           followed by > > > > > > > > > +"fsl,imx-sc-thermal"; > > > > > > > > > + > > > > > > > > > +- #thermal-sensor-cells:   See > > > > > > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > > > > > > > > > > > > > > > > +                           for a description. > > > > > > > > > + > > > > > > > > > +- imx,sensor-resource-id:  A single integer for > > > > > > > > > single > > > > > > > > > +thermal zone's > > > > > > > > resource ID or > > > > > > > > > > > > > > > > > > +                           an array of integers to > > > > > > > > > + specify each thermal > > > > > > > > zone's sensor > > > > > > > > > > > > > > > > > > +                           resource ID. > > > > > > > > Can't you put the resource ids in the thermal-sensor > > > > > > > > cells? > > > > > > > > Why do you need to list them here? > > > > > > > For the thermal-sensor cells, if you meant the argument > > > > > > > of > > > > > > > tsens phandle, then the reason is that argument is for > > > > > > > sensor > > > > > > > index starting from 0, previous I use it for our resource > > > > > > > ID, > > > > > > > but it looks confused, since user will think there are > > > > > > > many > > > > > > > sensors there per > > > > > Eduardo's comment. > > > > > > > > > > > > > > > > > > > > > > > > > > > +                       thermal-sensors = <&tsens 0>; > > > > > > > > > > > > > > If you meant putting it in each thermal sensor node > > > > > > > instead of > > "tsens" > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > node, then in previous patch series, I put this " > > > > > > > imx,sensor-resource-id " property in each thermal sensor > > > > > > > node, > > > > > > > but the thermal sensor nodes are parsed by common thermal > > > > > > > framework, thermal driver will need to find the thermal > > > > > > > zone > > > > > > > node and go through every child node to get the resource > > > > > > > id > > > > > > > again, so Eduardo suggested to put it in > > > > > > our platform tsens node, that makes our thermal driver code > > > > > > much > > > > > > more simple. > > > > > > > > > > > > The phandle args are meant to be an id typically. There's > > > > > > absolutely no requirement they are 0-N based. They often > > > > > > are > > > > > > because things like interrupts are 0-N or clocks have no > > > > > > h/w id. > > > > > > If you already have an id, > > > > use it. > > > > > > > > > > > > > > > > > Don't invent your own. > > > > > At the beginning, I put the HW resource ID in the "tsens" > > > > > phandle > > > > > argument of "thermal-sensors" node, see  below patch I sent > > > > > before, the benefit is I do NOT need to add new property for > > > > > passing HW resource ID to driver, the disadvantage is, I have > > > > > to > > > > > parse the thermal_zones' each child node and get the HW > > > > > resource > > > > > ID from phandle argument(searing thermal_zones node and go > > > > > through > > > > > all its child node, and get the phandle argument), they are > > > > > by > > > > > default ONLY parsed by thermal core driver. When we register > > > > > thermal zone, we have to pass the HW resource ID when calling > > > > > devm_thermal_zone_of_sensor_register(), if we add our own > > > > > property > > > > > to pass the HW resource ID, then no need to do so, we just > > > > > pass > > > > > the index 0-N for each thermal sensors in devicetree which > > > > > also > > > > > with phandle > > > > argument 0- N. So using our own property makes the driver much > > > > more > > > > simple. > > > > > > > > > > > > > > > So, @Eduardo, which direction I should go? Looks like Rob > > > > > suggests > > > > > just put the HW resource ID in the phandle argument like what > > > > > I > > > > > did at the beginning, can you advise? > > > > > > > > > > Thanks, > > > > > Anson. > > > > > > > > > > https://patchwork.kernel.org/patch/10703849/ > > > > > > > > > > > > + thermal_zones: thermal-zones { > > > > > > + cpu-thermal0 { > > > > > > + polling-delay-passive = <250>; > > > > > > + polling-delay = <2000>; > > > > > > + thermal-sensors = <&tsens 355>; > > > > > > + trips { > > > > > > + cpu_alert0: trip0 { > > > > > > + temperature = > > > > > > <107000>; > > > > > > + hysteresis = > > > > > > <2000>; > > > > > > + type = "passive"; > > > > > > + }; > > > > > > > > > > > > > > > > > > Rob