Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3698679yba; Tue, 9 Apr 2019 02:56:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqwNLF8VREsQeipUfi5wunPPFa8j8HPYRRqyZ0+WZ5WFQsVDhJmOw2WcDQvFofmfdu9OLC/m X-Received: by 2002:a17:902:32b:: with SMTP id 40mr13854585pld.204.1554803792040; Tue, 09 Apr 2019 02:56:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554803792; cv=none; d=google.com; s=arc-20160816; b=hac1DGc61Cp0M8es+clk9ZdzVS6PcC3PAsKnLRBb51qtZKLJVu1ST3o6/qW9yyHBP8 Llk1HVuvfSXD36eYkblWzi8RqMZuENDmudgSNZP0mmEQnhQZinHIFhDCbX5jupblqftg +tsZmBRBMQhozUZQBZyJDdHS8Mb+Z/V6yWOCWpMzKv/g7Lu/nnr8teu1OQKZXmH47GH7 eKVPZiaqN8EOjQTL5weBjgLDMOW2gyUEixEoCISgbsDvCGIXcl4kOZlTFRROMMtYZP3U ID9IHku/wHwTXXv0o7RVaeVN7z2WrtIcce3fBviLvBe2zLTEgdiSjkbnbcdrctVA7uuV aHoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=HvZALnD+er0Veo9i3Fn9qkFRGWrrjcB7HQfJ8QbmcyA=; b=zxN5dBFfdK9Vd0apB1ZYv/Uoz210QWcbB415IDL41j1FCnQkavc4BWMqXoxAhPXfV1 gkjePrjgpcG0D/68X3seUijr59wCdzouGZ3D/9CvstyMlj/VduCN4TcmHE6may62Cjla x74HtQ2pD1BRRf/WATvkQ/q8PbmIkAkX/3SqDJvURR3bpLqhwXraJludKY7+H0Q9fwQj jHf6YXftoLVkrzWxZSV9gyJrY6N7uB56+WCKnwV/1QwLRGfH2afPAA65zLTLiczbKYuB +ygRDPOuo0J2JoO71KdFTOZNWFwXCX+lV3aaIphsInfRN4O83RpmeXfLOUYpMInDH3WO CbDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f12si32283136pfh.257.2019.04.09.02.56.16; Tue, 09 Apr 2019 02:56:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726854AbfDIJzN (ORCPT + 99 others); Tue, 9 Apr 2019 05:55:13 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:59016 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726091AbfDIJzN (ORCPT ); Tue, 9 Apr 2019 05:55:13 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 86C548028A; Tue, 9 Apr 2019 11:55:03 +0200 (CEST) Date: Tue, 9 Apr 2019 11:55:03 +0200 From: Pavel Machek To: Nick Crews Cc: enric.balletbo@collabora.com, bleung@chromium.org, linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com, linux-kernel@vger.kernel.org, dlaurie@chromium.org, sjg@google.com, groeck@google.com, dtor@google.com Subject: Re: [PATCH v6] platform/chrome: Add Wilco EC keyboard backlight LEDs support Message-ID: <20190409095503.GB32344@atrey.karlin.mff.cuni.cz> References: <20190409001642.249197-1-ncrews@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190409001642.249197-1-ncrews@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The EC is in charge of controlling the keyboard backlight on > the Wilco platform. We expose a standard LED class device at > /sys/class/leds/chromeos::kbd_backlight. This driver is modeled As discussed, please use platform::. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html