Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 9 Apr 2019 16:42:31 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     Martin Kepplinger <martin.kepplinger@ginzinger.com>
Cc:     Paul Zimmerman <pauldzim@gmail.com>,
        Peter Huewe <peterhuewe@gmx.de>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Regression in suspend-to-ram (TPM related) with 5.1-rc1
 (BISECTED)
Message-ID: <20190409134231.GC9759@linux.intel.com>
References: <CADBGO7_WUoA53gM8EDFy6Q36SDEZPU9V=OUBA0QM20FOko51Rg@mail.gmail.com>
 <CADBGO7-UkQMxSPdSX9bGVPxSRROj75FA16FuXeFrVmcKVQ_Qdg@mail.gmail.com>
 <CADBGO7_XnbXiWHB=O1B_+b+CUA9g-bYJHN37VJ2SsxXMNHcPOQ@mail.gmail.com>
 <20190321134140.GA4603@linux.intel.com>
 <31f75727-d2c3-1afa-ab14-1dbc62a6315b@ginzinger.com>
 <CADBGO789BkFxwsuybwOvL3ydYP075U6KDccGnC7pfSJ_grfcng@mail.gmail.com>
 <233f44c3-9837-5da5-7d4c-8c0acff11e19@ginzinger.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <233f44c3-9837-5da5-7d4c-8c0acff11e19@ginzinger.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 08, 2019 at 11:04:22AM +0200, Martin Kepplinger wrote:
> On 08.04.19 08:59, Paul Zimmerman wrote:
> > On Sun, Apr 7, 2019 at 10:53 PM Martin Kepplinger
> > <martin.kepplinger@ginzinger.com> wrote:
> >>
> >> On 21.03.19 14:41, Jarkko Sakkinen wrote:
> >>> On Tue, Mar 19, 2019 at 04:03:37PM -0700, Paul Zimmerman wrote:
> >>>> So I bisected this down to:
> >>>>
> >>>> # first bad commit: [a3fbfae82b4cb3ff9928e29f34c64d0507cad874] tpm:
> >>>> take TPM chip power gating out of tpm_transmit()
> >>>>
> >>>> but this doesn't revert cleanly on Linus' HEAD. Anyone have an idea what
> >>>> could be wrong here?
> >>>
> >>> Sorry I've been in flu for the early week. I spotted the bug
> >>> immediately.  When I did these patches I did not have TPM 1.x at my
> >>> hand. I used fTPM 2.0 and dTPM 2.0. Stefan did TPM 1.x testing but I
> >>> probably forgot to ask him to try out suspend.
> >>>
> >>> Anyway, the bug is obvious and I'll send you a patch to try out.
> >>> Thanks a lot for bisecting this!
> >>>
> >>> /Jarkko
> >>
> >> Hi,
> >>
> >> Any news on this? It seems not to be fixed in -rc4. I'd happily test a
> >> patch too.
> >>
> > Hi Martin,
> > Patch is here: https://patchwork.kernel.org/patch/10865495/
> > Don't know what the status of it is though.
> > 
> > -- Paul
> > 
> 
> thanks. lgtm.
> 
> Tested-by: Martin Kepplinger <martink@posteo.de>

Thank you for testing this. Unfortunately it is already pulled so
cannot add new tags.

/Jarkko