Return-Path: thread-index: AcQVpG/7GGzmIKWeQaSbhX4jWfkK5g== Envelope-to: paul@sumlocktest.fsnet.co.uk Delivery-date: Sun, 04 Jan 2004 09:56:05 +0000 Message-ID: <01b901c415a4$6ffb5a60$d100000a@sbs2003.local> From: "Peter Chubb" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Class: urn:content-classes:message Importance: normal Priority: normal Content-Transfer-Encoding: 7bit X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.0 Date: Mon, 29 Mar 2004 16:42:27 +0100 To: Cc: "Hugang" , "Bart Samwel" , "Andrew Morton" , , "Bartek Kania" , Subject: Re: [PATCH] laptop-mode-2.6.0 version 5 In-Reply-To: <20040102120327.GA19822@suse.de> References: <20031231210756.315.qmail@mail.com><3FF3887C.90404@samwel.tk><20031231184830.1168b8ff.akpm@osdl.org><3FF43BAF.7040704@samwel.tk><3FF457C0.2040303@samwel.tk><20040101183545.GD5523@suse.de><20040102170234.66d6811d@localhost><20040102112733.GA19526@suse.de><20040102193849.6ff090da@localhost><20040102120327.GA19822@suse.de> X-Mailer: VM 7.14 under 21.4 (patch 14) "Reasonable Discussion" XEmacs Lucid Comments: Hyperbole mail buttons accepted, v04.18. X-Face: GgFg(Z>fx((4\32hvXq<)|jndSniCH~~$D)Ka:P@e@JR1P%Vr}EwUdfwf-4j\rUs#JR{'h# !]])6%Jh~b$VA|ALhnpPiHu[-x~@<"@Iv&|%R)Fq[[,(&Z'O)Q)xCqe1\M[F8#9l8~}#u$S$Rm`S9% \'T@`:&8>Sb*c5d'=eDYI&GF`+t[LfDH="MP5rwOO]w>ALi7'=QJHz&y&C&TE_3j! Sender: X-Mailing-List: linux-kernel@vger.kernel.org X-OriginalArrivalTime: 29 Mar 2004 15:42:28.0203 (UTC) FILETIME=[70A703B0:01C415A4] >>>>> "Jens" == Jens Axboe writes: Jens> The dump printk() needs to be changed anyways, the rw Jens> deciphering is not correct. Something like this is more Jens> appropriate: Jens> if (unlikely(block_dump)) { Jens> char b[BDEVNAME_SIZE]; Jens> printk("%s(%d): %s block %Lu on %s\n", current->comm, current-> pid, (rw & WRITE) ? "WRITE" : "READ", Jens> (u64) bio->bi_sector, bdevname(bio->bi_bdev, b)); Jens> } Please cast to (unsigned long long) not (u64) because on 64-bit architectures u64 is unsigned long, and you'll get a compiler warning. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/