Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 9 Apr 2019 15:20:30 -0600
From:   Jonathan Corbet <corbet@lwn.net>
To:     "Tobin C. Harding" <tobin@kernel.org>
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] docs: Remove unnecessary reference link title
Message-ID: <20190409152030.2ed66e86@lwn.net>
In-Reply-To: <20190409004359.29668-4-tobin@kernel.org>
References: <20190409004359.29668-1-tobin@kernel.org>
        <20190409004359.29668-4-tobin@kernel.org>
Organization: LWN.net
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue,  9 Apr 2019 10:43:58 +1000
"Tobin C. Harding" <tobin@kernel.org> wrote:

> Labels that precede a heading use the heading as the link title.
> Explicitly adding the link title is redundant and  makes the reference
> slightly less maintainable.
> 
> Remove unnecessary reference link title.

So I agree with the objective, but...

> -	As mentioned above in :ref:`VMA policies <vma_policy>` section,
> +	As mentioned above in :ref:`vma_policy` section,

...this one generates a warning that highlights a flaw in the reasoning
here:

	Documentation/admin-guide/mm/numa_memory_policy.rst:144: WARNING:
	undefined label: vma-policy (if the link has no caption the label
	must precede a section header)

Said label does not precede a section header, so it can't be used bare in
this way.

I'll apply the other three, but this one needs some repairs :)

Thanks,

jon