Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4284587yba; Tue, 9 Apr 2019 15:29:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqz9xW7ED7F65uOgtyZBvvM9D3yH0H4z7zI8yVDjg5EDvOIwjyKOX4lAhgTW3+wj4vQ3Igez X-Received: by 2002:a17:902:6b8c:: with SMTP id p12mr38830388plk.282.1554848959536; Tue, 09 Apr 2019 15:29:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554848959; cv=none; d=google.com; s=arc-20160816; b=SwXijx7TedMM7W61rm88UfaCTUuCobH1BoxfennhwYNq7Xo56yP0wHf125uYMycVh8 kInnq1aaEEcbBnSfrSpy3NS2QLNbOVAurTL61GdmjV3Db8DhCQCblHHJjN47Ydt5EKMB 1wIlxDnzw+PP+Wx6RABWuFmOeUmdg8yWadAyXUwa1nTwAWn9ZUuQdyVPF1/8B8vI9uFX fnNKi0sPAgGLjoJvpdOLWELD/0l9/ZWwgO9HTinEakaxC1eYHqjSBfPjzGYgYMMXuu2o cMlrVYDEM1x1eRUIC+XTFJi68lapccwFJBFwEDiVE05BmzLBnVCFnBuH5WeSISNCs5MP +LLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=HbPhvbGRIumTZA7by03NB+ymvg9sQPiEAiyPZl7uELc=; b=HnB+VUKH9/Pi6Avydk6EOBV3S5kIV5yvOfadZKbFKPhULZdkT+gPS3EO7xeRZxkTdR 6b713tbqtqxPUjX29PPDeZxy0X2ZHEhzrPX6Tj7BGxYksOVJNP4YRTmwxcLOnb1dDpH/ vR3G79mskeMDfq/NwWXCvM7tKWq88ipMOR0+yVrT2V/1OLinrNg/Hns7EKG+FiZIWoZ6 aE9MA65ygzyjR3olX43N/hszZs2XcClSZ8CvG1MM/DDHMpM7RXBL2tCK99qgc6HKwXkO jMy/ejMsjm+B18FbnL+bhXlbo4AuDNsPz+eoV2obSJvmCJPnUJphDfgdIfLfxgC2qR0W RKaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c10si29686994plo.216.2019.04.09.15.28.51; Tue, 09 Apr 2019 15:29:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726690AbfDIWZf (ORCPT + 99 others); Tue, 9 Apr 2019 18:25:35 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38472 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbfDIWZe (ORCPT ); Tue, 9 Apr 2019 18:25:34 -0400 Received: from localhost.localdomain (c-73-223-200-170.hsd1.ca.comcast.net [73.223.200.170]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id B3E3F1073; Tue, 9 Apr 2019 22:25:33 +0000 (UTC) Date: Tue, 9 Apr 2019 15:25:32 -0700 From: Andrew Morton To: "Tobin C. Harding" Cc: Vlastimil Babka , Roman Gushchin , "Tobin C. Harding" , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Matthew Wilcox , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 2/7] slob: Respect list_head abstraction layer Message-Id: <20190409152532.7f3a8168de2ec49aec152bd6@linux-foundation.org> In-Reply-To: <20190409200649.GD19840@eros.localdomain> References: <20190402230545.2929-1-tobin@kernel.org> <20190402230545.2929-3-tobin@kernel.org> <20190403180026.GC6778@tower.DHCP.thefacebook.com> <20190403211354.GC23288@eros.localdomain> <63e395fc-41c5-00bf-0767-a313554f7b23@suse.cz> <20190409200649.GD19840@eros.localdomain> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Apr 2019 06:06:49 +1000 "Tobin C. Harding" wrote: > On Tue, Apr 09, 2019 at 02:59:52PM +0200, Vlastimil Babka wrote: > > On 4/3/19 11:13 PM, Tobin C. Harding wrote: > > > > > According to 0day test robot this is triggering an error from > > > CHECK_DATA_CORRUPTION when the kernel is built with CONFIG_DEBUG_LIST. > > > > FWIW, that report [1] was for commit 15c8410c67adef from next-20190401. I've > > checked and it's still the v4 version, although the report came after you > > submitted v5 (it wasn't testing the patches from mailing list, but mmotm). I > > don't see any report for the v5 version so I'd expect it to be indeed fixed by > > the new approach that adds boolean return parameter to slob_page_alloc(). > > > > Vlastimil > > Oh man thanks! That is super cool, thanks for letting me know > Vlastimil. Yes, thanks for the followup.