Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
To:     Bjorn Helgaas <helgaas@kernel.org>,
        Wesley Sheng <wesley.sheng@microchip.com>
Cc:     kurt.schwemmer@microsemi.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, wesleyshenggit@sina.com,
        kelvin.cao@microchip.com
References: <1554734088-5755-1-git-send-email-wesley.sheng@microchip.com>
 <1554734088-5755-2-git-send-email-wesley.sheng@microchip.com>
 <20190409223642.GD256045@google.com>
From:   Logan Gunthorpe <logang@deltatee.com>
Message-ID: <634db3fa-286d-1136-b2af-1bf45501275f@deltatee.com>
Date:   Tue, 9 Apr 2019 17:32:13 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190409223642.GD256045@google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-CA
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH 1/2] switchtec: Fix false maximum supported PCIe function
 number issue
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019-04-09 4:36 p.m., Bjorn Helgaas wrote:
> Hi Wesley,
> 
> On Mon, Apr 08, 2019 at 10:34:47PM +0800, Wesley Sheng wrote:
>> The hardware supports up to 255 PFFs and the driver only supports 48, so
>> this patch updates the driver to support them all.
>> To be backward compatible, a new ioctl and corresponding data
>> structure are created, while keep the deprecated one.
> 
> The above is either one paragraph that needs to be rewrapped, or two
> paragraphs that need a blank line between.

Wesley can address this.

> What's a PFF?

PFF is really a concept internal to the Switchtec device. It stands for
PCIe Function Framework. Essentially, there is a bank of registers for
every PCIe Function (aka endpoint) in the switch. When I originally
wrote the driver, I assumed incorrectly there would only ever be one PFF
per port and the maximum number of ports for Switchtec parts is 48. In
fact, the hardware supports up to 255 and there are typically two PFFs
per upstream port (one for the port itself and one for the management
endpoint).

Logan