Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4431268yba; Tue, 9 Apr 2019 19:29:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqy3ldqPEFyzp+pJUh34bGrBoBIg89+vKoqfehLt+0Udx/K1MOyl/IPdzEcQpNtIcv4Acogp X-Received: by 2002:a62:6fc6:: with SMTP id k189mr22699572pfc.154.1554863364785; Tue, 09 Apr 2019 19:29:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554863364; cv=none; d=google.com; s=arc-20160816; b=BNUJFbpf/6YAGDSC3cZoRAvEIuxbVDlZOg7NGDW6cKqazPfM9W/3100Kz5zWVrfCBk nmXnKEbSax0pdEQQQjmjZeV/D1msSjBuBHO5jkieKbPZMTYFGnMmcx9I9U74ZUGsRpkE xJpFG9LTQM/geCQ9uJdG4zLU9hY+QGCF3V4FsxdFmXKd1iefldUEuTL1w093GPC06CqU C+sqRTTIJm4g26yD3ch5oeDPVnyEcGNEi1TqcfUQcip+rNMFn+otGVWSVBIfohSpRn8+ QeHPWfiaKagpfTVzncsX4XhAFqykjg04XoACY/LdSszp+DETVKZpXNCdggxLwdtgUq68 Z86g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=D6VFEX4tjvQDgusFjl96erUOBVkuqeHzQ+BBXr4q1qA=; b=Jo3FsSUrTniPne+qcLPiimqKco1or+jrvVYzp1FAUPWtz0QABwc4qeYKdembS4CzWO fpCj2pPeYJCgNPi/pYlFvI9d5zVOqVj0BT0Z5PkKyy65Pdtkv3g8/C3GXM4AeV3z0zaM ao/9JEclklw7BMRzvHVILP/e2Y5jI0MAD/5x2AfhJT6oFECjKMxChHYfiMGlRmUNHnqZ w6sgJjdIWtQaKz9eZNQTOE7j381WEPeppBgbXuSt6TyW+uXXk1WGiJHpryK/qpjO2CPP pk2kcWyOCnJEsSTvluP6qJTv1JL7mJCZn3fVHbZPnsIEttU0i2YLtb3s/cxPMHcRYItF ojLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=TeJrtWHp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m5si30305474pll.132.2019.04.09.19.29.09; Tue, 09 Apr 2019 19:29:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=TeJrtWHp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727153AbfDJCL3 (ORCPT + 99 others); Tue, 9 Apr 2019 22:11:29 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:60320 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726513AbfDJCL3 (ORCPT ); Tue, 9 Apr 2019 22:11:29 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3A29SIv098615; Wed, 10 Apr 2019 02:11:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=D6VFEX4tjvQDgusFjl96erUOBVkuqeHzQ+BBXr4q1qA=; b=TeJrtWHpVto5LAeLFWcKCSfya+EmjjmtsANBrFG+N6+3Bgvw9UMx3MJbz2ZpUndDaFqk kyHaCBJppQn7P60t6lj1X1vOLJSDWVEkMQ0D8jO5FFMwGb0HDO44oD56o2AoZuiVUZy8 zvmL0yGL7FV6GJpx/wRk4Zuy7f1KDBinh/J33v86LfhbY58jJCE098JBLZt0u+LLq0To p40xFj4ymr2B5k1BFcVqnLHaaLKfx2ermpvGHvc+negWWVAytX4Z51iN4PKl4S+oe+/e z3ovtEePefskBSAdnaEGlM2f3TgDbwEE/4rBSiPcmdNjJ+XOXaRziVINbOpOIsp0a2To DA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 2rphmegh5r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Apr 2019 02:11:13 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3A29dOo097026; Wed, 10 Apr 2019 02:11:13 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 2rpytbxknq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Apr 2019 02:11:13 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x3A2B9wA028552; Wed, 10 Apr 2019 02:11:09 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 09 Apr 2019 19:11:09 -0700 To: Bart Van Assche Cc: Alan Stern , "Martin K. Petersen" , Kento.A.Kobayashi@sony.com, "James E.J. Bottomley" , Oliver Neukum , gregkh@linuxfoundation.org, USB Storage list , Jacky.Cao@sony.com, Kernel development list , SCSI development list , USB list Subject: Re: [PATCH] usb: uas: fix usb subsystem hang after power off hub port From: "Martin K. Petersen" Organization: Oracle Corporation References: <1554823007.161891.6.camel@acm.org> Date: Tue, 09 Apr 2019 22:11:06 -0400 In-Reply-To: <1554823007.161891.6.camel@acm.org> (Bart Van Assche's message of "Tue, 09 Apr 2019 08:16:47 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9222 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=563 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904100015 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9222 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=583 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904100015 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bart, > From which context does that unbind happen? From inside a SCSI EH > callback or from the context of a workqueue? I think the former is not > allowed but that the latter is allowed. The SRP initiator driver > (ib_srp.c) follows the latter approach. Yeah. It's better to punt the actual tear down. -- Martin K. Petersen Oracle Linux Engineering