Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4635339yba; Wed, 10 Apr 2019 01:27:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqwFsRvVuRxXP9wrjdzn0eK+MHpjEFY7BDMcVMtw7WDtz3gdZbANWH1cpQpD2pkB76Ijlhxb X-Received: by 2002:a63:10c:: with SMTP id 12mr38214025pgb.276.1554884832064; Wed, 10 Apr 2019 01:27:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554884832; cv=none; d=google.com; s=arc-20160816; b=iTjafNBZicYOl+P4txDLyvopMT0At7akjz6vzctpMTrZGIMi1kO4S0Kl0xEA1PReO0 11d3Q7eD8KjGYcB1Kg4xdv4sMyn7sl+uyvYonPcNsR8Zlqn05OnK95sBfaV9a+FVCljE Y6bm0SORoxQbhhFH53gAdk7y94x6n9BQMKJB9HgpNwmVM3CJmFKaaOAHoJPqhR+vrJds Hf42yudNYnND90rtcqsGL1exbJHsMbgONz9xvALFzQN2Um9K+oLALrCOPgj4te04y32n JukF9I57QgDq4KKNlte2bZsRT3vLcTsD8sjQBuV7CFCCkHoG4NWyahMgBpjkwQqdatPj CtJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=LZIlf9qa4OInqgnI404sEwVZWuOoPfyhlTJTvQLrf+k=; b=U5fUDALS0lwHCJexW19PU0Gk4wioaQfr5ykjNvwJbxvzmyTtRaXfUlGukmVyLI1Cyd 8Ml50hQ8t7qtRG/CMrIR62CY6Kbtf1Jbj77yUyBkwJNyolYJjConEBnhH1VfVFNuT2iO d9uw9dmT6mbEd322FokvYOIR6IE7BkuMKDHTxGyoP3L+S+Xycu7bP2wSSijaOPU4kUUe HGHKXrRYNRt7YfnBPkQeb7B6pwS0zk264FA4vKO+goFWW9XmvO3/0J4eUKMFo/YYoDn2 Qw0qtDH3Xg/s0u/6PxEblofjKXHoG10fJ2OGN0Vh0e1SX2NsySmoNpwduiy0pdPtxj9W u2SQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l190si17331301pgd.146.2019.04.10.01.26.55; Wed, 10 Apr 2019 01:27:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729570AbfDJIZK (ORCPT + 99 others); Wed, 10 Apr 2019 04:25:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:52422 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729258AbfDJIZI (ORCPT ); Wed, 10 Apr 2019 04:25:08 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 30A60ABD4; Wed, 10 Apr 2019 08:25:06 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 1D74A1E429B; Wed, 10 Apr 2019 10:25:04 +0200 (CEST) Date: Wed, 10 Apr 2019 10:25:04 +0200 From: Jan Kara To: Pankaj Gupta Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, dan.j.williams@intel.com, zwisler@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, mst@redhat.com, jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net, hch@infradead.org, lenb@kernel.org, jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, darrick.wong@oracle.com, lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com, jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com, stefanha@redhat.com, aarcange@redhat.com, david@redhat.com, david@fromorbit.com, cohuck@redhat.com, xiaoguangrong.eric@gmail.com, pbonzini@redhat.com, kilobyte@angband.pl, yuval.shaia@oracle.com Subject: Re: [PATCH v5 4/6] dax: check synchronous mapping is supported Message-ID: <20190410082504.GF1426@quack2.suse.cz> References: <20190410040826.24371-1-pagupta@redhat.com> <20190410040826.24371-5-pagupta@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190410040826.24371-5-pagupta@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 10-04-19 09:38:24, Pankaj Gupta wrote: > This patch introduces 'daxdev_mapping_supported' helper > which checks if 'MAP_SYNC' is supported with filesystem > mapping. It also checks if corresponding dax_device is > synchronous. Virtio pmem device is asynchronous and > does not not support VM_SYNC. > > Suggested-by: Jan Kara > Signed-off-by: Pankaj Gupta > --- > include/linux/dax.h | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/include/linux/dax.h b/include/linux/dax.h > index b896706a5ee9..4a2a60ffec86 100644 > --- a/include/linux/dax.h > +++ b/include/linux/dax.h > @@ -38,6 +38,24 @@ void kill_dax(struct dax_device *dax_dev); > void dax_write_cache(struct dax_device *dax_dev, bool wc); > bool dax_write_cache_enabled(struct dax_device *dax_dev); > bool dax_synchronous(struct dax_device *dax_dev); > + > +/* > + * Callers check if synchronous mapping is enabled for DAX file > + * and attached dax device is also synchronous. > + * > + * dax_synchronous function verifies if dax device is synchronous. > + * Currently, only virtio pmem device supports asynchronous device > + * flush. > + */ Thanks for the patch! I'd restructure this comment like: /* * Check if given mapping is supported by the file / underlying device. */ > +static inline bool daxdev_mapping_supported(struct vm_area_struct *vma, > + struct dax_device *dax_dev) > +{ /* Everyone supports non-sync mappings */ > + if (!(vma->vm_flags & VM_SYNC)) > + return true; /* Sync mappings are supported only for files using DAX */ > + if (!IS_DAX(file_inode(vma->vm_file))) > + return false; /* Underlying device must support persisting through CPU instructions */ > + return dax_synchronous(dax_dev); > +} > #else > static inline struct dax_device *dax_get_by_host(const char *host) > { > @@ -69,6 +87,11 @@ static inline bool dax_synchronous(struct dax_device *dax_dev) > { > return true; > } > +static inline bool daxdev_mapping_supported(struct vm_area_struct *vma, > + struct dax_device *dax_dev) > +{ > + return true; This looks wrong. Shouldn't it rather be: return !(vma->flags & VM_SYNC); ? Honza -- Jan Kara SUSE Labs, CR