Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4636589yba; Wed, 10 Apr 2019 01:29:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqxq/xpZGRhGPE/Y+cWxx6wxrO20Z3N+/WqYK1MhMGkOmlBjDzKDlkFUlapOKYl36hsbOO1A X-Received: by 2002:a63:c605:: with SMTP id w5mr37262615pgg.355.1554884948839; Wed, 10 Apr 2019 01:29:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554884948; cv=none; d=google.com; s=arc-20160816; b=dIq3EEzG4B0JcvEVI4gxNWLrP2tZYEJEEzQKnrGAyXB3cR/1I9ibYjm8Z9IcYYLTo6 7lIq82JqfbbCZs4NLqc6XyNwx/7+Xql2W4YEyO2wvBTSz59Q08tfx1podVkkRjkdcBp4 cF9fGy5f8Dsob23/nDN4sIqDi7cI7/NR0ARCvdcSg8NcO7b0rEMHpeyzXKDq4NwwW+DK SUAoa/g6pyZq4A0bHQE69N6R74loLTlbDP06nTvff56ZOzpMplLSKBPnmZDGMGtlFrVq J53ihTK/hHLglTrvjrx452PPtgZQ4vkWqUsWiMfFM3XkyzmKRXGN6B1e7Jyxr4wb7YrF 1LuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=WG/3m5GAQ7Q/sjfg5CZ6Fye4ROIN4v/6GMlb59Ogqdo=; b=hewEIb6TeWnI4p8Q917pniMHAu6IRpQnup6TrF5G6/6GWXEgpVMGS+E+5TiNgAvoJV DQsJ/5qe+XR+C8grPj9yLg2yCk5yTLmdkMANC7eHb55Ojl4QKruN1u3zoDB3gPnBkheZ xTwRU9wxFyQb7qP76x9MvIOfEj+ra++2GoOduw0UFNC3UnVZi+mOWrHqNLXU65Xbbflu lLa6Si1cZbLhAawOijBy4wuK7715YZKLJ7AWS8sVkDNP3LFITOViz8bgMqEhOTMHi+pU EfU1Q20jwWSXSuRtBt2BZLiezxqWMx068k2II6GksQkmJSUqPDr24BMGujdQ0HQtk46q JwvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v10si25470281pgo.548.2019.04.10.01.28.51; Wed, 10 Apr 2019 01:29:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729625AbfDJI2H (ORCPT + 99 others); Wed, 10 Apr 2019 04:28:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:52896 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729045AbfDJI2G (ORCPT ); Wed, 10 Apr 2019 04:28:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B171CAC97; Wed, 10 Apr 2019 08:28:04 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 288631E429B; Wed, 10 Apr 2019 10:28:04 +0200 (CEST) Date: Wed, 10 Apr 2019 10:28:04 +0200 From: Jan Kara To: Pankaj Gupta Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, dan.j.williams@intel.com, zwisler@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, mst@redhat.com, jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net, hch@infradead.org, lenb@kernel.org, jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, darrick.wong@oracle.com, lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com, jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com, stefanha@redhat.com, aarcange@redhat.com, david@redhat.com, david@fromorbit.com, cohuck@redhat.com, xiaoguangrong.eric@gmail.com, pbonzini@redhat.com, kilobyte@angband.pl, yuval.shaia@oracle.com Subject: Re: [PATCH v5 3/6] libnvdimm: add dax_dev sync flag Message-ID: <20190410082804.GG1426@quack2.suse.cz> References: <20190410040826.24371-1-pagupta@redhat.com> <20190410040826.24371-4-pagupta@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190410040826.24371-4-pagupta@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 10-04-19 09:38:23, Pankaj Gupta wrote: > @@ -64,6 +65,10 @@ static inline bool dax_write_cache_enabled(struct dax_device *dax_dev) > { > return false; > } > +static inline bool dax_synchronous(struct dax_device *dax_dev) > +{ > + return true; > +} Is there a need to define dax_synchronous() for !CONFIG_DAX? Because that property of dax device is pretty much undefined and I don't see anything needing to call it for !CONFIG_DAX... Honza -- Jan Kara SUSE Labs, CR