Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4648413yba; Wed, 10 Apr 2019 01:48:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqzFYVsJ92zXtMUGIiOCPAWuRnJUKrta/jela9gWT47uU+Kbdi78p1zzeMSdbSq2V5NbE8Pq X-Received: by 2002:a17:902:b706:: with SMTP id d6mr42344206pls.250.1554886137667; Wed, 10 Apr 2019 01:48:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554886137; cv=none; d=google.com; s=arc-20160816; b=YVK0NcHKQKKxLcE56Kpa/mVVWNRTk6vl+mHZk4tca4dYPm+LeYTVPrNglM/90SH/Ue N8/3nyflbK3sDfAvU1CkEBPINUcopSFwLVjym7l5sbdXKt5Eu6BI58zM9c9OFPdX54Wr urpvo3D8FI9UB7qHlGXq9KGFDo2wSDq48cF20/AoNriuS1+IHp/ndWznlhcJGP0qWVkJ I37XhvgQ8gvbCFBeDbIajogNp/paKrgygIGY6VnOSv7rvt0nGYIHrwunkgRYUH+9YP1P dUztn9ZhfGbqyrMY31cBnH13DNfk2lgVLFkOxEOm9Xqdbsry5oAdpBuF98jD7M57sQTS lQUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=skXQPHyDnnOMLPLPuYFyTD9T90iTaKhdEM7fSMIdTTs=; b=Brqd8bWVx46eH0X2TKi/n7vnywNTN64/kxbIQG8fDPIat+ItPHr4TbMOJ9TDLgfgeW QvKaxVRnWDCsyJq+Zur4y/4zAQCtojaf9GfDq3Hu3YmZPmm6lVsKesoYZ2JIYS5f6TGm j8IVub/fepKkOaRicSIb0hm5qjCSJOkggW1wNCa/eEfVqTv1rtpx/DfsP05wYnX0vPEV HEUzhzbJ9526injOKSE3vIN+4gMZrS9tQ10Y+UU2DH8xhpI5h9l3ldk9dGj1R6KDAEFe 8w99KKWQTmMAB7Zz+FYyyW9BBFK2RSV+Vyj1AbaurP9mtEaysl2ZlF0sj8f08sAsGU/X iOxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TkhvHLwM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l18si31059723pgk.289.2019.04.10.01.48.41; Wed, 10 Apr 2019 01:48:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TkhvHLwM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728696AbfDJHsK (ORCPT + 99 others); Wed, 10 Apr 2019 03:48:10 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39700 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727527AbfDJHsK (ORCPT ); Wed, 10 Apr 2019 03:48:10 -0400 Received: by mail-pf1-f195.google.com with SMTP id i17so946046pfo.6 for ; Wed, 10 Apr 2019 00:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=skXQPHyDnnOMLPLPuYFyTD9T90iTaKhdEM7fSMIdTTs=; b=TkhvHLwMDsXKGAq0AiPDmvH5yC1SdIcVn6Oazrqv8ASNM8ALILI1m7rMlztC6i4dDV 4M0++4jdbtMValVSWn83txV7CB5hj3olvE2GOkzebV9y4lvwgrcNO8Oc8ZTnIYg9ubf7 F8vzG2K7CJodAL0bqEPAVHOXsZQOrSqXH4qgJvBWXOP2uluSrjMLq5IsAMHa546tdE2B 6RKieD758yfk5Q/yUroKzvCdDf4EYiKXVdcN0HUDoQ4DJIYYyS7AbSvKuvGgdX1Ln559 RpSu1Z3vAFYWDZ4GHzM4/Ce5gzgtvfCftRqfLOkjvH7Zi9PIOaV9XPUsQTXVXmCRnNpP OL4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=skXQPHyDnnOMLPLPuYFyTD9T90iTaKhdEM7fSMIdTTs=; b=TttjKk3VUYXTXCfYhkPatbja1mInPx7X/4j6KnDdUuG4qZk0mnrIoLeCWysmJi1SRr bFi2bsu7TEDEG0c3AQrjHtlvpR04HzTRCAf6Y5EufsLBBuGUiOQes3E15ARJP8zTDa4+ FvYX1FaVKy36Szl12t6wm4AqAiJ7fRaz46v1hC35oCUlb2UJWliT8SSV218G72fryJGZ e0nFrE6Glc922WPQc993UU2Lz8GK2EmxmdV7YsCGEyE8+5Rjjy2vDxRa4owFgpUu2PwG MTGG8bqdx4SS5znwSf6aYSdiBL1NT3uR4+BX6vDtasrqCZJctwGYVCR5VY0+il/wFJq2 FQfA== X-Gm-Message-State: APjAAAXbBZ1X9ddxMiz58revgw5wCBQZWl4yF+lwU23ptUPC20n4iG+w yZryrW87yOsKwIEwSJ60heYhKQ== X-Received: by 2002:a62:69c2:: with SMTP id e185mr41478628pfc.119.1554882489460; Wed, 10 Apr 2019 00:48:09 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id 17sm46355818pgz.52.2019.04.10.00.48.06 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 10 Apr 2019 00:48:08 -0700 (PDT) From: Baolin Wang To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: orsonzhai@gmail.com, zhang.lyra@gmail.com, baolin.wang@linaro.org, broonie@kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpio: eic: sprd: Fix incorrect irq type setting for the sync EIC Date: Wed, 10 Apr 2019 15:47:54 +0800 Message-Id: X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When setting sync EIC as IRQ_TYPE_EDGE_BOTH type, we missed to set the SPRD_EIC_SYNC_INTMODE register to 0, which means detecting edge signals. Thus this patch fixes the issue. Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support") Cc: Signed-off-by: Baolin Wang --- drivers/gpio/gpio-eic-sprd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c index f0223ce..7709226 100644 --- a/drivers/gpio/gpio-eic-sprd.c +++ b/drivers/gpio/gpio-eic-sprd.c @@ -414,6 +414,7 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type) irq_set_handler_locked(data, handle_edge_irq); break; case IRQ_TYPE_EDGE_BOTH: + sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0); sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 1); irq_set_handler_locked(data, handle_edge_irq); break; -- 1.7.9.5