Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4676094yba; Wed, 10 Apr 2019 02:31:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqw6pPdiUymPm7yle7HOMXQINHpzNFKtnC8oMIYQBAIkbVWd/rcVaxZ/t/MjCVGm1ThrztjX X-Received: by 2002:a17:902:70c6:: with SMTP id l6mr15939265plt.95.1554888669251; Wed, 10 Apr 2019 02:31:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554888669; cv=none; d=google.com; s=arc-20160816; b=zK9v2ZHKR0rsFOaZZ91HNLslznt6FKI8LScCw7qgTWpaL5+4ycf2jIpUFfM8Z3M2nC IDd/TOOilKcrkkyDhQ9/bSpDSTwFedhZ4A/RmyvLRWvMv/l5qXaLl7CV7Efl1IFnjcSa 3nebE9jSX3Tw3wJN8wGX0Ob+ylzB481yiKGX5Fx29JTCHCJy47G3oXVs9IzKhn0dxhpU C3f0T3vW+sOUulLCEstl/rY9HpY+iTw4g/+Buk8BcVz4hgcvZ+nt9it3ISFAfeNcheRJ sBm4lgkwMrI0ocSt+4MJpJbNi9K6Vdkz/TpdskAaoMe415M917QR19Mfl1fS2PmFPuYa Cj+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date; bh=aSsFpY+qX32Fqo5wYbgTKiTKIlsXfHXJoK8+qKtehIQ=; b=xmOp6QSNufe1J418hty3VMHhFvaEzRQmWSK/3CSQ9RyXLKyNvPirCrQ/V2qQkmg8zW vvuZmC1MKf7IKfN3q1J/YKbexP5zioq+m3G86kPiDzUigEm4wS3MZgnXPI86ptB+7v9T GfFFmOPlNTh5G1FhJuOeJDoK8lUYaWzSvSYLh8nvJs+pzn4BynvQrUkWQ/us4hxIXOhm QuI2jlCmpQgfahS8JcBmM3IXtHE9pD6VN61T4KT61EfUqyc9UjNs5IzT2Ij4vPa2yAzx JvFDijV10bU8e9WimChY0cG9o696TZzW2bTvEYW7g+fj63G9qRYa2YRYFM51VJItmehs q8ww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si23658999pfd.55.2019.04.10.02.30.52; Wed, 10 Apr 2019 02:31:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729642AbfDJIbV (ORCPT + 99 others); Wed, 10 Apr 2019 04:31:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42574 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729024AbfDJIbV (ORCPT ); Wed, 10 Apr 2019 04:31:21 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 424F27F6B0; Wed, 10 Apr 2019 08:31:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 09AAF108BEF7; Wed, 10 Apr 2019 08:31:20 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9C8ED1803385; Wed, 10 Apr 2019 08:31:19 +0000 (UTC) Date: Wed, 10 Apr 2019 04:31:19 -0400 (EDT) From: Pankaj Gupta To: Jan Kara Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, dan j williams , zwisler@kernel.org, vishal l verma , dave jiang , mst@redhat.com, jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net, hch@infradead.org, lenb@kernel.org, tytso@mit.edu, adilger kernel , darrick wong , lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com, jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com, stefanha@redhat.com, aarcange@redhat.com, david@redhat.com, david@fromorbit.com, cohuck@redhat.com, xiaoguangrong eric , pbonzini@redhat.com, kilobyte@angband.pl, yuval shaia Message-ID: <299038321.20701113.1554885079188.JavaMail.zimbra@redhat.com> In-Reply-To: <20190410082504.GF1426@quack2.suse.cz> References: <20190410040826.24371-1-pagupta@redhat.com> <20190410040826.24371-5-pagupta@redhat.com> <20190410082504.GF1426@quack2.suse.cz> Subject: Re: [PATCH v5 4/6] dax: check synchronous mapping is supported MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.65.16.19, 10.4.195.8] Thread-Topic: check synchronous mapping is supported Thread-Index: 3OuZRphtFQExf6N3zq0ZSCMeImf/pQ== X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 10 Apr 2019 08:31:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > This patch introduces 'daxdev_mapping_supported' helper > > which checks if 'MAP_SYNC' is supported with filesystem > > mapping. It also checks if corresponding dax_device is > > synchronous. Virtio pmem device is asynchronous and > > does not not support VM_SYNC. > > > > Suggested-by: Jan Kara > > Signed-off-by: Pankaj Gupta > > --- > > include/linux/dax.h | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/include/linux/dax.h b/include/linux/dax.h > > index b896706a5ee9..4a2a60ffec86 100644 > > --- a/include/linux/dax.h > > +++ b/include/linux/dax.h > > @@ -38,6 +38,24 @@ void kill_dax(struct dax_device *dax_dev); > > void dax_write_cache(struct dax_device *dax_dev, bool wc); > > bool dax_write_cache_enabled(struct dax_device *dax_dev); > > bool dax_synchronous(struct dax_device *dax_dev); > > + > > +/* > > + * Callers check if synchronous mapping is enabled for DAX file > > + * and attached dax device is also synchronous. > > + * > > + * dax_synchronous function verifies if dax device is synchronous. > > + * Currently, only virtio pmem device supports asynchronous device > > + * flush. > > + */ > > Thanks for the patch! I'd restructure this comment like: > > /* > * Check if given mapping is supported by the file / underlying device. > */ Sure. > > +static inline bool daxdev_mapping_supported(struct vm_area_struct *vma, > > + struct dax_device *dax_dev) > > +{ > > /* Everyone supports non-sync mappings */ > > + if (!(vma->vm_flags & VM_SYNC)) > > + return true; > /* Sync mappings are supported only for files using DAX */ > > + if (!IS_DAX(file_inode(vma->vm_file))) > > + return false; > /* Underlying device must support persisting through CPU instructions */ > > + return dax_synchronous(dax_dev); > > +} > > #else > > static inline struct dax_device *dax_get_by_host(const char *host) > > { > > @@ -69,6 +87,11 @@ static inline bool dax_synchronous(struct dax_device > > *dax_dev) > > { > > return true; > > } > > +static inline bool daxdev_mapping_supported(struct vm_area_struct *vma, > > + struct dax_device *dax_dev) > > +{ > > + return true; > > This looks wrong. Shouldn't it rather be: > > return !(vma->flags & VM_SYNC); > > ? Right. I will correct this. Thanks, Pankaj > > Honza > -- > Jan Kara > SUSE Labs, CR >