Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4735242yba; Wed, 10 Apr 2019 03:57:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqxv1AHmpSwfwZYy0+6wtf9DVog6PfDS6A8l2gqVlVomM462jUr0pR1DvV2sv+HEkGgngHU3 X-Received: by 2002:a63:c505:: with SMTP id f5mr40846054pgd.87.1554893837686; Wed, 10 Apr 2019 03:57:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554893837; cv=none; d=google.com; s=arc-20160816; b=dJzWI4owLOH3PhLzkE7L3kgl69kvSOBhFKpVlUpxqv9komK5C4BlIVpuDanrCG4emU m8AwnwHGTLrtCZQW2ri+GbTr++0CGdsqrBW6bNfBl7KQIpEfQ/Mj/g2/XAC7VrB8adr4 Pc1ypH6/OcAI5kafEcj064ZfaKSOzTi2o1BaKzF/qHVciQFekC0YBjGtEwDq+hwIQFl8 J6SknC6gJ8MnfoIsgRNHOI8tfWHQP0h7lIab2tc4JGcCSOylgyevQWRhCPtLizrKLVFv GUZOQb/FnkWVnDeIQ79P9zkJzAGceUB2++9k1eCaDRHa34IzPaq41NP3eIbsP7uZJ3p5 jZWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date; bh=M+8qB1pig3MYCm7zJINuc9t81ppdTxjpMMxMBM4aPiM=; b=0zQAnfPyB4DO0TJAsepZYx3jurkgzmIiuGzFzsoEAItkS7I1cw0Kndm9wVC9NPYZbi lNNjnkPLzWmiHrSDEqfHFtvYAliZsnUbMtLjsBaqJRs9rNaizd/4ehep35hClO+qz4c6 ppKQRvnsP8c7PLGN/RTdtVH15IMIFV/SlU6dzA7ZCnEQgchhuZLD2IVGnsvXaapSYDrs zkfFDVRkqY/c8JNKPzSw4utbZjldvEl/c/vcK7nYb7tIgJ41GO5fxBiNRM6MbY1FnZks KVTUXT9OY1gxOSOg29jTxhJi0s5jebJhAsKl9JJmLTaOevYm8DW8P9CTkrJo1PJpc0Ox rZhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f36si32001151pgf.332.2019.04.10.03.56.47; Wed, 10 Apr 2019 03:57:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729653AbfDJIif (ORCPT + 99 others); Wed, 10 Apr 2019 04:38:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57448 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729450AbfDJIie (ORCPT ); Wed, 10 Apr 2019 04:38:34 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 25C9F3088A7E; Wed, 10 Apr 2019 08:38:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 043A45D962; Wed, 10 Apr 2019 08:38:34 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B08A91803385; Wed, 10 Apr 2019 08:38:33 +0000 (UTC) Date: Wed, 10 Apr 2019 04:38:33 -0400 (EDT) From: Pankaj Gupta To: Jan Kara Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, dan j williams , zwisler@kernel.org, vishal l verma , dave jiang , mst@redhat.com, jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net, hch@infradead.org, lenb@kernel.org, tytso@mit.edu, adilger kernel , darrick wong , lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com, jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com, stefanha@redhat.com, aarcange@redhat.com, david@redhat.com, david@fromorbit.com, cohuck@redhat.com, xiaoguangrong eric , pbonzini@redhat.com, kilobyte@angband.pl, yuval shaia Message-ID: <1336073020.20708683.1554885513376.JavaMail.zimbra@redhat.com> In-Reply-To: <20190410082804.GG1426@quack2.suse.cz> References: <20190410040826.24371-1-pagupta@redhat.com> <20190410040826.24371-4-pagupta@redhat.com> <20190410082804.GG1426@quack2.suse.cz> Subject: Re: [PATCH v5 3/6] libnvdimm: add dax_dev sync flag MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.65.16.19, 10.4.195.22] Thread-Topic: libnvdimm: add dax_dev sync flag Thread-Index: 3uZjW5jhUzBiRAKeiJEV9NRdm5X/hQ== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 10 Apr 2019 08:38:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On Wed 10-04-19 09:38:23, Pankaj Gupta wrote: > > @@ -64,6 +65,10 @@ static inline bool dax_write_cache_enabled(struct > > dax_device *dax_dev) > > { > > return false; > > } > > +static inline bool dax_synchronous(struct dax_device *dax_dev) > > +{ > > + return true; > > +} > > Is there a need to define dax_synchronous() for !CONFIG_DAX? Because that > property of dax device is pretty much undefined and I don't see anything > needing to call it for !CONFIG_DAX... You are right. Will remove this. Thanks for the review. Best regards, Pankaj > > Honza > -- > Jan Kara > SUSE Labs, CR >