Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4742929yba; Wed, 10 Apr 2019 04:06:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqxKgDjAyxqEYFrdCjFhkJ5IQmcist8/BOrGI6g12X0xRsnAGINfxFH6wuO1qxg2Ctna3hqA X-Received: by 2002:a63:2b41:: with SMTP id r62mr38450138pgr.403.1554894390516; Wed, 10 Apr 2019 04:06:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554894390; cv=none; d=google.com; s=arc-20160816; b=qXJoFFlV9n8VUs87W8D7UlyB0nqN2KuiCZo9gvnhvW/L5RbKp1LnSctA2q2qmTslf5 hkA6IihWSAYCbsR9z1VM2isENckFJET1qFEaOLNQcbvxG62FFgBxn7JwnIefoW7+4hyp cAZStH0w+2cBKpZ3QgQel8wRJ9AXueaEGBZUmiMWsznEE7WAXcsdhjkD2y5RR2XO0q7y gjbPWF1dZtn668QGwfTkv+3iuIysv98IvTS6amHYMiDJtczWA8SnjoLnVIu6PHSItJwI 230vnpK8aHPkEzHMVdsD0MHzIWphytaS9RcPiOaLrnKMMZ9LtvSCNm4SPq3Ku2gnhYrR tEEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MAwA8hdcGfucrSp9x2LdZHnMV91ksCJGxM5uXbbJCtY=; b=Ylfq8YNMsS7Q5IwK8oMX6JL8H/vPhlKpBIQt/XYobn5x/IbizTlEOmwq/BO6nJCVCV G/30Kg+G1QeoQ1doGtxgSOOX8INF1el2+bZdr9TOE4hwhJeV2sH2vMr2FbZfkQnVyXj5 7BR6eQwxXMTepIj3kTZwk88xcCsRPFAm4qFMmDYWsxTT6RvqaoSaIQdWzLfuKyOdkRX/ dyCRZJH45QZx7IMdqpbi4oW07JxKDo3z1shi/cBufcBn9Jipeao6m6mdv+/qnvvADZaJ tI2YP8WCy/TXbS0P5ir6JXnRGZeg1P4z/p8V9lE8PvbBKQLQ7+m7GbGc8Hk858ryMmnm vHSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JTipYG6i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si2144460pfr.262.2019.04.10.04.06.14; Wed, 10 Apr 2019 04:06:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JTipYG6i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729776AbfDJIxK (ORCPT + 99 others); Wed, 10 Apr 2019 04:53:10 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:42860 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728821AbfDJIxK (ORCPT ); Wed, 10 Apr 2019 04:53:10 -0400 Received: by mail-pf1-f195.google.com with SMTP id w25so1042674pfi.9; Wed, 10 Apr 2019 01:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MAwA8hdcGfucrSp9x2LdZHnMV91ksCJGxM5uXbbJCtY=; b=JTipYG6iK0X5X1nmc9EvGfJ0YCn8chNQPHnQm7tekpIo64uFjqjB9TTWSmYR3p2dx1 zKw4VN9hmz6TSOBo4ouIrBarjF1yuREgL8i5e+ecToq+Br2zrGEL+si/n/6+HIdM8J1a b+W3gWbrdJcrjOPvvVP18247T9LTYWT1eIiNEAXgoRbyEXYv069DoOFuFW4AtFvmEqZE 47AmQV4CifH0Hty+LHZ9/kdFuU4qwIhoT2LGJK89islYyIofFGmPjIE8Y8C3D2iF7HTC 6gfb/eBBSPmayR00oCqW7xQ3X+4q2HwSlGPEeXocBxdlSBgaLPQBAlMOIoPIpLy99Xyu VSmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MAwA8hdcGfucrSp9x2LdZHnMV91ksCJGxM5uXbbJCtY=; b=OwdUBIaCDat2YfS6FpBCItKOyycfvHUBBiv+R5san8BUvxnerMhgbj0lmUbE3KhBFm TJg/sjYa503pqkCnfedieSM9bBSJbpjqlNw/qGDUJTV5+jCfpVc0Kyega/pBQa+ZeczO e+g09Smi13fZf1KsYnrlO/mUXXP/ShdRI025vL0xLHGEmAOBbw156sG6xeAH1wMsI1mE ZGI3b8Qqz5rlbxnE2DMCxC7aFFk6TRhni04php9y6l7KpbuUWfk/8SCPANy4N9A5I6zo 27n3rWWaGX1E1u8vwx1PpnocmVS1O8YtElu5obP2OAPcg6JTH2C8IB6dlC9CYoFK/mer 5AiQ== X-Gm-Message-State: APjAAAXNSCzQy3BgdfbSkhWf1BY01C/TU4p8NIYFTcUpT6zjm2aL3wrr zU8N41rPLgU3rnT2pjMqj9s= X-Received: by 2002:a63:2a8f:: with SMTP id q137mr38826358pgq.31.1554886389327; Wed, 10 Apr 2019 01:53:09 -0700 (PDT) Received: from localhost ([175.223.11.210]) by smtp.gmail.com with ESMTPSA id l192sm22246219pge.42.2019.04.10.01.53.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Apr 2019 01:53:08 -0700 (PDT) Date: Wed, 10 Apr 2019 17:53:05 +0900 From: Sergey Senozhatsky To: Alastair D'Silva Cc: alastair@d-silva.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Karsten Keil , Jassi Brar , Tom Lendacky , "David S. Miller" , Jose Abreu , Kalle Valo , Stanislaw Gruszka , Benson Leung , Enric Balletbo i Serra , "James E.J. Bottomley" , "Martin K. Petersen" , Greg Kroah-Hartman , Alexander Viro , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Andrew Morton , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 4/4] lib/hexdump.c: Allow multiple groups to be separated by lines '|' Message-ID: <20190410085305.GA4937@jagdpanzerIV> References: <20190410031720.11067-1-alastair@au1.ibm.com> <20190410031720.11067-5-alastair@au1.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190410031720.11067-5-alastair@au1.ibm.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (04/10/19 13:17), Alastair D'Silva wrote: > With the wider display format, it can become hard to identify how many > bytes into the line you are looking at. > > The patch adds new flags to hex_dump_to_buffer() and print_hex_dump() to > print vertical lines to separate every N groups of bytes. > > eg. > buf:00000000: 454d414e 43415053|4e495f45 00584544 NAMESPAC|E_INDEX. > buf:00000010: 00000000 00000002|00000000 00000000 ........|........ What if the output had |-s in it? ||||||||| -ss