Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5100619yba; Wed, 10 Apr 2019 11:19:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqxzBDOEeLT2Dpmq3YH/ZZT/wkqoCsp386Ox7DhMTI4zFwEIEOnZmKaL6ORTj2TLmZlGxvgp X-Received: by 2002:a65:6210:: with SMTP id d16mr41197462pgv.110.1554920383386; Wed, 10 Apr 2019 11:19:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554920383; cv=none; d=google.com; s=arc-20160816; b=cRdsvG6OncrrcJ8hM63PW7g/TZM0J7vg7IEq0t9RywNSLufcrJtfPwlLK/zpBNRb5j vyaq1oLrYzBPd0LFr56o5e9OzB6B51u73brlk0FgzA1rIMzny4SY5v+GAY++waffB3XR 65bmYwiD6WQhxbl6tsuXdioxvMBCBGfU0UzzLwL1+xU9ccLQHGWkZ5eNITin1ZVRYByd D1trIctWhA6RQo3EU/XU0I08hM5k15lIL56DQSgZgEK/xqembdDW0NBbQ8k3NTPZlw7h D2S2deoCNXjTmOpnjHE44YrqkcYYe+7vp63dkYdFeo5n2uAU9ZbC0XnB0gDoZ7gBqpk7 NRsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date; bh=uaL85NyxW7uW70jfayPSmhOvrTF0QrtBATMbTkYbSoc=; b=KohnWSq8+AG+8z1RdxNC07aruNvGQGOsmy+E3+uJCd84uDq0dKU3QyXG6Ub639ibOu UNTIfWr9DKGQUEyjtNhsLBvmhCxkMbil+qFRSh2LeSbMhDDMpUmFoAk6vNcYuWXL2m4c PqoqmzEXgKLY9kZLM6IK4XpiWLGZ9LzxTAPqP7AZTAExqdFtwos6U1KxVdWoCBlNbC/T f6ppPwrgGDurcXClVILJmw1zgvPVaRojV02e32LEZ6nWv1hb2wp12fPONG/HtV6+wGDF oScEUE00FzXYcTrQ9vVUWX0HW/ZBHP9pCZtsvPFKqa41qvX6+NP0UIWq88TdyDCqwhIO xwGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f10si31705008pgv.589.2019.04.10.11.19.27; Wed, 10 Apr 2019 11:19:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730693AbfDJPoY (ORCPT + 99 others); Wed, 10 Apr 2019 11:44:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41080 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727583AbfDJPoX (ORCPT ); Wed, 10 Apr 2019 11:44:23 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 646203B3C0; Wed, 10 Apr 2019 15:44:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 46B9F69197; Wed, 10 Apr 2019 15:44:22 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C12353FA45; Wed, 10 Apr 2019 15:44:21 +0000 (UTC) Date: Wed, 10 Apr 2019 11:44:21 -0400 (EDT) From: Pankaj Gupta To: Yuval Shaia Cc: Cornelia Huck , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, dan j williams , zwisler@kernel.org, vishal l verma , dave jiang , mst@redhat.com, jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net, hch@infradead.org, lenb@kernel.org, jack@suse.cz, tytso@mit.edu, adilger kernel , darrick wong , lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com, jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com, stefanha@redhat.com, aarcange@redhat.com, david@redhat.com, david@fromorbit.com, xiaoguangrong eric , pbonzini@redhat.com, kilobyte@angband.pl Message-ID: <1051460502.20833720.1554911061402.JavaMail.zimbra@redhat.com> In-Reply-To: <20190410143826.GA7856@lap1> References: <20190410040826.24371-1-pagupta@redhat.com> <20190410040826.24371-3-pagupta@redhat.com> <20190410142426.5bf0d9a4.cohuck@redhat.com> <20190410143826.GA7856@lap1> Subject: Re: [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.116.117, 10.4.195.10] Thread-Topic: virtio-pmem: Add virtio pmem driver Thread-Index: XAITNQLp2s7XVOQXZG8TjuXiRrFoog== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 10 Apr 2019 15:44:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > > > This patch adds virtio-pmem driver for KVM guest. > > > > > > Guest reads the persistent memory range information from > > > Qemu over VIRTIO and registers it on nvdimm_bus. It also > > > creates a nd_region object with the persistent memory > > > range information so that existing 'nvdimm/pmem' driver > > > can reserve this into system memory map. This way > > > 'virtio-pmem' driver uses existing functionality of pmem > > > driver to register persistent memory compatible for DAX > > > capable filesystems. > > > > > > This also provides function to perform guest flush over > > > VIRTIO from 'pmem' driver when userspace performs flush > > > on DAX memory range. > > > > > > Signed-off-by: Pankaj Gupta > > > --- > > > drivers/nvdimm/virtio_pmem.c | 88 ++++++++++++++++++++++ > > > drivers/virtio/Kconfig | 10 +++ > > > drivers/virtio/Makefile | 1 + > > > drivers/virtio/pmem.c | 124 +++++++++++++++++++++++++++++++ > > > include/linux/virtio_pmem.h | 60 +++++++++++++++ > > > include/uapi/linux/virtio_ids.h | 1 + > > > include/uapi/linux/virtio_pmem.h | 10 +++ > > > 7 files changed, 294 insertions(+) > > > create mode 100644 drivers/nvdimm/virtio_pmem.c > > > create mode 100644 drivers/virtio/pmem.c > > > create mode 100644 include/linux/virtio_pmem.h > > > create mode 100644 include/uapi/linux/virtio_pmem.h > > > > > (...) > > > diff --git a/drivers/virtio/pmem.c b/drivers/virtio/pmem.c > > > new file mode 100644 > > > index 000000000000..cc9de9589d56 > > > --- /dev/null > > > +++ b/drivers/virtio/pmem.c > > > @@ -0,0 +1,124 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * virtio_pmem.c: Virtio pmem Driver > > > + * > > > + * Discovers persistent memory range information > > > + * from host and registers the virtual pmem device > > > + * with libnvdimm core. > > > + */ > > > +#include > > > +#include <../../drivers/nvdimm/nd.h> > > > + > > > +static struct virtio_device_id id_table[] = { > > > + { VIRTIO_ID_PMEM, VIRTIO_DEV_ANY_ID }, > > > + { 0 }, > > > +}; > > > + > > > + /* Initialize virt queue */ > > > +static int init_vq(struct virtio_pmem *vpmem) > > > > IMHO, you don't gain much by splitting off this function... > > It make sense to have all the vq-init-related stuff in one function, so > here pmem_lock and req_list are used only for the vq. Yes. > Saying that - maybe it would be better to have the 3 in one struct. > > > > > > +{ > > > + struct virtqueue *vq; > > > + > > > + /* single vq */ > > > + vpmem->req_vq = vq = virtio_find_single_vq(vpmem->vdev, > > > + host_ack, "flush_queue"); > > > + if (IS_ERR(vq)) > > > + return PTR_ERR(vq); > > > > I'm personally not a fan of chained assignments... I think I'd just > > drop the 'vq' variable and operate on vpmem->req_vq directly. > > +1 Will drop extra vq. > > > > > > + > > > + spin_lock_init(&vpmem->pmem_lock); > > > + INIT_LIST_HEAD(&vpmem->req_list); > > > + > > > + return 0; > > > +}; > > > + > > > +static int virtio_pmem_probe(struct virtio_device *vdev) > > > +{ > > > + int err = 0; > > > + struct resource res; > > > + struct virtio_pmem *vpmem; > > > + struct nvdimm_bus *nvdimm_bus; > > > + struct nd_region_desc ndr_desc = {}; > > > + int nid = dev_to_node(&vdev->dev); > > > + struct nd_region *nd_region; > > > + > > > + if (!vdev->config->get) { > > > + dev_err(&vdev->dev, "%s failure: config disabled\n", > > > > Maybe s/config disabled/config access disabled/ ? That seems to be the > > more common message. > > > > > + __func__); > > > + return -EINVAL; > > > + } > > > + > > > + vdev->priv = vpmem = devm_kzalloc(&vdev->dev, sizeof(*vpmem), > > > + GFP_KERNEL); > > > > Here, the vpmem variable makes sense for convenience, but I'm again not > > a fan of the chaining :) > > +1 here as well. > > > > > > + if (!vpmem) { > > > + err = -ENOMEM; > > > + goto out_err; > > > + } > > > + > > > + vpmem->vdev = vdev; > > > + err = init_vq(vpmem); > > > + if (err) > > > + goto out_err; > > > + > > > + virtio_cread(vpmem->vdev, struct virtio_pmem_config, > > > + start, &vpmem->start); > > > + virtio_cread(vpmem->vdev, struct virtio_pmem_config, > > > + size, &vpmem->size); > > > + > > > + res.start = vpmem->start; > > > + res.end = vpmem->start + vpmem->size-1; > > > + vpmem->nd_desc.provider_name = "virtio-pmem"; > > > + vpmem->nd_desc.module = THIS_MODULE; > > > + > > > + vpmem->nvdimm_bus = nvdimm_bus = nvdimm_bus_register(&vdev->dev, > > > + &vpmem->nd_desc); > > > > And here :) > > > > > + if (!nvdimm_bus) > > > + goto out_vq; > > > + > > > + dev_set_drvdata(&vdev->dev, nvdimm_bus); > > > + > > > + ndr_desc.res = &res; > > > + ndr_desc.numa_node = nid; > > > + ndr_desc.flush = virtio_pmem_flush; > > > + set_bit(ND_REGION_PAGEMAP, &ndr_desc.flags); > > > + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > > > + nd_region = nvdimm_pmem_region_create(nvdimm_bus, &ndr_desc); > > > + nd_region->provider_data = dev_to_virtio > > > + (nd_region->dev.parent->parent); > > > > Isn't it clear that this parent chain will always end up at &vdev->dev? > > Maybe simply set ->provider_data to vdev directly? (Does it need to > > grab a reference count of the device, BTW?) > > > > > + > > > + if (!nd_region) > > > + goto out_nd; > > > > Probably better to do this check before you access nd_region's > > members :) > > > > > + > > > + return 0; > > > +out_nd: > > > + err = -ENXIO; > > > + nvdimm_bus_unregister(nvdimm_bus); > > > +out_vq: > > > + vdev->config->del_vqs(vdev); > > > +out_err: > > > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > > > + return err; > > > +} > > > + > > > +static void virtio_pmem_remove(struct virtio_device *vdev) > > > +{ > > > + struct virtio_pmem *vpmem = vdev->priv; > > > + struct nvdimm_bus *nvdimm_bus = dev_get_drvdata(&vdev->dev); > > > + > > > + nvdimm_bus_unregister(nvdimm_bus); > > > > I haven't followed this around the nvdimm code, but is the nd_region > > you created during probe cleaned up automatically, or would you need to > > do something here? > > > > > + vdev->config->del_vqs(vdev); > > > + vdev->config->reset(vdev); > > > + kfree(vpmem); > > > > You allocated vpmem via devm_kzalloc; isn't it freed automatically on > > remove? > > > > > +} > > > + > > > +static struct virtio_driver virtio_pmem_driver = { > > > + .driver.name = KBUILD_MODNAME, > > > + .driver.owner = THIS_MODULE, > > > + .id_table = id_table, > > > + .probe = virtio_pmem_probe, > > > + .remove = virtio_pmem_remove, > > > +}; > > > + > > > +module_virtio_driver(virtio_pmem_driver); > > > +MODULE_DEVICE_TABLE(virtio, id_table); > > > +MODULE_DESCRIPTION("Virtio pmem driver"); > > > +MODULE_LICENSE("GPL"); > > > > Only looked at this from the general virtio driver angle; seems fine > > apart from some easy-to-fix issues and some personal style preference > > things. > Best regards, Pankaj