Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5128092yba; Wed, 10 Apr 2019 11:59:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqwKN7zEl4CbkDLycytsXDZ7foCKfqXWg79HMT7L0VeIfejnoZr+xaf9uhfGo62Ujxvofonv X-Received: by 2002:a62:524e:: with SMTP id g75mr44279683pfb.106.1554922776637; Wed, 10 Apr 2019 11:59:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554922776; cv=none; d=google.com; s=arc-20160816; b=BlTZw+gUNgdJ1JU2LlchB66Orlq2BrnRNfe9cmFEje8H+ceSva9JC7N/LCTjC9vTFK 7m/0L9MRD25n6ARLuh8749DM+QKPt4ENrto6/NVA5GeXUaqSShaPVcihvY7uyt29A7TH LVbhMtgRSsqZtU2g1ksQwzqg9/iuvijc5Hc+z9tCYhIuS8PUxPLdnnYJENUdGNDYb9ex HhRVcQ6O/QkxJhP2A9Q+C76LMpEHZ9NyETYvElBGEeKwetE/DXUOPCfsRNuI3g7+h7/P iwjjfFoJAzrcCXMC16LTV7Z/7NGLYe4GQ97h1hZEtttYF24lwTFMiIhaegvHT6gBUnpi 36FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:openpgp:from:references:cc:to :subject; bh=2i6JQAfJnt4azyXefCZcEkP3T3QxCg03XVmuDZyjrt8=; b=DAJr2Fs2eNnFTgsVJKIPz1YxzW0DedGAA5oTTniSbQ35YcfonP9KYUetaV7urLsbZc vEwwEZdsMn0j+ISdoxIBogQYiO2jNW0PxAVcX62vidqCrcfuO3xZDLDDeOONq4vIgiHe kLyrwaKTpdUtVdEvmVcLIUd0cEWtngQaCmrvjp7gL0qeFk8rSQ+TqVJyGG/v/i4pXndT 5qeyJztWKPOBgCvUYFV9/AY8tHq0LDmSlOy+fpty5ibUnrd6i8Uc+RKHIx5FpEvx0NKK QZ9l+6rX2rCrylhhFM+YGnit3QKqRa3mfc11MkUnEV+ul3j9qF7PrH1WWEI3fDQiK1/c l5ZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v20si30267339pfa.224.2019.04.10.11.59.20; Wed, 10 Apr 2019 11:59:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731361AbfDJQLV (ORCPT + 99 others); Wed, 10 Apr 2019 12:11:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48152 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729048AbfDJQLU (ORCPT ); Wed, 10 Apr 2019 12:11:20 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8952B308FEC2; Wed, 10 Apr 2019 16:11:20 +0000 (UTC) Received: from llong.remote.csb (ovpn-120-189.rdu2.redhat.com [10.10.120.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6490219C7B; Wed, 10 Apr 2019 16:11:19 +0000 (UTC) Subject: Re: [PATCH v2] cpuset: restore sanity to cpuset_cpus_allowed_fallback() To: Joel Savitz , linux-kernel@vger.kernel.org Cc: Phil Auld , Tejun Heo , Li Zefan , cgroups@vger.kernel.org References: <20190409204003.6428-1-jsavitz@redhat.com> From: Waiman Long Openpgp: preference=signencrypt Autocrypt: addr=longman@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFgsZGsBEAC3l/RVYISY3M0SznCZOv8aWc/bsAgif1H8h0WPDrHnwt1jfFTB26EzhRea XQKAJiZbjnTotxXq1JVaWxJcNJL7crruYeFdv7WUJqJzFgHnNM/upZuGsDIJHyqBHWK5X9ZO jRyfqV/i3Ll7VIZobcRLbTfEJgyLTAHn2Ipcpt8mRg2cck2sC9+RMi45Epweu7pKjfrF8JUY r71uif2ThpN8vGpn+FKbERFt4hW2dV/3awVckxxHXNrQYIB3I/G6mUdEZ9yrVrAfLw5M3fVU CRnC6fbroC6/ztD40lyTQWbCqGERVEwHFYYoxrcGa8AzMXN9CN7bleHmKZrGxDFWbg4877zX 0YaLRypme4K0ULbnNVRQcSZ9UalTvAzjpyWnlnXCLnFjzhV7qsjozloLTkZjyHimSc3yllH7 VvP/lGHnqUk7xDymgRHNNn0wWPuOpR97J/r7V1mSMZlni/FVTQTRu87aQRYu3nKhcNJ47TGY evz/U0ltaZEU41t7WGBnC7RlxYtdXziEn5fC8b1JfqiP0OJVQfdIMVIbEw1turVouTovUA39 Qqa6Pd1oYTw+Bdm1tkx7di73qB3x4pJoC8ZRfEmPqSpmu42sijWSBUgYJwsziTW2SBi4hRjU h/Tm0NuU1/R1bgv/EzoXjgOM4ZlSu6Pv7ICpELdWSrvkXJIuIwARAQABzR9Mb25nbWFuIExv bmcgPGxsb25nQHJlZGhhdC5jb20+wsF/BBMBAgApBQJYLGRrAhsjBQkJZgGABwsJCAcDAgEG FQgCCQoLBBYCAwECHgECF4AACgkQbjBXZE7vHeYwBA//ZYxi4I/4KVrqc6oodVfwPnOVxvyY oKZGPXZXAa3swtPGmRFc8kGyIMZpVTqGJYGD9ZDezxpWIkVQDnKM9zw/qGarUVKzElGHcuFN ddtwX64yxDhA+3Og8MTy8+8ZucM4oNsbM9Dx171bFnHjWSka8o6qhK5siBAf9WXcPNogUk4S fMNYKxexcUayv750GK5E8RouG0DrjtIMYVJwu+p3X1bRHHDoieVfE1i380YydPd7mXa7FrRl 7unTlrxUyJSiBc83HgKCdFC8+ggmRVisbs+1clMsK++ehz08dmGlbQD8Fv2VK5KR2+QXYLU0 rRQjXk/gJ8wcMasuUcywnj8dqqO3kIS1EfshrfR/xCNSREcv2fwHvfJjprpoE9tiL1qP7Jrq 4tUYazErOEQJcE8Qm3fioh40w8YrGGYEGNA4do/jaHXm1iB9rShXE2jnmy3ttdAh3M8W2OMK 4B/Rlr+Awr2NlVdvEF7iL70kO+aZeOu20Lq6mx4Kvq/WyjZg8g+vYGCExZ7sd8xpncBSl7b3 99AIyT55HaJjrs5F3Rl8dAklaDyzXviwcxs+gSYvRCr6AMzevmfWbAILN9i1ZkfbnqVdpaag QmWlmPuKzqKhJP+OMYSgYnpd/vu5FBbc+eXpuhydKqtUVOWjtp5hAERNnSpD87i1TilshFQm TFxHDzbOwU0EWCxkawEQALAcdzzKsZbcdSi1kgjfce9AMjyxkkZxcGc6Rhwvt78d66qIFK9D Y9wfcZBpuFY/AcKEqjTo4FZ5LCa7/dXNwOXOdB1Jfp54OFUqiYUJFymFKInHQYlmoES9EJEU yy+2ipzy5yGbLh3ZqAXyZCTmUKBU7oz/waN7ynEP0S0DqdWgJnpEiFjFN4/ovf9uveUnjzB6 lzd0BDckLU4dL7aqe2ROIHyG3zaBMuPo66pN3njEr7IcyAL6aK/IyRrwLXoxLMQW7YQmFPSw drATP3WO0x8UGaXlGMVcaeUBMJlqTyN4Swr2BbqBcEGAMPjFCm6MjAPv68h5hEoB9zvIg+fq M1/Gs4D8H8kUjOEOYtmVQ5RZQschPJle95BzNwE3Y48ZH5zewgU7ByVJKSgJ9HDhwX8Ryuia 79r86qZeFjXOUXZjjWdFDKl5vaiRbNWCpuSG1R1Tm8o/rd2NZ6l8LgcK9UcpWorrPknbE/pm MUeZ2d3ss5G5Vbb0bYVFRtYQiCCfHAQHO6uNtA9IztkuMpMRQDUiDoApHwYUY5Dqasu4ZDJk bZ8lC6qc2NXauOWMDw43z9He7k6LnYm/evcD+0+YebxNsorEiWDgIW8Q/E+h6RMS9kW3Rv1N qd2nFfiC8+p9I/KLcbV33tMhF1+dOgyiL4bcYeR351pnyXBPA66ldNWvABEBAAHCwWUEGAEC AA8FAlgsZGsCGwwFCQlmAYAACgkQbjBXZE7vHeYxSQ/+PnnPrOkKHDHQew8Pq9w2RAOO8gMg 9Ty4L54CsTf21Mqc6GXj6LN3WbQta7CVA0bKeq0+WnmsZ9jkTNh8lJp0/RnZkSUsDT9Tza9r GB0svZnBJMFJgSMfmwa3cBttCh+vqDV3ZIVSG54nPmGfUQMFPlDHccjWIvTvyY3a9SLeamaR jOGye8MQAlAD40fTWK2no6L1b8abGtziTkNh68zfu3wjQkXk4kA4zHroE61PpS3oMD4AyI9L 7A4Zv0Cvs2MhYQ4Qbbmafr+NOhzuunm5CoaRi+762+c508TqgRqH8W1htZCzab0pXHRfywtv 0P+BMT7vN2uMBdhr8c0b/hoGqBTenOmFt71tAyyGcPgI3f7DUxy+cv3GzenWjrvf3uFpxYx4 yFQkUcu06wa61nCdxXU/BWFItryAGGdh2fFXnIYP8NZfdA+zmpymJXDQeMsAEHS0BLTVQ3+M 7W5Ak8p9V+bFMtteBgoM23bskH6mgOAw6Cj/USW4cAJ8b++9zE0/4Bv4iaY5bcsL+h7TqQBH Lk1eByJeVooUa/mqa2UdVJalc8B9NrAnLiyRsg72Nurwzvknv7anSgIkL+doXDaG21DgCYTD wGA5uquIgb8p3/ENgYpDPrsZ72CxVC2NEJjJwwnRBStjJOGQX4lV1uhN1XsZjBbRHdKF2W9g weim8xU= Organization: Red Hat Message-ID: <50099ef3-ae62-2ed0-1294-2df3475c299d@redhat.com> Date: Wed, 10 Apr 2019 12:11:18 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190409204003.6428-1-jsavitz@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 10 Apr 2019 16:11:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/09/2019 04:40 PM, Joel Savitz wrote: > If a process is limited by taskset (i.e. cpuset) to only be allowed to > run on cpu N, and then cpu N is offlined via hotplug, the process will > be assigned the current value of its cpuset cgroup's effective_cpus field > in a call to do_set_cpus_allowed() in cpuset_cpus_allowed_fallback(). > This argument's value does not makes sense for this case, because > task_cs(tsk)->effective_cpus is modified by cpuset_hotplug_workfn() > to reflect the new value of cpu_active_mask after cpu N is removed from > the mask. While this may make sense for the cgroup affinity mask, it > does not make sense on a per-task basis, as a task that was previously > limited to only be run on cpu N will be limited to every cpu _except_ for > cpu N after it is offlined/onlined via hotplug. > > Pre-patch behavior: > > $ grep Cpus /proc/$$/status > Cpus_allowed: ff > Cpus_allowed_list: 0-7 > > $ taskset -p 4 $$ > pid 19202's current affinity mask: f > pid 19202's new affinity mask: 4 > > $ grep Cpus /proc/self/status > Cpus_allowed: 04 > Cpus_allowed_list: 2 > > # echo off > /sys/devices/system/cpu/cpu2/online > $ grep Cpus /proc/$$/status > Cpus_allowed: 0b > Cpus_allowed_list: 0-1,3 > > # echo on > /sys/devices/system/cpu/cpu2/online > $ grep Cpus /proc/$$/status > Cpus_allowed: 0b > Cpus_allowed_list: 0-1,3 > > On a patched system, the final grep produces the following > output instead: > > $ grep Cpus /proc/$$/status > Cpus_allowed: ff > Cpus_allowed_list: 0-7 > > This patch changes the above behavior by instead resetting the mask to > task_cs(tsk)->cpus_allowed by default, and cpu_possible mask in legacy > mode. > > This fallback mechanism is only triggered if _every_ other valid avenue > has been traveled, and it is the last resort before calling BUG(). > > Signed-off-by: Joel Savitz > --- > kernel/cgroup/cpuset.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index 4834c4214e9c..6c9deb2cc687 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -3255,10 +3255,23 @@ void cpuset_cpus_allowed(struct task_struct *tsk, struct cpumask *pmask) > spin_unlock_irqrestore(&callback_lock, flags); > } > > +/** > + * cpuset_cpus_allowed_fallback - final fallback before complete catastrophe. > + * @tsk: pointer to task_struct with which the scheduler is struggling > + * > + * Description: In the case that the scheduler cannot find an allowed cpu in > + * tsk->cpus_allowed, we fall back to task_cs(tsk)->cpus_allowed. In legacy > + * mode however, this value is the same as task_cs(tsk)->effective_cpus, > + * which will not contain a sane cpumask during cases such as cpu hotplugging. > + * This is the absolute last resort for the scheduler and it is only used if > + * _every_ other avenue has been traveled. > + **/ > + > void cpuset_cpus_allowed_fallback(struct task_struct *tsk) > { > rcu_read_lock(); > - do_set_cpus_allowed(tsk, task_cs(tsk)->effective_cpus); > + do_set_cpus_allowed(tsk, is_in_v2_mode() ? > + task_cs(tsk)->cpus_allowed : cpu_possible_mask); > rcu_read_unlock(); > > /* Acked-by: Waiman Long