Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove
 omap_dm_timer_set_load_start
To:     Tony Lindgren <tony@atomide.com>,
        Ladislav Michl <ladis@linux-mips.org>
Cc:     Nathan Chancellor <natechancellor@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org, YueHaibing <yuehaibing@huawei.com>,
        Keerthy <j-keerthy@ti.com>
References: <20190327050126.12064-1-natechancellor@gmail.com>
 <20190327081142.GA11034@lenoch> <20190404141730.GE49658@atomide.com>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
Message-ID: <6defcea8-1e94-14ac-f9c5-e14c61ea4d99@linaro.org>
Date:   Wed, 10 Apr 2019 19:01:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190404141730.GE49658@atomide.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Tony,

can you ask for an acked-by before pulling a patch in your tree?


On 04/04/2019 16:17, Tony Lindgren wrote:
> * Ladislav Michl <ladis@linux-mips.org> [190327 08:12]:
>> Hello Nathan,
>>
>> On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote:
>>> Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
>>> omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start
>>> static because its prototype was not defined in a header. Unfortunately,
>>> this causes a build warning on multi_v7_defconfig because this function
>>> is not used anywhere in this translation unit:
>>>
>>> drivers/clocksource/timer-ti-dm.c:589:12: error: unused function
>>> 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]
>>>
>>> In fact, omap_dm_timer_set_load_start hasn't been used anywhere since
>>> commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the
>>> prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
>>> Make unexported functions static"), which is probably where this should
>>> have happened.
>>
>> Alternatively you might want to look at "clocksource: timer-ti-dm: Add event
>> capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of
>> function being removed here). It is a part of an attempt to add event capture
>> for OMAP. Of course I would like this functionality to be implemented, but
>> as I do not have a time to continue, I cannot really object removing this
>> function.
>>
>> Just in case you'd be interested in finishing this task ;-)
> 
> Well seems like no other takers :) We can always find the missing
> function in git history when needed, so I suggest we apply this.
> 
> Adding Keerthy to Cc as he just posted a similar patch.
> 
> Regards,
> 
> Tony
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog