Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5136333yba; Wed, 10 Apr 2019 12:09:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxtMp2w6vUP06fVNbFSWbngwACLqAvPpltkOGVyll2DLXjHZgGKQS7gejPjITKsupJHVqcd X-Received: by 2002:a63:dc50:: with SMTP id f16mr42404960pgj.396.1554923374731; Wed, 10 Apr 2019 12:09:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554923374; cv=none; d=google.com; s=arc-20160816; b=Ly1rnqjTK6DYtbxa3z7zPvVp07iNmL/GuveQKMeujt0BXMT0VJ+aJa1TEQmnziQGF6 P6vDWKPhQjZuypsMPKUptB9lHk1jCeo0TT3cB/ONGQ5oScJPMcG0nGmXjPmWVVjQCony JxBjoZnR3C0pQiJm1pb5M12kXPLaniyvbdjFm7kCdcMAFO5++vTItpyqtojFN/R/cl6Q R2xE4wxsmfladXXu7lF4rPRk7MZv/tXFN7vheyodWVb2QkXBR7GKcPOy6Qi/jT6wcYSv t/Hd2tyc924+1cFQHi62ZrKWojTwIcT5hJ18Qx0ylVEXhwTWwCrSd8orMHJg8rSiEMmB dJBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=BfbaaiXHZN6UJr+RjXOEU+oiazV3hLAf19xreHTSUe8=; b=gle1ER8t0PHCgSAdeLmlB4EhNoFoCwhrRTnD6Pfyp01seAYPjYupoBQXz0jB4Pq5H6 4qarBuG3xCoOFkMJbeqo75NugvyIiRJeWCLY0tgBlCqybYEXhzkeBknW+RPoGmYxSpyy 096GftStESlfgLUtCAE+2Y2I+UZ3yqumwVGAKjw0CS8LRwZFAzIJx9n6eg/ImMwlvsRH d4RCcfzGSrvRpr3Jt0CLV7RK+KESRvFJc7liVZa79GHwz/rJssDKKc96glxD1+g+RwC/ 6eE56av16LL1Tm14agSdEOu39RAIxyqSL/z0FL1y0jjB0DROn+tjxNSzojeVLB2bOyKh OWFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=j7Wuoud1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u30si34969345pfl.23.2019.04.10.12.09.18; Wed, 10 Apr 2019 12:09:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=j7Wuoud1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730116AbfDJSRV (ORCPT + 99 others); Wed, 10 Apr 2019 14:17:21 -0400 Received: from mail-pg1-f182.google.com ([209.85.215.182]:35574 "EHLO mail-pg1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729205AbfDJSRU (ORCPT ); Wed, 10 Apr 2019 14:17:20 -0400 Received: by mail-pg1-f182.google.com with SMTP id g8so2046947pgf.2 for ; Wed, 10 Apr 2019 11:17:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BfbaaiXHZN6UJr+RjXOEU+oiazV3hLAf19xreHTSUe8=; b=j7Wuoud1m5nSUcRDLWuzK67TYk8bTttA8o1bgZG/Bf7HN0U2IQqTgDgzXCU+3bV1VJ 93mbvAH7i2AN0fuNU4ivPeU9k2blSToQtTphs8Gxhfgs3XcAjOymSKJVlXsV/R+FFkXp JFWDKcdchk6nweaI9slGE70BDctyvRnCkdwe7/CxxVThxmSL5lVYlNYB/8VoxRxMPz30 MFFTgS4quUp9Z8vUZ0XrHLY+Klc56VDQSm1LspU3Kbgwr4Vn84PDMiHJumSiCXjBMg/n zZYzvL71/pCsxKsQ/VaRvB0U+RwM96XLLqOaO55HnJjT0qZ3UQY/YWnb35wfux0sT1Ko l9ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BfbaaiXHZN6UJr+RjXOEU+oiazV3hLAf19xreHTSUe8=; b=aeuGulv/5IH+gwoTbgYfMDReAx2SGYZpmuqYtXM4lZN+B3GO6YUgE5nKWbcIpO8FCB Y1FRRCUg6jck3EI/Kft36EAXjNtaQ6FsMeSLWNa0BoO3P9UfRaJOJXPsF2ylm1t3hJqO erU5hW36B1RWVhotjXGWMuerklezqNuAuPscHkkN+Sk5SEOUXLrgnxjTe/gNpnVKJFKI EwegjWfc3xGWQgoWKTaGMVB39rf9OxGZdu6TR8G4vQCAjosqzZptJA5cozfrKz0n166J iBv4KqlXush5jlvwETYRP9H8XVACzKa8lWt3UjodEK1jQwP6qWw5eAbNr/+DOCTz9gWa gcrQ== X-Gm-Message-State: APjAAAWgph8Mn9NoFj85KL+3VLf+IAA+U0eHm1/1azOYpUVXRzKEoKTG x2hfvs9L03SFvPSMd2OHNOXsyXiom9gYUw== X-Received: by 2002:a63:4f52:: with SMTP id p18mr41972003pgl.333.1554920239816; Wed, 10 Apr 2019 11:17:19 -0700 (PDT) Received: from [192.168.1.121] (66.29.188.166.static.utbb.net. [66.29.188.166]) by smtp.gmail.com with ESMTPSA id b26sm69307872pgn.4.2019.04.10.11.17.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 11:17:18 -0700 (PDT) Subject: Re: [GIT PULL] lightnvm: pblk: fix crash in pblk_end_partial_read due to multipage bvecs To: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Holmberg References: <20190410175643.11000-1-mb@lightnvm.io> From: Jens Axboe Message-ID: <09b7919d-2ae3-eded-0abb-472c7f642c4d@kernel.dk> Date: Wed, 10 Apr 2019 12:17:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190410175643.11000-1-mb@lightnvm.io> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/10/19 11:56 AM, Matias Bjørling wrote: > From: Hans Holmberg > > The introduction of multipage bio vectors broke pblk's partial read > logic due to it not being prepared for multipage bio vectors. > > Use bio vector iterators instead of direct bio vector indexing. Applied, thanks. -- Jens Axboe