Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5162345yba; Wed, 10 Apr 2019 12:46:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqwRcgMeVWtCYtHApupugmoJSf1evuIQG/25xK7wuPFNf7abPGj40QPLigZKr9mSIUCcJcOg X-Received: by 2002:a17:902:703:: with SMTP id 3mr46269313pli.224.1554925560994; Wed, 10 Apr 2019 12:46:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554925560; cv=none; d=google.com; s=arc-20160816; b=UctNAx6vr/OG/ryKpUXD4f4kyKVdt1+wlA2EYE4DJS5v4/VChSXbtmvVH1PEVma/Oc 687XN/6wKFpWVJ1DIcK7nRY1/5F0ZCigOycr9t4DviHoNP/VfeTqZoQ/0+LHW0NZJzLP 24yfR8oHFH8f+qMEUh7TkKwHQCsHeyRx5+5vtAHmMTe+ekZFSIb9V4xaFRzfISjnuzpJ Hw7UoMZAc3XTJcrCN2rQapInGrcfdreFux9OB7Afv8x+P64qcb8WmNwgv9u2VSP0GmRM hw5tUh8yGI7S49CiNb388iH1PdhO2M4X99ejVhlBb3M8NchUJINWav/05B3kIpw8JZ6P t9Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=rsBa5M7cr66bNr57pCqY9xnSx/YPJHTWLIyNqQt1HX0=; b=Lswrdfjekc5VWe6bo1psJS3t3ceN1cD4EhI7D70KEm5iSJB2hLrwtYROvyYZE5Zr5n g8Vog34Q+W0GhaBIegHIg8dtymrcn18LrV2KI6rbZ/lHkvaPNh45/mkAyQQYhkUVcXqK mUXyS4uC6khWZfFKu4oYgKgEds7qX0P5ghhCRsXI8kRL5p9G+s145lK0aw43eekJ4gLS 538DCvkoGQ6KP7NhOtUluUkRrqQ0GSVXtvWlUDGMn8hzF3umXF7a9PuFZY7ZrEPky9C/ N1BqUmL3VejuO5SM5dYO2+KjWh6rXscHsxlvUYZ+Ec6iXCwOrNCnYBIjz4a51ZibrEX0 HofA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=Obu0iH5z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p6si24976382pfd.19.2019.04.10.12.45.44; Wed, 10 Apr 2019 12:46:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=Obu0iH5z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726678AbfDJTpC (ORCPT + 99 others); Wed, 10 Apr 2019 15:45:02 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:44207 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726548AbfDJTpB (ORCPT ); Wed, 10 Apr 2019 15:45:01 -0400 Received: by mail-lj1-f193.google.com with SMTP id h16so3223172ljg.11 for ; Wed, 10 Apr 2019 12:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rsBa5M7cr66bNr57pCqY9xnSx/YPJHTWLIyNqQt1HX0=; b=Obu0iH5zZYljx26kyd08C8+DLbYm44jLQE7W5yMnS8jj8F8d118hGNeonhA2WrNRyk 6FYPs+HiiL2UnpuK6OuEY8sb7YHQn6hrzVOg/OinGsYpE9qBNhzVqAeFbZOEbGs45kec kR3KgV93LJvr94gdAxbsQcYz29BIGyUmb8Mdk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rsBa5M7cr66bNr57pCqY9xnSx/YPJHTWLIyNqQt1HX0=; b=ks8qQ9BJlFIa4L47nUXXmTbkOHrBQ9gXzeOaqXwiU/BlHflk/RlrCvPAHl4YsgNYhM yo8Z40k222z1IBqy3Qh3cACBqKDRfxikWN/+w8PU93YNRflTkDZi4kN9EObn2o8Cf2VY E3vPYEJXXK9F3Jxq7AVq/w2DHhD1sEohbrllV81d5OvQV6YkWWLz+FJZyrYr5FNWa1Dq 5FPc/x+RIJUG644JNe6FOWZA224TpU+AVn+eSqWrdNhdbMMy62hRkn40R3xLhLpgsE/R k/PCYtscyyIuh2/xdFpipOJ9xpAzmLJEJkSN5pXP9Vww90qqEB7F7HWycwr2wLuoUczj 7buA== X-Gm-Message-State: APjAAAU0gWy0btlO80CpTw/ipsMmRKOg1CDAclsVj3RTtp/lFWSCYml+ lDwYwUGrsdTIeBsJ5hZ6KP5oUjOHD20= X-Received: by 2002:a2e:90c9:: with SMTP id o9mr25467288ljg.102.1554925499057; Wed, 10 Apr 2019 12:44:59 -0700 (PDT) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com. [209.85.208.180]) by smtp.gmail.com with ESMTPSA id e18sm7400121ljb.12.2019.04.10.12.44.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 12:44:57 -0700 (PDT) Received: by mail-lj1-f180.google.com with SMTP id k8so3239528lja.8 for ; Wed, 10 Apr 2019 12:44:57 -0700 (PDT) X-Received: by 2002:a2e:9597:: with SMTP id w23mr18295781ljh.111.1554925497426; Wed, 10 Apr 2019 12:44:57 -0700 (PDT) MIME-Version: 1.0 References: <0000000000006946d2057bbd0eef@google.com> <20190325045744.GK2217@ZenIV.linux.org.uk> <20190325211405.GP2217@ZenIV.linux.org.uk> <20190325233731.GS2217@ZenIV.linux.org.uk> <20190326014552.GY2217@ZenIV.linux.org.uk> <20190410181135.GA32071@ZenIV.linux.org.uk> In-Reply-To: <20190410181135.GA32071@ZenIV.linux.org.uk> From: Linus Torvalds Date: Wed, 10 Apr 2019 09:44:41 -1000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: KASAN: use-after-free Read in path_lookupat To: Al Viro Cc: syzbot , Alexei Starovoitov , Daniel Borkmann , linux-fsdevel , Linux List Kernel Mailing , syzkaller-bugs , James Morris , linux-security-module@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 10, 2019 at 8:11 AM Al Viro wrote: > > Both are in vfs.git#fixes. Which way should that go - directly or > via linux-security.git? Just do it directly. I doubt you can trigger them for securityfs and apparmourfs, since normal users have no way to remove any files from them, so the race with final unlink sounds fairly irrelevant in practice, no? Linus