Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5165635yba; Wed, 10 Apr 2019 12:51:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqxnQ7l1gNSktlcgzO1pNbL7V0TEWXlI2P1ubYcExUUK3xSGQHGvqU4Q3avWCvugP5jehLX2 X-Received: by 2002:a17:902:aa91:: with SMTP id d17mr46456309plr.43.1554925882227; Wed, 10 Apr 2019 12:51:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554925882; cv=none; d=google.com; s=arc-20160816; b=WgJzXVzYiFGoqP5ctPmO+QAE4NPwAie294av61aYWsnGcLs08cgYXmwowRfx0bmf6l BB9ScqYPjJnuXuWBDsIVzf1Xtb/WcRWU/EL2A8cJ1AeJhT1+SRegz2foknKEs6Ps5nFt 6FHgKyIeVFa0A4UrZjifvEKTudI5X577/VbOGG4xNeWe2E4ksYJ//sxSjqTLWqMGHiS8 i66G228zfBLx+wzVkwbH53PTLbxors/CrTuzL5uhARm3f82hUD91nZ95VfgwgJKVa15w BPldhI/OJeF4udmtPIriWjEEB0StQxfdbLUBJ+hSNuQ6JKZKjBvRdVmf7Ssj6Ne+pdlK 89bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date:dkim-signature; bh=xmlYEM+J/2cMmGlthhnUTjy2DiLN1af1AGnHmddTDaU=; b=hGx21ZxcJ8s3YSi3+tQ20/NNUu90w2DbWLTIatGMm5h1uJmL1WTc0zO5BWt/QUsb0T dhkr7NHAv+WmS9rGixF+F+D4ZE1mgLCxvaP5BE8TJk2DewJzzYoNqM23Esh7YKkb4xef bhrUs22UVrFU/qq0OpHryRJl71BsWz001X0EmVfID+En7xHprd86FeP6QWWJokT159W9 upCwXI+UUuhR9cBikPEl/SfperbKgEbWt8PCZuNOBc6rM0nFftVfmBYZzxT8FvZAskvC R9woNqeiJHWNBXabqw/ZE7o59bssMBlcwQGj3zQmwtHlAyBGTBkGNAxjtthAfcXNTs9+ oI2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HtxRfT3R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u30si35040234pfl.23.2019.04.10.12.51.06; Wed, 10 Apr 2019 12:51:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HtxRfT3R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726562AbfDJTtN (ORCPT + 99 others); Wed, 10 Apr 2019 15:49:13 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:41968 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbfDJTtN (ORCPT ); Wed, 10 Apr 2019 15:49:13 -0400 Received: by mail-oi1-f195.google.com with SMTP id v7so2840335oie.8 for ; Wed, 10 Apr 2019 12:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xmlYEM+J/2cMmGlthhnUTjy2DiLN1af1AGnHmddTDaU=; b=HtxRfT3RNOpEPUkxV6+jcJxpfRjTPbIMBmrhjy5t6j7nK3J+rd91vIIe1Rwcu0aWsT p81b0zvdga2VmnM6S9NVkB+QDtFcjFgzvRKx+jtkmOiRVpCKtPQSZkTDSD5/EG31iBvf aCsZi0JA/TEvji9y+SFuYtqLe1dD1uvv3KeUZhIhsnP8JTbxgCHF3saZZur+UkZayjiM zdx67u4B8RH8jO5pqA3PLlymN70HmWUjDESmHNPz3igIYYVJKTVtk+ksWjb0bdtVJQa5 wArSQQmKIqDv4rynw6aSMD29j/tV+6KvTIy7zgeLJCZxOzQIOcFxiTiNsMT5Bbzoqbs2 Gyrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xmlYEM+J/2cMmGlthhnUTjy2DiLN1af1AGnHmddTDaU=; b=unKstWIXWI5DvjBLgplI4hsASLULjIXfvJf1K3OVl1s5X9ivLGWFIbqWaMd2u/CHPb AnRun6fN2lTIzhlV2T5KGXaYqJDdo9jzcjiX4Pzy0GEeLIyLq0bg8XtIWM8gim0hNIwd xCWCUZ9GuIyxIxkWE5XD4Pt9G+YCUPSoxblQmRtu63+BpdXR+eHfMDKgN8ZDe8/gknlU Z+QN1idv3N2DHCDqOj0SbqjWtTjHSzVhR/fPqNRwzmVPYGyJyBfBb7SleYO1+ThPzYOV uLeM+7BGTg1J2uk8XJgM3DP7Qq2FrnE0RMdpPvaocFS3yFTlnJgzHovdDcmkCKKS4vTE 8eYg== X-Gm-Message-State: APjAAAX274lg+AUpKFSTqcB6RIWB0KbAa/K8ns5AIpcgOQXITb2UbYXK V+W//k4DS366B3i7jRtdYhI= X-Received: by 2002:aca:abce:: with SMTP id u197mr3815635oie.67.1554925752408; Wed, 10 Apr 2019 12:49:12 -0700 (PDT) Received: from madhuleo ([2605:6000:1023:606d:94ff:e494:a926:8d07]) by smtp.gmail.com with ESMTPSA id m22sm8076677otq.47.2019.04.10.12.49.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Apr 2019 12:49:11 -0700 (PDT) Date: Wed, 10 Apr 2019 14:49:09 -0500 From: Madhumthia Prabakaran To: Dan Carpenter , gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data Message-ID: <20190410194908.GA13242@madhuleo> References: <20190409161617.29871-1-madhumithabiw@gmail.com> <20190410064954.GE6095@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190410064954.GE6095@kadam> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote: > On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote: > > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h > > index bafb2c30e7fb..b0623c936940 100644 > > --- a/drivers/staging/rtl8723bs/include/drv_types.h > > +++ b/drivers/staging/rtl8723bs/include/drv_types.h > > @@ -220,7 +220,7 @@ struct registry_priv > > #define BSSID_SZ(field) sizeof(((struct wlan_bssid_ex *) 0)->field) > > > > #include > > -#define INTF_DATA SDIO_DATA > > +#define INTF_DATA struct sdio_data > > > > Just get rid of INTF_DATA data as well. It's only used once a bit lower > in the file. (Get rid of the ifdef around it). But, reference of INTF_DATA is also included in file ./drivers/staging/rtl8723bs/include/drv_types.h:487: return &dvobj->intf_data.func->dev; thanks for the review madhumitha > > regards, > dan carpenter > > >