Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5175366yba; Wed, 10 Apr 2019 13:05:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqylz/RD1veJSDn40HdOdg70/uANQTy20SHLYonzeHZd01c6NBhptVmlI5yvhJ/PAipjBper X-Received: by 2002:a17:902:54c:: with SMTP id 70mr14901950plf.210.1554926719548; Wed, 10 Apr 2019 13:05:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554926719; cv=none; d=google.com; s=arc-20160816; b=yOtaj1N37RToDjnC3H0o1ey2dlO/ukfwemRulYCyD8H3y5vL8nLglkgX0zlOHM3RWs 3aCP2NGd70WlfMgIQOHw/lFmql0GjNTXsb3x5QrzxxRBSiTveqLPbcBnSS5hskDbJdHB Ct9dgG/8O6d++XqeeQ0N3YRTfUjIEWq7Hc2DB2hAjNRfsCGiDxHyYfw5g0xPZb8sxbmR aC2BhrkGA301gfKCzTLkc6JaWLi6c2YdCOU2yTAdhBU6neZJdiB0DU+NHyOd1M69Hy8J haQXn4ir9xgafepqZIwveD6i275Pa9ZPzVyjDhMLHTBNbxmJqRWpHkE1kgkS353voUOH 1ueQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=UiwWceHvbke+Yaj4yVTQMNIDb++qNBrOt5TLHhjPT/k=; b=Dtxmz56o6Ous0uC6lPBO9Co2JP3uNBOsQf5XAHV/oHcSnz0Gk1chZb6S/pjuqeY/E2 MUrJQ87+UyuCdDwj/lUk5YDkBFUge9D67zOrSzj54nb6TWPSv3ujtTu7RYifXKzhGhMr 5Ux0vEnGHrFjEqKgRFqtfFkJs8U2bXwJWVH61UKnBBWwakDwQKV6cW4HXKlJFPRupvPK Oav3a2PKCCRAwQ/kS2hujYTBePm4KM8lLla4hahrhzT2eRF0lv7CQQ4ovhikQup/D7G0 CDsYu6iNbuZgJm5tekde7Tm278cYC+iCry6ICciLuTmhiwmMiD7NA3DQ3OFpgbi4yGow VI5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=QmAL3kq7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x13si32694941pll.96.2019.04.10.13.05.02; Wed, 10 Apr 2019 13:05:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=QmAL3kq7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726548AbfDJUE2 (ORCPT + 99 others); Wed, 10 Apr 2019 16:04:28 -0400 Received: from mail.skyhub.de ([5.9.137.197]:36624 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbfDJUE1 (ORCPT ); Wed, 10 Apr 2019 16:04:27 -0400 Received: from zn.tnic (p200300EC2F0CAE0088EC372D30EF1627.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:ae00:88ec:372d:30ef:1627]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 58E401EC0301; Wed, 10 Apr 2019 22:04:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1554926666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=UiwWceHvbke+Yaj4yVTQMNIDb++qNBrOt5TLHhjPT/k=; b=QmAL3kq7LH5T8Xog6gx2DavBoRdBG72vsplvN2/Hc0W1q6w8rRNJqiA9cdPIj3qTSHv/1g PgAsEworR5rgTJqg97qrOKUsSCnhnwrX0mWYYogSm/bh5q49rjGXQY/SexbgdnXbyE71kA MIwlEd9+7lPvWRhZqBU4VhQvnaH9VfE= Date: Wed, 10 Apr 2019 22:04:18 +0200 From: Borislav Petkov To: "Ghannam, Yazen" Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tony.luck@intel.com" , "x86@kernel.org" Subject: Re: [PATCH RESEND 2/5] x86/MCE: Handle MCA controls in a per_cpu way Message-ID: <20190410200418.GI26580@zn.tnic> References: <20190408141205.12376-1-Yazen.Ghannam@amd.com> <20190408141205.12376-3-Yazen.Ghannam@amd.com> <20190408175142.GK15689@zn.tnic> <20190409203412.GE6150@zn.tnic> <20190410164036.GC26580@zn.tnic> <20190410172539.GF26580@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 10, 2019 at 07:41:47PM +0000, Ghannam, Yazen wrote: > So I'm thinking to add another patch to the set. This will set > mce_bank.init=0 if we read MCA_CTL=0 from the hardware. Ok. > Then we check if mce_bank.init=0 in the set/show functions and give a > message if the bank is not used. Nah, not a message. return -ENODEV or -EINVAL or so. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.