Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 11 Apr 2019 08:00:43 +1000 (AEST)
From:   James Morris <jmorris@namei.org>
To:     Al Viro <viro@zeniv.linux.org.uk>
cc:     Kangjie Lu <kjlu@umn.edu>, pakki001@umn.edu,
        "Serge E. Hallyn" <serge@hallyn.com>,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] security: inode: fix a missing check for
 securityfs_create_file
In-Reply-To: <20190410180156.GZ2217@ZenIV.linux.org.uk>
Message-ID: <alpine.LRH.2.21.1904110800260.5714@namei.org>
References: <alpine.LRH.2.21.1903160608080.2905@namei.org> <20190315210025.17832-1-kjlu@umn.edu> <alpine.LRH.2.21.1904110334380.25754@namei.org> <20190410180156.GZ2217@ZenIV.linux.org.uk>
User-Agent: Alpine 2.21 (LRH 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 10 Apr 2019, Al Viro wrote:

> Rather bad way to do it - generally, register_filesystem() should be
> the last thing done by initialization.  Any modular code that
> does unregister_filesystem() on failure exit is flat-out broken;
> here it's not instantly FUBAR, but it's a bloody bad example.
> 
> What's more, why not let simple_fill_super() do it?  Just
> static int fill_super(struct super_block *sb, void *data, int silent)
> {
>         static const struct tree_descr files[] = {
> #ifdef CONFIG_SECURITY
> 		{"lsm", &lsm_ops, 0444},
> #endif
> 		{""}
> 	};
> 
> and to hell with that call of securityfs_create_file() and all its
> failure handling...

Thanks for the review.  Reverted.

-- 
James Morris
<jmorris@namei.org>