Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5256537yba; Wed, 10 Apr 2019 15:11:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqx4ZukVmnhCfC14t87jE+seHWbMtuEiRG/vP6Wi6tl1Hj7p7nBxEemeqVgAi1d0u8+iLRcI X-Received: by 2002:a63:c605:: with SMTP id w5mr40845625pgg.355.1554934263752; Wed, 10 Apr 2019 15:11:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554934263; cv=none; d=google.com; s=arc-20160816; b=yRHjy70ZBFpa0NxleTjXRhnEbAXwO2KhM8y7prjVaBRnpIQTuRBfAK3NYgpaIkJatU tGxNJHxHJoGQEEs/BkcJeWvN/BTQZx8fyrfi7IFEx4adC/GwPQRUwAEakhs8eOM+QhBG FVewdETGAtQfWt6LnQsUYJZiD2adwC6NqP+WjM19chwx3g9RzxVk/Y4FvzdgqROn8ieA bekBkOlJr2NsjXVzzTbPB1Q40fBxgCI7ukq1TF4jQvW22Eo9KvYd4VQI9aUXoRtHym/i x5oTfIt+3MHK4jYuVeX2/KAceaRLUO/7WFxAn79XqNvHtdK2uJtn3d3c8lDnUMkOWWjD +fng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=05e2FsZFCSywl50KHeYzCf32JDoK3Jibc3CsqeWBs8g=; b=fDvePcN67DFX4qJeY48OV2Fb8sYVlEeUZKgwfoUG76QQ/HW/qdFw75KDtqZ91YqASZ DX+HoaVeXyIf1djBccE2O+p2pqWRmHNxwoTUvowLmHYoBwUydc+sABP4UjQvw2ZnCGrp BO4V+K7G11zbBkGStz45lUWqhQhMXooDjDewcnCSL3nvM0lCrDTykd2krgdaves20rQe BSl4Qh1LtGhJscpeqacPzW2SxycfqDl3AbX7CIe3x9+Vi3vtEfPcyhgPtk3QoDOBm9SB teC7TSCcI6bK7ocPojGrCjj3iaXBqqHdu4RlVzKTQDRx2hmV6dmBcwP6n60l0gGTv9G7 sZBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k4si32968357pll.170.2019.04.10.15.10.48; Wed, 10 Apr 2019 15:11:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726230AbfDJWKN (ORCPT + 99 others); Wed, 10 Apr 2019 18:10:13 -0400 Received: from smtprelay0209.hostedemail.com ([216.40.44.209]:36066 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725782AbfDJWKN (ORCPT ); Wed, 10 Apr 2019 18:10:13 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id D863A100E86C6; Wed, 10 Apr 2019 22:10:11 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2110:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3867:3872:3873:3874:4321:5007:6119:7903:10004:10226:10400:10848:11232:11658:11914:12740:12760:12895:13069:13255:13311:13357:13439:14659:21080:21324:21627:30054:30091,0,RBL:23.242.196.136:@perches.com:.lbl8.mailshell.net-62.8.0.180 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:29,LUA_SUMMARY:none X-HE-Tag: coil20_1ea913ba2a849 X-Filterd-Recvd-Size: 1406 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA; Wed, 10 Apr 2019 22:10:10 +0000 (UTC) Message-ID: Subject: Re: [PATCH 18/22] watchdog: mt7621_wdt: Use 'dev' instead of dereferencing it repeatedly From: Joe Perches To: Guenter Roeck Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger Date: Wed, 10 Apr 2019 15:10:09 -0700 In-Reply-To: <20190410195409.GA29802@roeck-us.net> References: <1554913683-25454-1-git-send-email-linux@roeck-us.net> <1554913683-25454-19-git-send-email-linux@roeck-us.net> <20190410195409.GA29802@roeck-us.net> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-04-10 at 12:54 -0700, Guenter Roeck wrote: > A checkpatch rule suggesting that multiple extension lines can be merged > might be useful to help finding such situations. Just a thought. You are welcome to try to write that one. It's likely not a trivial task to make it sensible. cheers, Joe