Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     "jglisse@redhat.com" <jglisse@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Jens Axboe <axboe@kernel.dk>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] block: do not leak memory in bio_copy_user_iov()
Thread-Topic: [PATCH] block: do not leak memory in bio_copy_user_iov()
Thread-Index: AQHU79v0dlXVpXNXG0+W9MpU00wO9Q==
Date:   Wed, 10 Apr 2019 22:13:14 +0000
Message-ID: <SN6PR04MB4527191E2EC151609B6F1B23862E0@SN6PR04MB4527.namprd04.prod.outlook.com>
References: <20190410202751.20712-1-jglisse@redhat.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1939ad45-0d75-4606-1050-08d6be01ba46
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2019 22:13:14.7621
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4960
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good.=0A=
=0A=
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>=0A=
=0A=
On 04/10/2019 01:28 PM, jglisse@redhat.com wrote:=0A=
> From: J=E9r=F4me Glisse <jglisse@redhat.com>=0A=
>=0A=
> When bio_add_pc_page() fails in bio_copy_user_iov() we should free=0A=
> the page we just allocated otherwise we are leaking it.=0A=
>=0A=
> Signed-off-by: J=E9r=F4me Glisse <jglisse@redhat.com>=0A=
> Cc: Jens Axboe <axboe@kernel.dk>=0A=
> Cc: linux-block@vger.kernel.org=0A=
> Cc: Linus Torvalds <torvalds@linux-foundation.org>=0A=
> Cc: stable@vger.kernel.org=0A=
> ---=0A=
>   block/bio.c | 5 ++++-=0A=
>   1 file changed, 4 insertions(+), 1 deletion(-)=0A=
>=0A=
> diff --git a/block/bio.c b/block/bio.c=0A=
> index b64cedc7f87c..716510ecd7ff 100644=0A=
> --- a/block/bio.c=0A=
> +++ b/block/bio.c=0A=
> @@ -1298,8 +1298,11 @@ struct bio *bio_copy_user_iov(struct request_queue=
 *q,=0A=
>   			}=0A=
>   		}=0A=
>=0A=
> -		if (bio_add_pc_page(q, bio, page, bytes, offset) < bytes)=0A=
> +		if (bio_add_pc_page(q, bio, page, bytes, offset) < bytes) {=0A=
> +			if (!map_data)=0A=
> +				__free_page(page);=0A=
>   			break;=0A=
> +		}=0A=
>=0A=
>   		len -=3D bytes;=0A=
>   		offset =3D 0;=0A=
>=0A=
=0A=