Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5260347yba; Wed, 10 Apr 2019 15:16:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqwj9UOph3tRe6FFRQj8D/otx+uocSYp14ZPYYuZy/DuzdfSxX8yQIoVnTkuPudXT6+SWwKI X-Received: by 2002:a65:6108:: with SMTP id z8mr43504715pgu.106.1554934566685; Wed, 10 Apr 2019 15:16:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554934566; cv=none; d=google.com; s=arc-20160816; b=0jwtEyp4psAH01NfDe0Dt1y67pO3nfyFydUXFJsYQHvtGlf3gu6sl4NpsP4+ZR/whe gQetBdSXKsDhwW3jmmOVBdD5sSk71gqycc8EX8iAuMY19JkNveO15JjzDk78raViMB6v s2cp5yY3hpfQe7Iu74rGpRxrMQFhh2iwglx67mZpu3vOYMdj2ViC41oQmMxiFWVsGQ2n /nzzhBfDFF/S0FrMlU68owGQxsg83quJu16grnCes3GBtlVB9/au6vV56LyKuqcyTj1X 6Zk1FdKjn6WvVGnshL/lID/gr64z47sL4mOIrmp8SAj1dFjdjmiLTCpC1RLjASIZSOGm ZqXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=Wg+iQil3DoY9mwTW1mfserS3u376EbXt0yARzUcfgdw=; b=v8wGLgVMpWHh5tCg5fpCK9NUUKq1pVzTNnSPO9DHoKTtOeBHQX/VFC7/hpw/Cl/GDc Jkky7zGivtDW5wHwQasdt0QqwAHC7zu/balxO+TibfDB4jSmBjA6PG+7FwSZMwNjJWnO 2yCLIrTP/tZTfQ4knnJrpr+cUDrJm5WP09iua1lK24HJX4L0zrkyXnIkQWbVflo1VtVi HAEKKIUjGBJMM5idhs7SAjEzxyy2/vtrHSwMPApJzDDP1I589z92YOBgHwmfF9KT1RBF gu94Nkv7GOxSSz5Yt9VdU7HFCtbuq56nmZlz+sR+Fk0cK5I/U3naSG9w/DNtX60dCUh9 rERQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=tPINeHbr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g10si28290388pgq.440.2019.04.10.15.15.50; Wed, 10 Apr 2019 15:16:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=tPINeHbr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726730AbfDJWO4 (ORCPT + 99 others); Wed, 10 Apr 2019 18:14:56 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:43659 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbfDJWO4 (ORCPT ); Wed, 10 Apr 2019 18:14:56 -0400 Received: by mail-pg1-f195.google.com with SMTP id z9so2352745pgu.10 for ; Wed, 10 Apr 2019 15:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Wg+iQil3DoY9mwTW1mfserS3u376EbXt0yARzUcfgdw=; b=tPINeHbrEiszxSoR1taj3mpafE1NWS5DJ89QHSCklWKkcP2kLCHftDwO2UtHFSFNE4 OtGTXUthULRDybFp+ku6X0sQa0d178t50ANTUtV8PUAbv0a8mq2tKkf8Eb5JogSCUgFL HxzBGHng2xubXdR5Q2aKKakGAxLdOC4FctnhEw22YjdyqiR5YFKgwgH/hMpcD5cz0l9i eGhEcvmMNo9yBN2IbT8X2yAGNu+Nn0XqbWoWTcLUsPPJ4lSoJq9y3bAEhVd7Wv4Q85jr UM9xiIqlv37vgizMVuaFAUHSXlDG/G3bFNvBKH7hB2cSDYwPpM2aSXO4YTFVLw4R0jIf fgfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Wg+iQil3DoY9mwTW1mfserS3u376EbXt0yARzUcfgdw=; b=Mb5z3bqke1QdZzfI0zXj811mqCJOJ1eK/phbAko4aE8o0F2yvxzSnIZ3mVrjY6Uw4R s/zJrZk8W2sn4dObnLKrgU1zwKwwOBVuBVV+s2z9oV+pNfbGCn28i2D5RN7Z9XUZZ4KL QY8zf8kdlB/Xf4XhHI4x1rObAgoZesD3nCloZSTggDSQt2VxK0gVBTv8JOdF4vaIhABW CELp3y0qTf70UX1ZjW0bioxtdvjYCl1MwzIQjvLVEMiPEpnOPgV+IKpUHun71DuQaynI lUKt1wkb9vqcQFKv+M9IXLgkFfEM4eVPDMrFKkCP+hoWue+OfdiIM1Ckj4PDyoxdNBoN WvnA== X-Gm-Message-State: APjAAAUGGLTbHbKnPo8+VHENx0j8VV3pd/+jjaLNiLEyzCbwyYZ8X5B5 I78esZ/NfdhmnS66cMGN2BUwZw== X-Received: by 2002:a62:e80f:: with SMTP id c15mr45888215pfi.93.1554934495509; Wed, 10 Apr 2019 15:14:55 -0700 (PDT) Received: from [192.168.1.121] (66.29.188.166.static.utbb.net. [66.29.188.166]) by smtp.gmail.com with ESMTPSA id c1sm52150997pfd.114.2019.04.10.15.14.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 15:14:54 -0700 (PDT) Subject: Re: [PATCH] block: do not leak memory in bio_copy_user_iov() To: jglisse@redhat.com, linux-kernel@vger.kernel.org Cc: linux-block@vger.kernel.org, Linus Torvalds , stable@vger.kernel.org References: <20190410202751.20712-1-jglisse@redhat.com> From: Jens Axboe Message-ID: Date: Wed, 10 Apr 2019 16:14:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190410202751.20712-1-jglisse@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/10/19 2:27 PM, jglisse@redhat.com wrote: > From: Jérôme Glisse > > When bio_add_pc_page() fails in bio_copy_user_iov() we should free > the page we just allocated otherwise we are leaking it. Applied, thanks. -- Jens Axboe