Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5277891yba; Wed, 10 Apr 2019 15:44:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqw9lROauWUdefiQhi+4WjlADyBhNes31DuwZCAC/NwgkmtCAL/oqa7QgFn99Xuq6ATZhA3/ X-Received: by 2002:a17:902:24a2:: with SMTP id w31mr14201854pla.78.1554936267139; Wed, 10 Apr 2019 15:44:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554936267; cv=none; d=google.com; s=arc-20160816; b=zWHoHzpT4bxfjg1kv1gRFWEO7/NZUqHMVdXDmBRnJla8vEazriaJYhpoBA+Pv/N/yd krfWEhdXJTQKrZncApIWMAVn//Afh9fWMEyWrqUW+yZA+HFzatLhPrhWOo32dd746VYb pkGXqmXCAMzVHFqlgINF5eM1LECothpOqlO7TrpcYEOIyIv5yhy2u5RIvzhw0Tu31acq aDFxw/kiC0lf1h3lUv2lk1rtMjCeA0Y48VKjuaOpR5W8vJbwlzas/8MMCKvuWqTNdzWH 7mNRilrjqCdNZBAiB5T0XpeSOXAYXCb+lM9dJenh4HkVQGlsC2dYuhEyNC95ypTwEtX6 a6lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lQNZdIxtL7KacMTJYVuEK/mC+CPkkxl93FaIStn1K8s=; b=TBvuFl7XnCeIE2pu8ekUoBLUDuvXR5nLmdhbUkE/Th7JAkIkBbx5VIdQ/V/o8UZtWb IyWwxVDYVXwCmlPFgb7wr7sIELPI8QVKxt+A6OBpkuZdqKHRQaTeWX/unqZMx5Z8sFAZ lAlEuz7SNM5y1twJBFYA+SaFXcUr5ubsxjJciht/siAd0Zak7NADGAh1g5HeFS/VApHi rGRvRdn6uuEYVoEGsk3F1y3m7AX2yKBOxS22N3W1edfp55qWBNIVsjm3ZQgbL4noV5ZL WNSiG2V0apWPz8/FvYuI8Y+1nKpOT8mWG59yMH4vautbwAxPE4C3Qd20w/nvu5gnRqgE DxOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Z/wR9PDC"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m7si9159439pls.114.2019.04.10.15.44.11; Wed, 10 Apr 2019 15:44:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Z/wR9PDC"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726649AbfDJWmU (ORCPT + 99 others); Wed, 10 Apr 2019 18:42:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:34528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725982AbfDJWmU (ORCPT ); Wed, 10 Apr 2019 18:42:20 -0400 Received: from sinanubuntu1604.mkjiurmyylmellclgttazegk5f.bx.internal.cloudapp.net (unknown [23.96.42.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E603120830; Wed, 10 Apr 2019 22:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554936139; bh=8WK860sKSnflj0EGOs8UxQFwZKdjz5fHNUUwbVx4ve0=; h=From:To:Cc:Subject:Date:From; b=Z/wR9PDC+uj4VgiHX+OXbu6GM/ou1xVWPCkCpOL3QHio4dl/IRq4cjB6QcoERRjTf TXKlGjiWruVBw6zmzi8DNphDJRxIBanPjFD4NLHcXfxkrZ++HjFKukPan+lmzBqkLO mH7aZbS9XJXJG4gheuf07HiSqGcAWBMftWTJmbZs= From: Sinan Kaya To: linux-kernel@vger.kernel.org Cc: Sinan Kaya , Masahiro Yamada , Andrew Morton , Kees Cook , "Peter Zijlstra (Intel)" , Johannes Weiner , Nicholas Piggin , Mathieu Desnoyers , Vasily Gorbik , Adrian Reber , Richard Guy Briggs , Petr Mladek , Andy Shevchenko , Matthew Wilcox , Joe Lawrence , Randy Dunlap , Mikulas Patocka , Robin Murphy , Tetsuo Handa , Changbin Du Subject: [PATCH v2] init: Do not select DEBUG_KERNEL by default Date: Wed, 10 Apr 2019 22:42:10 +0000 Message-Id: <20190410224213.20651-1-okaya@kernel.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We can't seem to have a kernel with CONFIG_EXPERT set but CONFIG_DEBUG_KERNEL unset these days. While some of the features under the CONFIG_EXPERT require CONFIG_DEBUG_KERNEL, it doesn't apply for all features. It looks like CONFIG_KALLSYMS_ALL is the only feature that requires CONFIG_DEBUG_KERNEL. Select CONFIG_EXPERT when CONFIG_DEBUG is chosen but you can still choose CONFIG_EXPERT without CONFIG_DEBUG. Signed-off-by: Sinan Kaya --- init/Kconfig | 2 -- lib/Kconfig.debug | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/init/Kconfig b/init/Kconfig index 4592bf7997c0..37e10a8391a3 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -1206,8 +1206,6 @@ config BPF menuconfig EXPERT bool "Configure standard kernel features (expert users)" - # Unhide debug options, to make the on-by-default options visible - select DEBUG_KERNEL help This option allows certain base kernel options and settings to be disabled or tweaked. This is for specialized diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 0d9e81779e37..9fbf3499ec8d 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -434,6 +434,7 @@ config MAGIC_SYSRQ_SERIAL config DEBUG_KERNEL bool "Kernel debugging" + default EXPERT help Say Y here if you are developing drivers or trying to debug and identify kernel problems. -- 2.21.0