Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: XtYuPIB/QZ0IQatOWiN54Wa86CCQf3cuRC/cHd/LmeMUbL2j91T5RkvGYAlnSc+nRDJMyg8NsF
 E7uqN2JoYr0CL9fAApemwGFcQO9liLFOTElWr1af2QbSk2ZKO8sFEVxgYn806a52N2yy8dBFpU
 UNrDxM1vwpx9IgfFnx9uc9Be+6QjN++YKhZfcpeyG88YGVusBKOorG8xJ49vl4YjymsfBg3YCo
 rXKKe7EpPCDBTq1RYyS1871EtIYqdsCrVUqbJwQS/1RU3SGwS3R4WZt6CLlIS/NKP0yb6hmOMl
 ZnNCJM2Cl4ckXWbGy8+tYf1k
IronPort-SDR: m/18FSUIFv2lEJf2eefSFGl4WdeRvmz0Q9jV/kflxUyi6lCOts3bODYymr211SYu9PuY7EnEkG
 gCRt+KpD4F/6+c1QJkLWDJPBGvbJvInvvERne/fbhORuResiADleeMy1dzR9KwhmIPCkoOxu5u
 L4NOkQOFioR4wF6INiDb2Pnp3rmwh0iLnAPuXUGXAMTX+Xk2+vYaxBx0C/aOPBtftQ4u0/m68j
 GVbxa7tSFTVgC5z+xh8gZ3b4MMPOPjqXoYhFoxYoayrqZAFpb3usg3vIJ6z36Y7/AFACbqV+a7
 xlw=
From:   Atish Patra <atish.patra@wdc.com>
To:     linux-kernel@vger.kernel.org
Cc:     Atish Patra <atish.patra@wdc.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Anup Patel <anup@brainfault.org>,
        Borislav Petkov <bp@alien8.de>, Gary Guo <gary@garyguo.net>,
        "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
        linux-riscv@lists.infradead.org,
        Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
        Palmer Dabbelt <palmer@sifive.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
Subject: [1/3] x86: Update DEBUG_TLBFLUSH options description.
Date:   Wed, 10 Apr 2019 15:44:47 -0700
Message-Id: <20190410224449.10877-2-atish.patra@wdc.com>
In-Reply-To: <20190410224449.10877-1-atish.patra@wdc.com>
References: <20190410224449.10877-1-atish.patra@wdc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

CONFIG_DEBUG_TLBFLUSH was added in 'commit 3df3212f9722 ("x86/tlb: add
tlb_flushall_shift knob into debugfs")' to support tlb_flushall_shift
knob. The knob was removed in 'commit e9f4e0a9fe27 ("x86/mm: Rip out
complicated, out-of-date, buggy TLB flushing")'.  However, the debug
option was never removed from Kconfig. It was reused in commit
'9824cf9753ec ("mm: vmstats: tlb flush counters")' but the commit text was
never updated accordingly.

Update the Kconfig option description as per its current usage.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
---
 arch/x86/Kconfig.debug | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index 15d0fbe27872..c1a48d4ffebb 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -125,21 +125,12 @@ config DOUBLEFAULT
 	  hair.
 
 config DEBUG_TLBFLUSH
-	bool "Set upper limit of TLB entries to flush one-by-one"
+	bool "Save tlb flush statstics to vmstat"
 	depends on DEBUG_KERNEL
 	---help---
 
-	X86-only for now.
-
-	This option allows the user to tune the amount of TLB entries the
-	kernel flushes one-by-one instead of doing a full TLB flush. In
-	certain situations, the former is cheaper. This is controlled by the
-	tlb_flushall_shift knob under /sys/kernel/debug/x86. If you set it
-	to -1, the code flushes the whole TLB unconditionally. Otherwise,
-	for positive values of it, the kernel will use single TLB entry
-	invalidating instructions according to the following formula:
-
-	flush_entries <= active_tlb_entries / 2^tlb_flushall_shift
+	Add tlbflush statstics to vmstat. It is really helpful understand tlbflush
+	performance and behavior. It should be enabled only for debugging purpose.
 
 	If in doubt, say "N".
 
-- 
2.21.0