Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5429056yba; Wed, 10 Apr 2019 20:14:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqySbT/FAZOJNrzsKT+p1YNG+OFtLF4V58p9j772Eg4NdNWNUPIGghxvZ34gYvi84isWDwGY X-Received: by 2002:a17:902:b191:: with SMTP id s17mr46187063plr.70.1554952499459; Wed, 10 Apr 2019 20:14:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554952499; cv=none; d=google.com; s=arc-20160816; b=f+wYKXJSNH0RpxMh9H0RvzhS0094FIeqdyqx0oCqohyc10g0Oh/5xv6bu+cMlcRoyC 3LW6mep101XI2tD5UrHsU8UPc6ZgMy6eIr96z7VulST/vmhyOVRP5g8hcKG5HZv1yQR1 JlOm/hH7lG59AFm2MEcdoXm96HoTTDh0EFq7fl/T9YHlrYh3XtTIg9yJjfLLNvi/tDo6 trfxTm8yQM+oJCdrbcNqRSRdBxwGbu/t+tJDJwafWwXWsNMPf24UwgKrGTO2/kOUaFTj pLkSQWyH+shFc9wXlUqcSJe3kN4jQk6xz/ABii55gzVwSGg15VLrJXvG69WAuV+GtHNi sH/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:subject:from:dkim-signature; bh=yarpaGMsaE+EItRjUnPuzHRP+F0uBBWkdIMrh2vaERc=; b=cq8eNEuA2POnCfTGNH1myULy6RFjxFbU7fxHbutZ/zgoIZDC7bMrzR/MIXe8acjJzD R/GUcQRYRtNPzmurch6dd7sI5WWoCXcfZW/hfCJiXOPk8qktEgwpcs01j5aIFItOZsLj pWnNYqJSm1m5ZaJ1m7XWFu1+n1U1C9caZZ/UGUbLuN+oEX++q/stqvlgo2D2kmKeytE/ b3GJPxspiXOFMqrlWYRrft6XCX/SA0od7UZPlYG32FXPLQAi2RKmwN8TAfxcK5bfjB3I LMzumv/+FUybE3zzdqlVU+YovuJ3adrvGHhqQO+KsWV8xXklcrF2SXFpq52n+Fu66Sar okmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=hsK4eg6X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c10si7365381pla.231.2019.04.10.20.14.43; Wed, 10 Apr 2019 20:14:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=hsK4eg6X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726717AbfDKDNz (ORCPT + 99 others); Wed, 10 Apr 2019 23:13:55 -0400 Received: from mail-yb1-f193.google.com ([209.85.219.193]:36844 "EHLO mail-yb1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbfDKDNy (ORCPT ); Wed, 10 Apr 2019 23:13:54 -0400 Received: by mail-yb1-f193.google.com with SMTP id e76so1678726ybc.3 for ; Wed, 10 Apr 2019 20:13:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yarpaGMsaE+EItRjUnPuzHRP+F0uBBWkdIMrh2vaERc=; b=hsK4eg6XWVwQTSPyKdu5W/9Rzvu/5q7ADbZEmLmamCMV9qIS+JU3VBwprw6Ird30e2 jA2l2EpOf9KEZ5PR2XQ7i1T3mM55/lYitbUeN1PGmiAva8t5yW5c+VHUKqWHkjDCkkWt +piFaKpIXlsf9a0P5UrPdj+Niy0/HinrDZ/54SHgdXQjGVz0hRBma0YKUaJK2U4ki+to kQvwxlIgJGZ6q0l3A3JLgw4nhI9qnLOA8Esm7PRnWsefd31eAuxw3UrOMpqzCABnFCwi i8tIXt5d6dD0qMlZopLLSTjTv1ndZok3o+GDDFBS/EOrDuCQnl9kTrCcNFg+PMYntaXh JJeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:subject:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yarpaGMsaE+EItRjUnPuzHRP+F0uBBWkdIMrh2vaERc=; b=TOHXiwY+08kdddg4oTv4HqdY2YA8uLN2eOFNbQme7e366SKICvCxanAFwDy1Uo+AbX 4K4gEZ7xukaavzFg6FYfNTlnGRwXLPf7J1uJTkCPL0dGubkjwtQycTsM9zWuGP0kXaZ1 EBERfAV8y+wpL9a5P2gLxrxKHnX7GGi48UBx0DY0lAV68TP96S13YLsZ/VodEPBnRhks cYOrRIsFrEP8K2bXjtcVvMjXrRTuwS62ZoRNeoNPEfhnszUPJ8ICk0ExjJvG1lgOBGEX hpwFle1jnZZYIdiEHlTtKQF43Ba3BERblVGlLoTVrytnL2nqrp2sd2ojlbepLHXGdx+h 8Etg== X-Gm-Message-State: APjAAAWpqfKPCblfdtY1fJZREeT13AyRzbJkTiLShGeXdhCD013Eu7YC XNItGgCFmyqpOg0ID5RMbvo= X-Received: by 2002:a25:41c1:: with SMTP id o184mr11485642yba.183.1554952433853; Wed, 10 Apr 2019 20:13:53 -0700 (PDT) Received: from [192.168.1.74] (75-58-59-55.lightspeed.rlghnc.sbcglobal.net. [75.58.59.55]) by smtp.gmail.com with ESMTPSA id 74sm8070279ywe.81.2019.04.10.20.13.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 20:13:53 -0700 (PDT) From: Sinan Kaya X-Google-Original-From: Sinan Kaya Subject: Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default To: Josh Triplett , Kees Cook Cc: LKML , Masahiro Yamada , Andrew Morton , "Peter Zijlstra (Intel)" , Johannes Weiner , Nicholas Piggin , Mathieu Desnoyers , Vasily Gorbik , Adrian Reber , Richard Guy Briggs , Petr Mladek , Andy Shevchenko , Matthew Wilcox , Joe Lawrence , Randy Dunlap , Mikulas Patocka , Robin Murphy , Tetsuo Handa , Changbin Du , Frederic Weisbecker , Sam Ravnborg , Ingo Molnar References: <20190410224213.20651-1-okaya@kernel.org> <135E84E9-F068-44CB-B4F6-A5AC2F4CDE3D@joshtriplett.org> Message-ID: Date: Wed, 10 Apr 2019 23:13:52 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/10/2019 11:02 PM, Josh Triplett wrote: > Then let's fix*that*, and get checkpatch to help enforce it in the future. EXPERT doesn't affect code generation, and neither should this. I think we have to do both. We need to go after the users as well as solve the immediate problem per this patch. As Mathieu identified, CONFIG_DEBUG_KERNEL is being used all over the place and getting subsystem owners to remove let alone add a check to checkpatch is just going to take time. Please let us know if you are OK with this plan.