Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5430047yba; Wed, 10 Apr 2019 20:16:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqxnk+KBU8FySDFVJ2yosvQFAewxBMxTwmrXq0nRHehCaHtoQnn1KVmzQyUFUHAawXYyvvD6 X-Received: by 2002:a17:902:b481:: with SMTP id y1mr9805907plr.161.1554952599415; Wed, 10 Apr 2019 20:16:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554952599; cv=none; d=google.com; s=arc-20160816; b=ROMETKFs3K2DQxEyLeByeGEgll7NSUPma0YRxkp+xUYcBtyQsbYsg4CIpr8E0bhn0Z IxFLrxaNcgBvN8ByBZ40ybe5ANhhLRHsE0RRfQCba6soYcwK8am6qjbDoHSigrf0iCc7 PH4zb0V6T7+40g1Z6V9gr6YNMnqZVUYUyHkz4p0PF03OuPJiE+z0qlMqRYaOjxY6C/+M 6M+vxKrXVm4vu4sBQCjViouYRNdjo/DRrLHm9kQFxeigS8Ip38Kxhie11TwPNHfvEihK BgVbGibzC4hI9x+3Y8ekwoG5T8WqCUP3jipAcbdfLfQ6DNYgTgupcSVXl1KTmncYpUNu OP+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=V2a7SiMlQ8P6sQfZS+jUcSN/tLlscA3p7VdfQYPLowY=; b=nFYnRbmyHbmV0mD77dEuklgUgXpg2OEjVb3pBPL6zDnC37rEcU57e9MnZv6dNpdg6v Qy5p/cVosQBfPCFppZsPWTEZZTFdisQcbAwAQC1OB88G+L0QkKL2uTuJr3qUvfg1JX7R VT+XUY71GCIKJf2A75dcD/YBi/BCRonhS9TDa7L3SmiZ0hLxUhOualVAwpzEF+5FqG9J iGqVCmmxpRyj9dxDXS+7j+WVJGu/jyA68yBP3HyJ3o/DV1uMYQq2tgbuxPpjij+dBnF+ 9aa/Kml+T1ZcpE3nOV6h6OhSuZ5HSUBvy/zGLm2oLwvathIiKmnx9yFw7BmwgeFoTkQ0 EoAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nlO9jVLq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i3si33902579pld.129.2019.04.10.20.16.23; Wed, 10 Apr 2019 20:16:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nlO9jVLq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726691AbfDKDPr (ORCPT + 99 others); Wed, 10 Apr 2019 23:15:47 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:36202 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbfDKDPq (ORCPT ); Wed, 10 Apr 2019 23:15:46 -0400 Received: by mail-pg1-f194.google.com with SMTP id 85so2764650pgc.3; Wed, 10 Apr 2019 20:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=V2a7SiMlQ8P6sQfZS+jUcSN/tLlscA3p7VdfQYPLowY=; b=nlO9jVLqHhncQxlUUmukEz3YnoJKI7vlao94/IogK2D1OEr3rUptNQPvGF3XWdTOlI fz2nRZFHfESnahdW98+MfBe8vgOKXCnWRQEtBvny2nn5VkzgO53PB6wy1Vgnr/o9QPS4 Gp1wKNqkQfOEisD7qC+G9IRVk2D3F9CiIb2TmK8hGHEoDgf+REiXTG0tEuUUWY+PNA/4 9ffazHCpVotMKYn8WVLvJXhdJkL6EAEImBt4gKdatWGEammb9mduQ8+4+eChvzNlWQg/ aadLf6bScXzUDDZd0k9AvSfq3RgK9P+5OeCsSx8bKjRb+EOQB2aY1q6Ra/sBPuWncd/h y5pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=V2a7SiMlQ8P6sQfZS+jUcSN/tLlscA3p7VdfQYPLowY=; b=CH4XtQ+lzLiFCqXlu+74CCzM83XyfSPn5FcvxZJWUx5m+hN8AGLwcq5JjpsQCRxXQl S4DefEMbFoqSUVcR0oEJBL4joVekQMOo0ufHkt6vFUmiwggSfFxHNBlpW8mKO3KO/q5e tixHrhNSIrsmaWARSe2ml7F7KXc9135+LjP4GbgWZQPSPuK0fel2ofnfPiskAfwXDS+w K690g+mftSJZ5ypLLv8ht0/pWB2+0kO4VugP2GtLVvtvFYbJ/5AupbEB2+1Yp3qbT9zI jmCI1srlb7mEutLs8Lwos13YtuQ2ikSmb6Pr1nQzN4sjTQ+YccZji3aAqLLjuX0DEZ1t FRCQ== X-Gm-Message-State: APjAAAX51ybALmcKW9dC9lcFyatIXKEpQRT50BJmHmZ79NWrHXL8mEHb qakwxtXCMD1yWvfXuj/LmR4vAaaj X-Received: by 2002:a63:4620:: with SMTP id t32mr44130049pga.363.1554952545508; Wed, 10 Apr 2019 20:15:45 -0700 (PDT) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:180::e]) by smtp.gmail.com with ESMTPSA id s19sm52184126pfe.74.2019.04.10.20.15.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 20:15:44 -0700 (PDT) Date: Wed, 10 Apr 2019 20:15:42 -0700 From: Alexei Starovoitov To: Olof Johansson Cc: Joel Fernandes , Joel Fernandes , Linux Kernel Mailing List , Qais Yousef , Dietmar Eggemann , Manoj Rao , Andrew Morton , Alexei Starovoitov , atish patra , Daniel Colascione , Dan Williams , Greg Kroah-Hartman , Guenter Roeck , Jonathan Corbet , Karim Yaghmour , Kees Cook , Android Kernel Team , "open list:DOCUMENTATION" , "open list:KERNEL SELFTEST FRAMEWORK" , linux-trace-devel@vger.kernel.org, Masahiro Yamada , Masami Hiramatsu , Randy Dunlap , Steven Rostedt , Shuah Khan , Yonghong Song Subject: Re: [PATCH v5 1/3] Provide in-kernel headers to make extending kernel easier Message-ID: <20190411031540.ehezr6kq7ouobpzx@ast-mbp.dhcp.thefacebook.com> References: <20190320163116.39275-1-joel@joelfernandes.org> <20190408203601.GF133872@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180223 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 10, 2019 at 09:34:49AM -0700, Olof Johansson wrote: > On Wed, Apr 10, 2019 at 8:51 AM Joel Fernandes wrote: > > > > On Wed, Apr 10, 2019 at 11:07 AM Olof Johansson wrote: > > [snip] > > > > > Wouldn't it be more convenient to provide it in a standardized format > > > > > such that you won't have to take an additional step, and always have > > > > > This is that form IMO. ... > Compared to: > - Extract tarball > - Build and load > - Remove file tree from filesystem I think there are too many assumptions in this thread in regard to what is more convenient for user space. I think bcc should try to avoid extracting tarball into file system. For example libbcc can uncompress kheader.tar.xz into virtual file system of clang front-end. It's more or less std::map with key=path, value=content of the file. Access to such in-memory 'files' is obviously faster than doing open/read syscalls. bcc already uses this approach for some bcc internal 'files' that it passes to clang during compilation. All of /proc/kheaders.tar.xz files can be passed the same way without extracting them into real file system. Joel, would be great if you can share corresponding bcc patch that takes advantage of /proc/kheaders