Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5449007yba; Wed, 10 Apr 2019 20:55:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqxS9EXqsOEW/wUu5XaPae1lzFyMwz2HPlsFUOsLGZX+hMDskyTuUQ8iNNmlsmYwRr8p35hq X-Received: by 2002:a63:c10d:: with SMTP id w13mr44923426pgf.311.1554954908839; Wed, 10 Apr 2019 20:55:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554954908; cv=none; d=google.com; s=arc-20160816; b=LTmOgUQ5vTAr4/87GE8rGOS6Db5bb/HNzPkmq+kTgu/TLPvNTO/FBHoidvNjIKuL0w 3ZOGVY/xn5QZmbyJbEYBzETFiEkRLxue65bKkQ5U8m0kzSYXZM2KIbFKXzbNmpRzOawL iUTKFtx3VTUqzN5LPssz7JidTX2AXUNeNCKfLJgfRSH9CcIzipSb7Jau5CREmiHFOpkj PRWIzK+r5XGJTozDo5is+WEo3aikVq0ChOZo6Ti71RQDba0G+jscQ+MkuCRinj+kRwKd 6JRIXv8+MAupsqmCoPbm081e6hfgQE3h6Xe4ap5kHrHTKdmEPERX38uvryiBSBob8fkb ZtKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=4Z91ixljCpwssb/9kTZtnCZqne0XLiVRXDj2DxnE/CA=; b=gcs38d79DYrbj6xtHqlNZziVrlONB/O+3gg1b7EtwkuIROLLZ7gHBkN9G/K7s5K7nS rdrMsAVz9moXi3sofmraIE5RJiL+oxx+zymnjc/i8fmynJOLiVMRWcidncr5r5n1kJoH zhozDir3IwJDW95Z1XhVquqprY7jJOruBCGCWW3Wb6RkBqXzu2Ox1OaXXR58zC8SPztb szxBXwx6b6OQo+KUzI3y7W/owYhH+PuzMSUvncGbRofpO5DcSRJ4CMU1a3V18OyUlAho 25E5aubRGdEO2+/leCMqphDzx1GtcJ4OI8d9+8/XnU5xrcPqheg2qjZ3qw5PJIO2+RO1 dXvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RYtmQxHz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si9771709plz.312.2019.04.10.20.54.52; Wed, 10 Apr 2019 20:55:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RYtmQxHz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726702AbfDKDyS (ORCPT + 99 others); Wed, 10 Apr 2019 23:54:18 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:54700 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbfDKDyS (ORCPT ); Wed, 10 Apr 2019 23:54:18 -0400 Received: by mail-wm1-f65.google.com with SMTP id c1so4778353wml.4; Wed, 10 Apr 2019 20:54:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=4Z91ixljCpwssb/9kTZtnCZqne0XLiVRXDj2DxnE/CA=; b=RYtmQxHzkdNJTKDZ6BIM5SBlKzSiC8auWfjYHGLeql6SAvE+dA0yU14zI6eFvu0lET Sh1sC7wSjyh+leGGQLGtkjFrZAGYZS5hJ9mHpJkvea5ri1KKp5pEZgP/3vzCG/zQOjNF hcMVjfaB+NGbCJyLlYO+1WyElshyurzPJUoSZM6/D1Xlpc6EmkMYT9cDB0wA0Fl3L0K2 rYP/YwziW24uyWmtV/Uhk8DOUgV9p/yQF5cSRcAwdYNGt1fgPUHL7ulJtiQBwKVuTEHN +lHFtoJRZIMVKhSvt8K4Cja7HS6cYqFpI8bRkVCEwxaxTlRePZEnXBtWk+I4yYsNLyYo AndQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4Z91ixljCpwssb/9kTZtnCZqne0XLiVRXDj2DxnE/CA=; b=Wgh4U5jD0ziQWDMXadOzKnmq8PEZuqVWdq52bZPUWiZVQHHHw8BUkIZEe8GT0pBbYr L5FFJu5lCYRlhypvR9SPWgf0lmFDztzsftqs9glZuLwigSLlcAHEBJlGiUNos03ehlY3 IIEv7nZ2q/sf8wwnAYa7KTnUDQtjBqxZsSK0Dd70F4M3R+YmOssUSiiB2BTyNHHxdyT+ APmOW6ZLd2jUG5kJ5mIZsY2Wv5vOU5W9B4WPZMyHZT4nEM6QESQ0n0Twp7O0Uxp5LpYQ n2QQgyR54MZh3d08ivzKup9pIFUAY1+ORsewPDrYf4p4biWuq+oCiNHeMajjNmKsNhJC ZWSg== X-Gm-Message-State: APjAAAWGtg+EvVqoTcMoKAdfC4U4D2Q0/sAcGxqUhhQMn9lRHOD56ONT y6rygTkZIGmzBbr3ezyyomg= X-Received: by 2002:a1c:2087:: with SMTP id g129mr4911807wmg.114.1554954855949; Wed, 10 Apr 2019 20:54:15 -0700 (PDT) Received: from felia.fritz.box ([2001:16b8:2da5:5700:805e:d3ab:f95:5de]) by smtp.gmail.com with ESMTPSA id f1sm3125591wml.28.2019.04.10.20.54.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 20:54:14 -0700 (PDT) From: Lukas Bulwahn To: Alexander Viro , Jens Axboe Cc: Elena Reshetova , Krystian Radlak , linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH RESEND] fs: drop unused fput_atomic definition Date: Thu, 11 Apr 2019 05:53:52 +0200 Message-Id: <20190411035352.19407-1-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit d7065da03822 ("get rid of the magic around f_count in aio") added fput_atomic to include/linux/fs.h, motivated by its use in __aio_put_req() in fs/aio.c. Later, commit 3ffa3c0e3f6e ("aio: now fput() is OK from interrupt context; get rid of manual delayed __fput()") removed the only use of fput_atomic in __aio_put_req(), but did not remove the since then unused fput_atomic definition in include/linux/fs.h. We curate this now and finally remove the unused definition. This issue was identified during a code review due to a coccinelle warning from the atomic_as_refcounter.cocci rule pointing to the use of atomic_t in fput_atomic. Suggested-by: Krystian Radlak Signed-off-by: Lukas Bulwahn --- v1: - sent on 2018-01-12, got no response https://lore.kernel.org/lkml/20190112055430.5860-1-lukas.bulwahn@gmail.com/ v1 resend: - rebased to v5.1-rc4 - added Jens to recipient list as he touched the place lately closeby in commit 091141a42e15 ("fs: add fget_many() and fput_many()") - compile-tested with defconfig on v5.1-rc4 and next-20190410 include/linux/fs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index dd28e7679089..79b2f43b945d 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -969,7 +969,6 @@ static inline struct file *get_file(struct file *f) #define get_file_rcu_many(x, cnt) \ atomic_long_add_unless(&(x)->f_count, (cnt), 0) #define get_file_rcu(x) get_file_rcu_many((x), 1) -#define fput_atomic(x) atomic_long_add_unless(&(x)->f_count, -1, 1) #define file_count(x) atomic_long_read(&(x)->f_count) #define MAX_NON_LFS ((1UL<<31) - 1) -- 2.17.1