Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5484629yba; Wed, 10 Apr 2019 22:03:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqw5S1sjfb8SkuoKVe7CmqdcXLJrQKmcm5WniIEB84owuqAhgA5bfRN8suPvcylpiuFJmxqm X-Received: by 2002:a17:902:2a89:: with SMTP id j9mr48391187plb.272.1554958983577; Wed, 10 Apr 2019 22:03:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554958983; cv=none; d=google.com; s=arc-20160816; b=JkOsr3MrO/XqQkTb+NlP4Pe3gOY3H0f858UoGNeWJc819RO3HCH+eRT/ih6/yF1dY9 0TiP8lWSq1lB7wxApdyg5jkS6PdjOSyu2zg6ifLigZRTvcKSxdqhR481lmX8je5Z39zl Yp8CE1y6/N+tsswxvC0WUq9MyYKnkLC8nYOHq9ZVWedgsYs2lpYxw++R41xHeXk4f5Wf At3mpqZPd5OlxQJUsNqj9qLnWbQpGO+hAAXM/Fy1F+AfUscIs5ICvnFxS5EI63NpEoji YNDt2HPb24eMsQ+AZX4JYMH8g3zvhNDHl7BTXtjM0Zrtffb8qEOUovP0HYv48v1VYJKI 6NOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:mime-version:date:references :in-reply-to:subject:cc:to:from; bh=KpanwOw0JYh/TZR6CN1TTe0lwOgReBJayaYE6OEhdh0=; b=spBivQWnhmS7priZKuWlQffoCMneRpS2/xxYKoMXEp7X8f0AMA4KAPk04KTk+JVIks 4HB8Dp9BjEiDM7jXe8A/FUZd98mnb9hIpXe82uegnE6PsCcoAaKcChXhIuLO859i61Oe Eq7X8pLuktd1MauDh/Tujc+yL3/TlJnOHPbXATxHa+WtlSC7oCejs4PaBPiJ6XJv5irP A4QBkM5eopJjeU0J5Nilt5qHB5bGmknGLXH9inTPSvmdyD364vtb0O05m20tuIIVPfDW iSyqdM0VeBUlWZr78nV+s1Yci144nysV4M0HJ3XogoGhOpuFnszSXs2GNrycMt2zZeVp oQEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t26si7428880pgu.327.2019.04.10.22.02.47; Wed, 10 Apr 2019 22:03:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726139AbfDKFCO (ORCPT + 99 others); Thu, 11 Apr 2019 01:02:14 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50394 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbfDKFCN (ORCPT ); Thu, 11 Apr 2019 01:02:13 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3B506vD052780 for ; Thu, 11 Apr 2019 01:02:12 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rsw9tmb22-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 11 Apr 2019 01:02:11 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Apr 2019 06:02:09 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 11 Apr 2019 06:02:07 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x3B5265U50659374 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2019 05:02:06 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6AB485205A; Thu, 11 Apr 2019 05:02:06 +0000 (GMT) Received: from skywalker.linux.ibm.com (unknown [9.85.73.26]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 113E652059; Thu, 11 Apr 2019 05:02:04 +0000 (GMT) X-Mailer: emacs 26.1 (via feedmail 11-beta-1 I) From: "Aneesh Kumar K.V" To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v1 06/15] powerpc/Kconfig: select PPC_MM_SLICES from subarch type In-Reply-To: <2cd783f6975b126f024ee0965047342b6c36bded.1554321743.git.christophe.leroy@c-s.fr> References: <2cd783f6975b126f024ee0965047342b6c36bded.1554321743.git.christophe.leroy@c-s.fr> Date: Thu, 11 Apr 2019 10:32:03 +0530 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 19041105-0012-0000-0000-0000030D91DB X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19041105-0013-0000-0000-00002145B852 Message-Id: <87zhox3zjo.fsf@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-11_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=923 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904110035 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe Leroy writes: > Lets select PPC_MM_SLICES from the subarch config item instead of > doing it via defaults declaration in the PPC_MM_SLICES item itself. > Did we miss the book3s 64 default y here? > Signed-off-by: Christophe Leroy > --- > arch/powerpc/platforms/Kconfig.cputype | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype > index 842b2c7e156a..a46a0adb634d 100644 > --- a/arch/powerpc/platforms/Kconfig.cputype > +++ b/arch/powerpc/platforms/Kconfig.cputype > @@ -34,6 +34,7 @@ config PPC_8xx > bool "Freescale 8xx" > select FSL_SOC > select SYS_SUPPORTS_HUGETLBFS > + select PPC_MM_SLICES if HUGETLB_PAGE > > config 40x > bool "AMCC 40x" > @@ -75,6 +76,7 @@ config PPC_BOOK3S_64 > select ARCH_ENABLE_THP_MIGRATION if TRANSPARENT_HUGEPAGE > select ARCH_SUPPORTS_NUMA_BALANCING > select IRQ_WORK > + select PPC_MM_SLICES > > config PPC_BOOK3E_64 > bool "Embedded processors" > @@ -360,8 +362,6 @@ config PPC_BOOK3E_MMU > > config PPC_MM_SLICES > bool > - default y if PPC_BOOK3S_64 > - default y if PPC_8xx && HUGETLB_PAGE > > config PPC_HAVE_PMU_SUPPORT > bool > -- > 2.13.3