Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5564075yba; Thu, 11 Apr 2019 00:23:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqxWiKgE+HVZDJ2MQS9SviztO7ARgHrkGRd7iY0VP2IdnhvRmPJohNGOwghWvMwOTXCzxN3q X-Received: by 2002:a63:3dca:: with SMTP id k193mr44292770pga.146.1554967407827; Thu, 11 Apr 2019 00:23:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554967407; cv=none; d=google.com; s=arc-20160816; b=BvQpfOonwd0lO0usLjIzGr8SF/PS+quaOyhvKVyKhCH/4+0uI0GROFl+DaG4GYV8gn Tb3Gr9l46T8ujBxhlWN1ZyQRTGYIeDKXAfEKy+0cI9kSvEcPlfu9xwHWxooqv8SiKP0K 2fNvg72/BD6qTIl3oEj1VwGUrHSyCAJclphYMCLYoX+5ZBxeuMNzSF3xAQxLTyzq79+j oVx7yN8QICFetI/dOieP6Lw5+QHUanpv9Nm6NOWEYq8nSjEXNuhjwRa4Ww9oF0405kBJ Me4h8j6jpLHMRb6zhNwIE8hLldu+GeUyil4AxDMTItaYPhFwvb1of4w/9UIOOLn1Von+ lr+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=gwXOzqYsTJdgXggtN8KTNGl+0QEJJchUS+eWs+lkNlU=; b=HKMPoi6n9QpU0olwlWikSdtQUE4vfKt2xk9rcsHd4jVzrNoKfi3049d1EoTVI5tyGc q3UrVSGS17T7EXu+R25WJYzmTKnBZMMsCystnqvz9WqaMu1mkte5BFxQWY8kxAY5SMRi 4Xb9OnjnimwGR7qrdjjJZB/HCxwJHdOxuAJOyaZiNqeSoRWUGUeAmxUfgmB150NkA3Kz yZvBG4iqkY/1UKhj90toBpZYdnsx+24mO4J5wuhG0QG9uFaXXDpqBOus/MoHzHTWcwIz 6mA3uQjEwNMxNz20NOwOldXC2SXcT8rF3k6BHOGxjvfSIpksdjpKH3s3BvIKNiAxV6IT j9ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=38UGEhJ8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p187si36035023pfp.89.2019.04.11.00.23.10; Thu, 11 Apr 2019 00:23:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=38UGEhJ8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726706AbfDKHW3 (ORCPT + 99 others); Thu, 11 Apr 2019 03:22:29 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:59254 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbfDKHW3 (ORCPT ); Thu, 11 Apr 2019 03:22:29 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3B7EL2l091664; Thu, 11 Apr 2019 07:22:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=gwXOzqYsTJdgXggtN8KTNGl+0QEJJchUS+eWs+lkNlU=; b=38UGEhJ8dKjNWUv4p5mmKMgDjgKqWZ1R8RqQm+5n95o/KOOfq2wPnhnjtzVor03wu0HN 6TQpqkbujkiO+i8WNqnhKcHI9ToXw89vdgwoXA8hhY9IBVjgeDkwRZPkrumbTYPfmt89 HnlzpvhJeTU6SuiiwZWfImXBhxUOUgsCviaNfv+WrZkn8x/iE/EBQWh8jG4A179LwScx qChKskoRKds1bnQgjFadEB2a9TYULU2XEEYQhtOmx8juyfCmVzO9NnzREKDmQ8CutCgj GT7cBcwjqcVqwUC14M/i+icCI73rsqnf2RKCiptqL8+StrO3CPPQD92Lk/+oBGkM+luR yw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2rpmrqf2x6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2019 07:22:22 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3B7LwdY134930; Thu, 11 Apr 2019 07:22:21 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2rpkeka375-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2019 07:22:21 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x3B7MJuk024389; Thu, 11 Apr 2019 07:22:20 GMT Received: from kadam (/41.202.241.15) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 11 Apr 2019 00:22:19 -0700 Date: Thu, 11 Apr 2019 10:22:08 +0300 From: Dan Carpenter To: Madhumthia Prabakaran Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data Message-ID: <20190411072208.GI6095@kadam> References: <20190409161617.29871-1-madhumithabiw@gmail.com> <20190410064954.GE6095@kadam> <20190410194908.GA13242@madhuleo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190410194908.GA13242@madhuleo> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9223 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904110051 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9223 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904110051 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 10, 2019 at 02:49:09PM -0500, Madhumthia Prabakaran wrote: > On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote: > > On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote: > > > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h > > > index bafb2c30e7fb..b0623c936940 100644 > > > --- a/drivers/staging/rtl8723bs/include/drv_types.h > > > +++ b/drivers/staging/rtl8723bs/include/drv_types.h > > > @@ -220,7 +220,7 @@ struct registry_priv > > > #define BSSID_SZ(field) sizeof(((struct wlan_bssid_ex *) 0)->field) > > > > > > #include > > > -#define INTF_DATA SDIO_DATA > > > +#define INTF_DATA struct sdio_data > > > > > > > Just get rid of INTF_DATA data as well. It's only used once a bit lower > > in the file. (Get rid of the ifdef around it). > > But, reference of INTF_DATA is also included in file > ./drivers/staging/rtl8723bs/include/drv_types.h:487: > return &dvobj->intf_data.func->dev; > Yes. That's what I meant. Get rid of that one and the ifdefs around it. regards, dan carpenter