Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 11 Apr 2019 15:40:29 +0800
From:   Mao Han <han_mao@c-sky.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] perf: use hweight64 instead of hweight_long
Message-ID: <20190411074024.GA8981@vmh-VirtualBox>
References: <cover.1554883878.git.han_mao@c-sky.com>
 <29ad7947dc8fd1ff0abd2093a72cc27a2446be9f.1554883878.git.han_mao@c-sky.com>
 <20190410130841.GE13888@kernel.org>
 <20190410131042.GF13888@kernel.org>
 <20190410132837.GG13888@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190410132837.GG13888@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 10, 2019 at 10:28:37AM -0300, Arnaldo Carvalho de Melo wrote:
> > > You forgot to convert that one, doing it for you,
> > 
> > Also in perf_event__sample_event_size() we need to do the same thing,
> > right?
> 
> and perf_event__synthesize_sample()
> 
> Done, resulting patch is at the end of this messages, and matches the
> kernel, that uses only hweight64().
> 
> I've also added Fixes tags to the patches that used hweight_long() in
> various places, to help with the stable trees backporting process,
> please consider doing it next time.
> 
> - Arnaldo
>

Thanks for help improving the patch and the suggestion.
Tested with the new patch on C-SKY, seems work fine.

Mao Han