Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1554964555.21725.14.camel@suse.com>
Subject: Re: [PATCH] usb/hcd: Send a uevent signaling that the host
 controller has died
From:   Oliver Neukum <oneukum@suse.com>
To:     Raul E Rangel <rrangel@chromium.org>, linux-usb@vger.kernel.org
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>, djkurtz@chromium.org,
        Dmitry Torokhov <dtor@chromium.org>, groeck@chromium.org,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Roger Quadros <rogerq@ti.com>, linux-kernel@vger.kernel.org
In-Reply-To: <20190410203520.248158-1-rrangel@chromium.org>
References: <20190410203520.248158-1-rrangel@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Date:   Thu, 11 Apr 2019 08:35:55 +0200
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mi, 2019-04-10 at 14:35 -0600, Raul E Rangel wrote:
> This change will send a CHANGE event to udev with the DEAD environment
> variable set when the HC dies. I chose this instead of any of the other
> udev events because it's representing a state change in the host
> controller. The only other event that might have fit was OFFLINE, but
> that seems to be used for hot-removal.
> 
> By notifying user space the appropriate policies can be applied.
> e.g.,
>  * Collect error logs.
>  * Notify the user that USB is no longer functional.
>  * Perform a graceful reboot.

Could you please make sure this type of event is shared with other
subsystems whose devices can "die"?
It looks to me like SCSI offline should for example create the
same event. This kind of thing needs to be documented.

	Regards
		Oliver